Re: [ptxdist] [PATCH] minicoredumper: New package

[Roland Hieber <r.hieber@pengutronix.de>]

On Tue, Aug 14, 2018 at 11:57:44AM +0200, Roland Hieber wrote:
> On Mon, Aug 13, 2018 at 04:57:48PM +0200, Uwe Kleine-König wrote:
[...]
> > diff --git a/rules/minicoredumper.make b/rules/minicoredumper.make
> > new file mode 100644
> > index 000000000000..b63be8c2ba19
> > --- /dev/null
> > +++ b/rules/minicoredumper.make
> > @@ -0,0 +1,82 @@
> > +# -*-makefile-*-
> > +#
> > +# Copyright (C) 2018 by Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>
> > +#
> > +# See CREDITS for details about who has contributed to this project.
> > +#
> > +# For further information about the PTXdist project and license conditions
> > +# see the README file.
> > +#
> > +
> > +#
> > +# We provide this package
> > +#
> > +PACKAGES-$(PTXCONF_MINICOREDUMPER) += minicoredumper
> > +
> > +#
> > +# Paths and names
> > +#
> > +MINICOREDUMPER_VERSION	:= 2.0.1
> > +MINICOREDUMPER_MD5	:= 813b864e0c6a833d14bab244723de6a4
> > +MINICOREDUMPER		:= minicoredumper-$(MINICOREDUMPER_VERSION)
> > +MINICOREDUMPER_SUFFIX	:= tar.xz
> > +MINICOREDUMPER_URL	:= https://linutronix.de/minicoredumper/files/$(MINICOREDUMPER).$(MINICOREDUMPER_SUFFIX)
> > +MINICOREDUMPER_SOURCE	:= $(SRCDIR)/$(MINICOREDUMPER).$(MINICOREDUMPER_SUFFIX)
> > +MINICOREDUMPER_DIR	:= $(BUILDDIR)/$(MINICOREDUMPER)
> > +MINICOREDUMPER_LICENSE	:= BSD LGPG-2.1
> > +MINICOREDUMPER_LICENSE_FILES := file://COPYING;md5=71827c617ec7b45a0dd23658347cc1e9
> > +
> > +# ----------------------------------------------------------------------------
> > +# Extract
> > +# ----------------------------------------------------------------------------
> > +
> > +$(STATEDIR)/minicoredumper.extract: $(STATEDIR)/autogen-tools
> 
> Interesting, I didn't know this one yet. Apparently it generates a
> configure script when only a configure.ac is present?

Hm. On second read of ptxdist/rules/pre/autogen.make, this should be a
no-op as long as no patches/$(MINICOREDUMPER)/autogen.sh is present,
which is the case here. Does it work for you as intended?

 - Roland

> > +
> > +$(STATEDIR)/minicoredumper.extract:
> > +	@$(call targetinfo)
> > +	@$(call clean, $(MINICOREDUMPER_DIR))
> > +	@$(call extract, MINICOREDUMPER)
> > +	@$(call patchin, MINICOREDUMPER)
> > +	@$(call touch)
> > +
> > +# ----------------------------------------------------------------------------
> > +# Prepare
> > +# ----------------------------------------------------------------------------
> > +
[...]

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de