* [ptxdist] [PATCH] minicoredumper: New package @ 2018-08-13 14:57 Uwe Kleine-König 2018-08-14 9:57 ` Roland Hieber 2018-08-14 16:15 ` [ptxdist] [PATCH v2] " Uwe Kleine-König 0 siblings, 2 replies; 10+ messages in thread From: Uwe Kleine-König @ 2018-08-13 14:57 UTC (permalink / raw) To: ptxdist For now this only installs the binary but doesn't register it as coredump-helper yet. So you have to do echo '|/usr/sbin/minicoredumper %P %u %g %s %t %h %e' > /proc/sys/kernel/core_pattern by hand to actually make use of it. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- rules/minicoredumper.in | 13 +++++++ rules/minicoredumper.make | 82 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 95 insertions(+) create mode 100644 rules/minicoredumper.in create mode 100644 rules/minicoredumper.make diff --git a/rules/minicoredumper.in b/rules/minicoredumper.in new file mode 100644 index 000000000000..fc9984785719 --- /dev/null +++ b/rules/minicoredumper.in @@ -0,0 +1,13 @@ +## SECTION=shell_and_console + +config MINICOREDUMPER + bool + prompt "minicoredumper" + select LIBELF + select JSON_C + help + The minicoredumper project provides a program that handles the + creation of core dump files on Linux. It can produce much smaller + core dump files by making use of sparse files, compression, and + allowing the user to configure what parts of the process memory image + should be dumped. diff --git a/rules/minicoredumper.make b/rules/minicoredumper.make new file mode 100644 index 000000000000..b63be8c2ba19 --- /dev/null +++ b/rules/minicoredumper.make @@ -0,0 +1,82 @@ +# -*-makefile-*- +# +# Copyright (C) 2018 by Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de> +# +# See CREDITS for details about who has contributed to this project. +# +# For further information about the PTXdist project and license conditions +# see the README file. +# + +# +# We provide this package +# +PACKAGES-$(PTXCONF_MINICOREDUMPER) += minicoredumper + +# +# Paths and names +# +MINICOREDUMPER_VERSION := 2.0.1 +MINICOREDUMPER_MD5 := 813b864e0c6a833d14bab244723de6a4 +MINICOREDUMPER := minicoredumper-$(MINICOREDUMPER_VERSION) +MINICOREDUMPER_SUFFIX := tar.xz +MINICOREDUMPER_URL := https://linutronix.de/minicoredumper/files/$(MINICOREDUMPER).$(MINICOREDUMPER_SUFFIX) +MINICOREDUMPER_SOURCE := $(SRCDIR)/$(MINICOREDUMPER).$(MINICOREDUMPER_SUFFIX) +MINICOREDUMPER_DIR := $(BUILDDIR)/$(MINICOREDUMPER) +MINICOREDUMPER_LICENSE := BSD LGPG-2.1 +MINICOREDUMPER_LICENSE_FILES := file://COPYING;md5=71827c617ec7b45a0dd23658347cc1e9 + +# ---------------------------------------------------------------------------- +# Extract +# ---------------------------------------------------------------------------- + +$(STATEDIR)/minicoredumper.extract: $(STATEDIR)/autogen-tools + +$(STATEDIR)/minicoredumper.extract: + @$(call targetinfo) + @$(call clean, $(MINICOREDUMPER_DIR)) + @$(call extract, MINICOREDUMPER) + @$(call patchin, MINICOREDUMPER) + @$(call touch) + +# ---------------------------------------------------------------------------- +# Prepare +# ---------------------------------------------------------------------------- + +MINICOREDUMPER_CONF_TOOL := autoconf +MINICOREDUMPER_CONF_OPT := \ + $(CROSS_AUTOCONF_USR) \ + --disable-silent-rules \ + --without-coreinject \ + --with-minicoredumper \ + --without-minicoredumper_regd \ + --without-minicoredumper_trigger \ + --without-libminicoredumper \ + --without-minicoredumper_demo \ + --without-werror \ + +# ---------------------------------------------------------------------------- +# Target-Install +# ---------------------------------------------------------------------------- + +$(STATEDIR)/minicoredumper.targetinstall: + @$(call targetinfo) + + @$(call install_init, minicoredumper) + @$(call install_fixup, minicoredumper, PRIORITY, optional) + @$(call install_fixup, minicoredumper, SECTION, base) + @$(call install_fixup, minicoredumper, AUTHOR, "Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>") + @$(call install_fixup, minicoredumper, DESCRIPTION, missing) + + @$(call install_copy, minicoredumper, 0, 0, 0755, -, /usr/sbin/minicoredumper) + + @$(call install_alternative_tree, minicoredumper, 0, 0, /etc/minicoredumper) + + @$(call install_copy, minicoredumper, 0, 0, 0755, /var/crash) + @$(call install_copy, minicoredumper, 0, 0, 0755, /var/crash/minicoredumper) + + @$(call install_finish, minicoredumper) + + @$(call touch) + +# vim: syntax=make -- 2.18.0 _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [ptxdist] [PATCH] minicoredumper: New package 2018-08-13 14:57 [ptxdist] [PATCH] minicoredumper: New package Uwe Kleine-König @ 2018-08-14 9:57 ` Roland Hieber 2018-08-14 10:14 ` Roland Hieber 2018-08-14 16:15 ` [ptxdist] [PATCH v2] " Uwe Kleine-König 1 sibling, 1 reply; 10+ messages in thread From: Roland Hieber @ 2018-08-14 9:57 UTC (permalink / raw) To: Uwe Kleine-König; +Cc: ptxdist On Mon, Aug 13, 2018 at 04:57:48PM +0200, Uwe Kleine-König wrote: > For now this only installs the binary but doesn't register it as > coredump-helper yet. So you have to do > > echo '|/usr/sbin/minicoredumper %P %u %g %s %t %h %e' > /proc/sys/kernel/core_pattern > > by hand to actually make use of it. This should be added to the kconfig help text where the users can see it. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > rules/minicoredumper.in | 13 +++++++ > rules/minicoredumper.make | 82 +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 95 insertions(+) > create mode 100644 rules/minicoredumper.in > create mode 100644 rules/minicoredumper.make > > diff --git a/rules/minicoredumper.in b/rules/minicoredumper.in > new file mode 100644 > index 000000000000..fc9984785719 > --- /dev/null > +++ b/rules/minicoredumper.in > @@ -0,0 +1,13 @@ > +## SECTION=shell_and_console > + > +config MINICOREDUMPER > + bool > + prompt "minicoredumper" > + select LIBELF > + select JSON_C > + help > + The minicoredumper project provides a program that handles the > + creation of core dump files on Linux. It can produce much smaller > + core dump files by making use of sparse files, compression, and > + allowing the user to configure what parts of the process memory image > + should be dumped. > diff --git a/rules/minicoredumper.make b/rules/minicoredumper.make > new file mode 100644 > index 000000000000..b63be8c2ba19 > --- /dev/null > +++ b/rules/minicoredumper.make > @@ -0,0 +1,82 @@ > +# -*-makefile-*- > +# > +# Copyright (C) 2018 by Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de> > +# > +# See CREDITS for details about who has contributed to this project. > +# > +# For further information about the PTXdist project and license conditions > +# see the README file. > +# > + > +# > +# We provide this package > +# > +PACKAGES-$(PTXCONF_MINICOREDUMPER) += minicoredumper > + > +# > +# Paths and names > +# > +MINICOREDUMPER_VERSION := 2.0.1 > +MINICOREDUMPER_MD5 := 813b864e0c6a833d14bab244723de6a4 > +MINICOREDUMPER := minicoredumper-$(MINICOREDUMPER_VERSION) > +MINICOREDUMPER_SUFFIX := tar.xz > +MINICOREDUMPER_URL := https://linutronix.de/minicoredumper/files/$(MINICOREDUMPER).$(MINICOREDUMPER_SUFFIX) > +MINICOREDUMPER_SOURCE := $(SRCDIR)/$(MINICOREDUMPER).$(MINICOREDUMPER_SUFFIX) > +MINICOREDUMPER_DIR := $(BUILDDIR)/$(MINICOREDUMPER) > +MINICOREDUMPER_LICENSE := BSD LGPG-2.1 Typo in LGPG-2.1, and also add an operator (AND, OR) between them, see https://spdx.org/spdx-specification-21-web-version#h.jxpfx0ykyb60 > +MINICOREDUMPER_LICENSE_FILES := file://COPYING;md5=71827c617ec7b45a0dd23658347cc1e9 > + > +# ---------------------------------------------------------------------------- > +# Extract > +# ---------------------------------------------------------------------------- > + > +$(STATEDIR)/minicoredumper.extract: $(STATEDIR)/autogen-tools Interesting, I didn't know this one yet. Apparently it generates a configure script when only a configure.ac is present? > + > +$(STATEDIR)/minicoredumper.extract: > + @$(call targetinfo) > + @$(call clean, $(MINICOREDUMPER_DIR)) > + @$(call extract, MINICOREDUMPER) > + @$(call patchin, MINICOREDUMPER) > + @$(call touch) > + > +# ---------------------------------------------------------------------------- > +# Prepare > +# ---------------------------------------------------------------------------- > + > +MINICOREDUMPER_CONF_TOOL := autoconf > +MINICOREDUMPER_CONF_OPT := \ > + $(CROSS_AUTOCONF_USR) \ > + --disable-silent-rules \ > + --without-coreinject \ > + --with-minicoredumper \ > + --without-minicoredumper_regd \ > + --without-minicoredumper_trigger \ > + --without-libminicoredumper \ > + --without-minicoredumper_demo \ > + --without-werror \ > + > +# ---------------------------------------------------------------------------- > +# Target-Install > +# ---------------------------------------------------------------------------- > + > +$(STATEDIR)/minicoredumper.targetinstall: > + @$(call targetinfo) > + > + @$(call install_init, minicoredumper) > + @$(call install_fixup, minicoredumper, PRIORITY, optional) > + @$(call install_fixup, minicoredumper, SECTION, base) > + @$(call install_fixup, minicoredumper, AUTHOR, "Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>") > + @$(call install_fixup, minicoredumper, DESCRIPTION, missing) > + > + @$(call install_copy, minicoredumper, 0, 0, 0755, -, /usr/sbin/minicoredumper) > + > + @$(call install_alternative_tree, minicoredumper, 0, 0, /etc/minicoredumper) > + > + @$(call install_copy, minicoredumper, 0, 0, 0755, /var/crash) > + @$(call install_copy, minicoredumper, 0, 0, 0755, /var/crash/minicoredumper) > + > + @$(call install_finish, minicoredumper) > + > + @$(call touch) > + > +# vim: syntax=make Otherwise LGTM. - Roland -- Roland Hieber | r.hieber@pengutronix.de | Pengutronix e.K. | https://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [ptxdist] [PATCH] minicoredumper: New package 2018-08-14 9:57 ` Roland Hieber @ 2018-08-14 10:14 ` Roland Hieber 2018-08-14 11:02 ` Uwe Kleine-König 0 siblings, 1 reply; 10+ messages in thread From: Roland Hieber @ 2018-08-14 10:14 UTC (permalink / raw) To: Uwe Kleine-König; +Cc: ptxdist On Tue, Aug 14, 2018 at 11:57:44AM +0200, Roland Hieber wrote: > On Mon, Aug 13, 2018 at 04:57:48PM +0200, Uwe Kleine-König wrote: [...] > > diff --git a/rules/minicoredumper.make b/rules/minicoredumper.make > > new file mode 100644 > > index 000000000000..b63be8c2ba19 > > --- /dev/null > > +++ b/rules/minicoredumper.make > > @@ -0,0 +1,82 @@ > > +# -*-makefile-*- > > +# > > +# Copyright (C) 2018 by Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de> > > +# > > +# See CREDITS for details about who has contributed to this project. > > +# > > +# For further information about the PTXdist project and license conditions > > +# see the README file. > > +# > > + > > +# > > +# We provide this package > > +# > > +PACKAGES-$(PTXCONF_MINICOREDUMPER) += minicoredumper > > + > > +# > > +# Paths and names > > +# > > +MINICOREDUMPER_VERSION := 2.0.1 > > +MINICOREDUMPER_MD5 := 813b864e0c6a833d14bab244723de6a4 > > +MINICOREDUMPER := minicoredumper-$(MINICOREDUMPER_VERSION) > > +MINICOREDUMPER_SUFFIX := tar.xz > > +MINICOREDUMPER_URL := https://linutronix.de/minicoredumper/files/$(MINICOREDUMPER).$(MINICOREDUMPER_SUFFIX) > > +MINICOREDUMPER_SOURCE := $(SRCDIR)/$(MINICOREDUMPER).$(MINICOREDUMPER_SUFFIX) > > +MINICOREDUMPER_DIR := $(BUILDDIR)/$(MINICOREDUMPER) > > +MINICOREDUMPER_LICENSE := BSD LGPG-2.1 > > +MINICOREDUMPER_LICENSE_FILES := file://COPYING;md5=71827c617ec7b45a0dd23658347cc1e9 > > + > > +# ---------------------------------------------------------------------------- > > +# Extract > > +# ---------------------------------------------------------------------------- > > + > > +$(STATEDIR)/minicoredumper.extract: $(STATEDIR)/autogen-tools > > Interesting, I didn't know this one yet. Apparently it generates a > configure script when only a configure.ac is present? Hm. On second read of ptxdist/rules/pre/autogen.make, this should be a no-op as long as no patches/$(MINICOREDUMPER)/autogen.sh is present, which is the case here. Does it work for you as intended? - Roland > > + > > +$(STATEDIR)/minicoredumper.extract: > > + @$(call targetinfo) > > + @$(call clean, $(MINICOREDUMPER_DIR)) > > + @$(call extract, MINICOREDUMPER) > > + @$(call patchin, MINICOREDUMPER) > > + @$(call touch) > > + > > +# ---------------------------------------------------------------------------- > > +# Prepare > > +# ---------------------------------------------------------------------------- > > + [...] -- Roland Hieber | r.hieber@pengutronix.de | Pengutronix e.K. | https://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [ptxdist] [PATCH] minicoredumper: New package 2018-08-14 10:14 ` Roland Hieber @ 2018-08-14 11:02 ` Uwe Kleine-König 2018-08-14 12:38 ` Denis OSTERLAND 0 siblings, 1 reply; 10+ messages in thread From: Uwe Kleine-König @ 2018-08-14 11:02 UTC (permalink / raw) To: Roland Hieber; +Cc: ptxdist Hello Roland, On Tue, Aug 14, 2018 at 12:14:20PM +0200, Roland Hieber wrote: > On Tue, Aug 14, 2018 at 11:57:44AM +0200, Roland Hieber wrote: > > On Mon, Aug 13, 2018 at 04:57:48PM +0200, Uwe Kleine-König wrote: > > > +$(STATEDIR)/minicoredumper.extract: $(STATEDIR)/autogen-tools > > > > Interesting, I didn't know this one yet. Apparently it generates a > > configure script when only a configure.ac is present? > > Hm. On second read of ptxdist/rules/pre/autogen.make, this should be a > no-op as long as no patches/$(MINICOREDUMPER)/autogen.sh is present, > which is the case here. Does it work for you as intended? Yes, works as intended (i.e. the package builds fine) :-) I used that not because I consider it sensible but because that's what ptxdist newpackage did for me. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [ptxdist] [PATCH] minicoredumper: New package 2018-08-14 11:02 ` Uwe Kleine-König @ 2018-08-14 12:38 ` Denis OSTERLAND 2018-08-15 10:03 ` Roland Hieber 0 siblings, 1 reply; 10+ messages in thread From: Denis OSTERLAND @ 2018-08-14 12:38 UTC (permalink / raw) To: ptxdist Am Dienstag, den 14.08.2018, 13:02 +0200 schrieb Uwe Kleine-König: > Hello Roland, > > On Tue, Aug 14, 2018 at 12:14:20PM +0200, Roland Hieber wrote: > > > > On Tue, Aug 14, 2018 at 11:57:44AM +0200, Roland Hieber wrote: > > > > > > On Mon, Aug 13, 2018 at 04:57:48PM +0200, Uwe Kleine-König wrote: > > > > > > > > +$(STATEDIR)/minicoredumper.extract: $(STATEDIR)/autogen-tools > > > Interesting, I didn't know this one yet. Apparently it generates a > > > configure script when only a configure.ac is present? > > Hm. On second read of ptxdist/rules/pre/autogen.make, this should be a > > no-op as long as no patches/$(MINICOREDUMPER)/autogen.sh is present, > > which is the case here. Does it work for you as intended? > Yes, works as intended (i.e. the package builds fine) :-) > > I used that not because I consider it sensible but because that's what > ptxdist newpackage did for me. > > Best regards > Uwe > I would expect a link in patch folder instead of prepare section: patches/minicoredumper-2.0.1/autogen.sh -> ../autogen.sh Regards Denis Diehl Connectivity Solutions GmbH Geschäftsführung: Horst Leonberger Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht Nürnberg: HRB 32315 ___________________________________________________________________________________________________ Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen. Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht. Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt. The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited. _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [ptxdist] [PATCH] minicoredumper: New package 2018-08-14 12:38 ` Denis OSTERLAND @ 2018-08-15 10:03 ` Roland Hieber 0 siblings, 0 replies; 10+ messages in thread From: Roland Hieber @ 2018-08-15 10:03 UTC (permalink / raw) To: ptxdist On Tue, Aug 14, 2018 at 12:38:38PM +0000, Denis OSTERLAND wrote: > Am Dienstag, den 14.08.2018, 13:02 +0200 schrieb Uwe Kleine-König: > > On Tue, Aug 14, 2018 at 12:14:20PM +0200, Roland Hieber wrote: > > > On Tue, Aug 14, 2018 at 11:57:44AM +0200, Roland Hieber wrote: > > > > On Mon, Aug 13, 2018 at 04:57:48PM +0200, Uwe Kleine-König wrote: > > > > > +$(STATEDIR)/minicoredumper.extract: $(STATEDIR)/autogen-tools > > > > Interesting, I didn't know this one yet. Apparently it generates a > > > > configure script when only a configure.ac is present? > > > Hm. On second read of ptxdist/rules/pre/autogen.make, this should be a > > > no-op as long as no patches/$(MINICOREDUMPER)/autogen.sh is present, > > > which is the case here. Does it work for you as intended? > > Yes, works as intended (i.e. the package builds fine) :-) > > > > I used that not because I consider it sensible but because that's what > > ptxdist newpackage did for me. > > > > Best regards > > Uwe > > I would expect a link in patch folder instead of prepare section: > patches/minicoredumper-2.0.1/autogen.sh -> ../autogen.sh Yes, that is the usual way to do it, the extract.post stage will find patches/minicoredumper-2.0.1/autogen.sh and execute it in the package directory to generate configure from configure.ac. In this case, configure was already present in the tarball, so nothing of these solutions were needed. - Roland -- Roland Hieber | r.hieber@pengutronix.de | Pengutronix e.K. | https://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 10+ messages in thread
* [ptxdist] [PATCH v2] minicoredumper: New package 2018-08-13 14:57 [ptxdist] [PATCH] minicoredumper: New package Uwe Kleine-König 2018-08-14 9:57 ` Roland Hieber @ 2018-08-14 16:15 ` Uwe Kleine-König 2018-08-15 9:59 ` Roland Hieber ` (2 more replies) 1 sibling, 3 replies; 10+ messages in thread From: Uwe Kleine-König @ 2018-08-14 16:15 UTC (permalink / raw) To: ptxdist Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- Changes since (implicit) v1, sent with Message-Id: 20180813145748.21019-1-u.kleine-koenig@pengutronix.de: - s/LGPG-2.1/LGPG-2.1/ - Add "AND" to MINICOREDUMPER_LICENSE - Mention missing automatic registration as coredump helper in .in instead of the commit log - drop complete extract stage. The ptxdist defaults are fine enough. Most of this was noticed by Roland, thanks Best regards Uwe rules/minicoredumper.in | 21 ++++++++++++ rules/minicoredumper.make | 69 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 90 insertions(+) create mode 100644 rules/minicoredumper.in create mode 100644 rules/minicoredumper.make diff --git a/rules/minicoredumper.in b/rules/minicoredumper.in new file mode 100644 index 000000000000..969be8210c88 --- /dev/null +++ b/rules/minicoredumper.in @@ -0,0 +1,21 @@ +## SECTION=shell_and_console + +config MINICOREDUMPER + bool + prompt "minicoredumper" + select LIBELF + select JSON_C + help + The minicoredumper project provides a program that handles the + creation of core dump files on Linux. It can produce much smaller + core dump files by making use of sparse files, compression, and + allowing the user to configure what parts of the process memory image + should be dumped. + + Note that there are currently no mechnisms integrated to + automatically register minicoredumper as kernel coredump helper. So + you might want to do + + echo '|/usr/sbin/minicoredumper %P %u %g %s %t %h %e' > /proc/sys/kernel/core_pattern + + by hand to actually make use of it. diff --git a/rules/minicoredumper.make b/rules/minicoredumper.make new file mode 100644 index 000000000000..948068b21c89 --- /dev/null +++ b/rules/minicoredumper.make @@ -0,0 +1,69 @@ +# -*-makefile-*- +# +# Copyright (C) 2018 by Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de> +# +# See CREDITS for details about who has contributed to this project. +# +# For further information about the PTXdist project and license conditions +# see the README file. +# + +# +# We provide this package +# +PACKAGES-$(PTXCONF_MINICOREDUMPER) += minicoredumper + +# +# Paths and names +# +MINICOREDUMPER_VERSION := 2.0.1 +MINICOREDUMPER_MD5 := 813b864e0c6a833d14bab244723de6a4 +MINICOREDUMPER := minicoredumper-$(MINICOREDUMPER_VERSION) +MINICOREDUMPER_SUFFIX := tar.xz +MINICOREDUMPER_URL := https://linutronix.de/minicoredumper/files/$(MINICOREDUMPER).$(MINICOREDUMPER_SUFFIX) +MINICOREDUMPER_SOURCE := $(SRCDIR)/$(MINICOREDUMPER).$(MINICOREDUMPER_SUFFIX) +MINICOREDUMPER_DIR := $(BUILDDIR)/$(MINICOREDUMPER) +MINICOREDUMPER_LICENSE := BSD AND LGPL-2.1 +MINICOREDUMPER_LICENSE_FILES := file://COPYING;md5=71827c617ec7b45a0dd23658347cc1e9 + +# ---------------------------------------------------------------------------- +# Prepare +# ---------------------------------------------------------------------------- + +MINICOREDUMPER_CONF_TOOL := autoconf +MINICOREDUMPER_CONF_OPT := \ + $(CROSS_AUTOCONF_USR) \ + --disable-silent-rules \ + --without-coreinject \ + --with-minicoredumper \ + --without-minicoredumper_regd \ + --without-minicoredumper_trigger \ + --without-libminicoredumper \ + --without-minicoredumper_demo \ + --without-werror \ + +# ---------------------------------------------------------------------------- +# Target-Install +# ---------------------------------------------------------------------------- + +$(STATEDIR)/minicoredumper.targetinstall: + @$(call targetinfo) + + @$(call install_init, minicoredumper) + @$(call install_fixup, minicoredumper, PRIORITY, optional) + @$(call install_fixup, minicoredumper, SECTION, base) + @$(call install_fixup, minicoredumper, AUTHOR, "Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>") + @$(call install_fixup, minicoredumper, DESCRIPTION, missing) + + @$(call install_copy, minicoredumper, 0, 0, 0755, -, /usr/sbin/minicoredumper) + + @$(call install_alternative_tree, minicoredumper, 0, 0, /etc/minicoredumper) + + @$(call install_copy, minicoredumper, 0, 0, 0755, /var/crash) + @$(call install_copy, minicoredumper, 0, 0, 0755, /var/crash/minicoredumper) + + @$(call install_finish, minicoredumper) + + @$(call touch) + +# vim: syntax=make -- 2.18.0 _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [ptxdist] [PATCH v2] minicoredumper: New package 2018-08-14 16:15 ` [ptxdist] [PATCH v2] " Uwe Kleine-König @ 2018-08-15 9:59 ` Roland Hieber 2018-08-29 7:31 ` Alexander Dahl 2018-08-31 7:41 ` Michael Olbrich 2 siblings, 0 replies; 10+ messages in thread From: Roland Hieber @ 2018-08-15 9:59 UTC (permalink / raw) To: ptxdist On Tue, Aug 14, 2018 at 06:15:39PM +0200, Uwe Kleine-König wrote: > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > Changes since (implicit) v1, sent with Message-Id: > 20180813145748.21019-1-u.kleine-koenig@pengutronix.de: > > - s/LGPG-2.1/LGPG-2.1/ I see you did the right thing in the patch below :-) Tested-by: Roland Hieber <r.hieber@pengutronix.de> Acked-by: Roland Hieber <r.hieber@pengutronix.de> > - Add "AND" to MINICOREDUMPER_LICENSE > - Mention missing automatic registration as coredump helper in .in > instead of the commit log > - drop complete extract stage. The ptxdist defaults are fine enough. > > Most of this was noticed by Roland, thanks > > Best regards > Uwe > > rules/minicoredumper.in | 21 ++++++++++++ > rules/minicoredumper.make | 69 +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 90 insertions(+) > create mode 100644 rules/minicoredumper.in > create mode 100644 rules/minicoredumper.make > > diff --git a/rules/minicoredumper.in b/rules/minicoredumper.in > new file mode 100644 > index 000000000000..969be8210c88 > --- /dev/null > +++ b/rules/minicoredumper.in > @@ -0,0 +1,21 @@ > +## SECTION=shell_and_console > + > +config MINICOREDUMPER > + bool > + prompt "minicoredumper" > + select LIBELF > + select JSON_C > + help > + The minicoredumper project provides a program that handles the > + creation of core dump files on Linux. It can produce much smaller > + core dump files by making use of sparse files, compression, and > + allowing the user to configure what parts of the process memory image > + should be dumped. > + > + Note that there are currently no mechnisms integrated to > + automatically register minicoredumper as kernel coredump helper. So > + you might want to do > + > + echo '|/usr/sbin/minicoredumper %P %u %g %s %t %h %e' > /proc/sys/kernel/core_pattern > + > + by hand to actually make use of it. > diff --git a/rules/minicoredumper.make b/rules/minicoredumper.make > new file mode 100644 > index 000000000000..948068b21c89 > --- /dev/null > +++ b/rules/minicoredumper.make > @@ -0,0 +1,69 @@ > +# -*-makefile-*- > +# > +# Copyright (C) 2018 by Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de> > +# > +# See CREDITS for details about who has contributed to this project. > +# > +# For further information about the PTXdist project and license conditions > +# see the README file. > +# > + > +# > +# We provide this package > +# > +PACKAGES-$(PTXCONF_MINICOREDUMPER) += minicoredumper > + > +# > +# Paths and names > +# > +MINICOREDUMPER_VERSION := 2.0.1 > +MINICOREDUMPER_MD5 := 813b864e0c6a833d14bab244723de6a4 > +MINICOREDUMPER := minicoredumper-$(MINICOREDUMPER_VERSION) > +MINICOREDUMPER_SUFFIX := tar.xz > +MINICOREDUMPER_URL := https://linutronix.de/minicoredumper/files/$(MINICOREDUMPER).$(MINICOREDUMPER_SUFFIX) > +MINICOREDUMPER_SOURCE := $(SRCDIR)/$(MINICOREDUMPER).$(MINICOREDUMPER_SUFFIX) > +MINICOREDUMPER_DIR := $(BUILDDIR)/$(MINICOREDUMPER) > +MINICOREDUMPER_LICENSE := BSD AND LGPL-2.1 > +MINICOREDUMPER_LICENSE_FILES := file://COPYING;md5=71827c617ec7b45a0dd23658347cc1e9 > + > +# ---------------------------------------------------------------------------- > +# Prepare > +# ---------------------------------------------------------------------------- > + > +MINICOREDUMPER_CONF_TOOL := autoconf > +MINICOREDUMPER_CONF_OPT := \ > + $(CROSS_AUTOCONF_USR) \ > + --disable-silent-rules \ > + --without-coreinject \ > + --with-minicoredumper \ > + --without-minicoredumper_regd \ > + --without-minicoredumper_trigger \ > + --without-libminicoredumper \ > + --without-minicoredumper_demo \ > + --without-werror \ > + > +# ---------------------------------------------------------------------------- > +# Target-Install > +# ---------------------------------------------------------------------------- > + > +$(STATEDIR)/minicoredumper.targetinstall: > + @$(call targetinfo) > + > + @$(call install_init, minicoredumper) > + @$(call install_fixup, minicoredumper, PRIORITY, optional) > + @$(call install_fixup, minicoredumper, SECTION, base) > + @$(call install_fixup, minicoredumper, AUTHOR, "Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>") > + @$(call install_fixup, minicoredumper, DESCRIPTION, missing) > + > + @$(call install_copy, minicoredumper, 0, 0, 0755, -, /usr/sbin/minicoredumper) > + > + @$(call install_alternative_tree, minicoredumper, 0, 0, /etc/minicoredumper) > + > + @$(call install_copy, minicoredumper, 0, 0, 0755, /var/crash) > + @$(call install_copy, minicoredumper, 0, 0, 0755, /var/crash/minicoredumper) > + > + @$(call install_finish, minicoredumper) > + > + @$(call touch) > + > +# vim: syntax=make > -- > 2.18.0 > > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de -- Roland Hieber | r.hieber@pengutronix.de | Pengutronix e.K. | https://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [ptxdist] [PATCH v2] minicoredumper: New package 2018-08-14 16:15 ` [ptxdist] [PATCH v2] " Uwe Kleine-König 2018-08-15 9:59 ` Roland Hieber @ 2018-08-29 7:31 ` Alexander Dahl 2018-08-31 7:41 ` Michael Olbrich 2 siblings, 0 replies; 10+ messages in thread From: Alexander Dahl @ 2018-08-29 7:31 UTC (permalink / raw) To: ptxdist; +Cc: Uwe Kleine-König Hello Uwe, found some minor issues, see below. Despite of that: Tested-by: Alexander Dahl <ada@thorsis.com> Greets Alex Am Dienstag, 14. August 2018, 18:15:39 CEST schrieb Uwe Kleine-König: > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > Changes since (implicit) v1, sent with Message-Id: > 20180813145748.21019-1-u.kleine-koenig@pengutronix.de: > > - s/LGPG-2.1/LGPG-2.1/ > - Add "AND" to MINICOREDUMPER_LICENSE > - Mention missing automatic registration as coredump helper in .in > instead of the commit log > - drop complete extract stage. The ptxdist defaults are fine enough. > > Most of this was noticed by Roland, thanks > > Best regards > Uwe > > rules/minicoredumper.in | 21 ++++++++++++ > rules/minicoredumper.make | 69 +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 90 insertions(+) > create mode 100644 rules/minicoredumper.in > create mode 100644 rules/minicoredumper.make > > diff --git a/rules/minicoredumper.in b/rules/minicoredumper.in > new file mode 100644 > index 000000000000..969be8210c88 > --- /dev/null > +++ b/rules/minicoredumper.in > @@ -0,0 +1,21 @@ > +## SECTION=shell_and_console > + > +config MINICOREDUMPER > + bool Why not tristate? > + prompt "minicoredumper" > + select LIBELF > + select JSON_C > + help > + The minicoredumper project provides a program that handles the > + creation of core dump files on Linux. It can produce much smaller > + core dump files by making use of sparse files, compression, and > + allowing the user to configure what parts of the process memory image > + should be dumped. > + > + Note that there are currently no mechnisms integrated to > + automatically register minicoredumper as kernel coredump helper. So > + you might want to do s/mechnisms/mechanisms/ > + > + echo '|/usr/sbin/minicoredumper %P %u %g %s %t %h %e' > > /proc/sys/kernel/core_pattern + > + by hand to actually make use of it. > diff --git a/rules/minicoredumper.make b/rules/minicoredumper.make > new file mode 100644 > index 000000000000..948068b21c89 > --- /dev/null > +++ b/rules/minicoredumper.make > @@ -0,0 +1,69 @@ > +# -*-makefile-*- > +# > +# Copyright (C) 2018 by Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de> > +# > +# See CREDITS for details about who has contributed to this project. > +# > +# For further information about the PTXdist project and license conditions > +# see the README file. > +# > + > +# > +# We provide this package > +# > +PACKAGES-$(PTXCONF_MINICOREDUMPER) += minicoredumper > + > +# > +# Paths and names > +# > +MINICOREDUMPER_VERSION := 2.0.1 > +MINICOREDUMPER_MD5 := 813b864e0c6a833d14bab244723de6a4 > +MINICOREDUMPER := minicoredumper-$(MINICOREDUMPER_VERSION) > +MINICOREDUMPER_SUFFIX := tar.xz > +MINICOREDUMPER_URL := > https://linutronix.de/minicoredumper/files/$(MINICOREDUMPER).$(MINICOREDUMP > ER_SUFFIX) +MINICOREDUMPER_SOURCE := > $(SRCDIR)/$(MINICOREDUMPER).$(MINICOREDUMPER_SUFFIX) +MINICOREDUMPER_DIR := > $(BUILDDIR)/$(MINICOREDUMPER) > +MINICOREDUMPER_LICENSE := BSD AND LGPL-2.1 > +MINICOREDUMPER_LICENSE_FILES := > file://COPYING;md5=71827c617ec7b45a0dd23658347cc1e9 + > +# > --------------------------------------------------------------------------- > - +# Prepare > +# > --------------------------------------------------------------------------- > - + > +MINICOREDUMPER_CONF_TOOL := autoconf > +MINICOREDUMPER_CONF_OPT := \ > + $(CROSS_AUTOCONF_USR) \ > + --disable-silent-rules \ > + --without-coreinject \ > + --with-minicoredumper \ > + --without-minicoredumper_regd \ > + --without-minicoredumper_trigger \ > + --without-libminicoredumper \ > + --without-minicoredumper_demo \ > + --without-werror \ > + > +# > --------------------------------------------------------------------------- > - +# Target-Install > +# > --------------------------------------------------------------------------- > - + > +$(STATEDIR)/minicoredumper.targetinstall: > + @$(call targetinfo) > + > + @$(call install_init, minicoredumper) > + @$(call install_fixup, minicoredumper, PRIORITY, optional) > + @$(call install_fixup, minicoredumper, SECTION, base) > + @$(call install_fixup, minicoredumper, AUTHOR, "Uwe Kleine-Koenig > <u.kleine-koenig@pengutronix.de>") + @$(call install_fixup, minicoredumper, > DESCRIPTION, missing) > + > + @$(call install_copy, minicoredumper, 0, 0, 0755, -, > /usr/sbin/minicoredumper) + > + @$(call install_alternative_tree, minicoredumper, 0, 0, > /etc/minicoredumper) + > + @$(call install_copy, minicoredumper, 0, 0, 0755, /var/crash) > + @$(call install_copy, minicoredumper, 0, 0, 0755, > /var/crash/minicoredumper) + > + @$(call install_finish, minicoredumper) > + > + @$(call touch) > + > +# vim: syntax=make _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [ptxdist] [PATCH v2] minicoredumper: New package 2018-08-14 16:15 ` [ptxdist] [PATCH v2] " Uwe Kleine-König 2018-08-15 9:59 ` Roland Hieber 2018-08-29 7:31 ` Alexander Dahl @ 2018-08-31 7:41 ` Michael Olbrich 2 siblings, 0 replies; 10+ messages in thread From: Michael Olbrich @ 2018-08-31 7:41 UTC (permalink / raw) To: ptxdist On Tue, Aug 14, 2018 at 06:15:39PM +0200, Uwe Kleine-König wrote: > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > Changes since (implicit) v1, sent with Message-Id: > 20180813145748.21019-1-u.kleine-koenig@pengutronix.de: > > - s/LGPG-2.1/LGPG-2.1/ > - Add "AND" to MINICOREDUMPER_LICENSE > - Mention missing automatic registration as coredump helper in .in > instead of the commit log > - drop complete extract stage. The ptxdist defaults are fine enough. > > Most of this was noticed by Roland, thanks > > Best regards > Uwe > > rules/minicoredumper.in | 21 ++++++++++++ > rules/minicoredumper.make | 69 +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 90 insertions(+) > create mode 100644 rules/minicoredumper.in > create mode 100644 rules/minicoredumper.make > > diff --git a/rules/minicoredumper.in b/rules/minicoredumper.in > new file mode 100644 > index 000000000000..969be8210c88 > --- /dev/null > +++ b/rules/minicoredumper.in > @@ -0,0 +1,21 @@ > +## SECTION=shell_and_console > + > +config MINICOREDUMPER > + bool > + prompt "minicoredumper" > + select LIBELF > + select JSON_C > + help > + The minicoredumper project provides a program that handles the > + creation of core dump files on Linux. It can produce much smaller > + core dump files by making use of sparse files, compression, and > + allowing the user to configure what parts of the process memory image > + should be dumped. > + > + Note that there are currently no mechnisms integrated to > + automatically register minicoredumper as kernel coredump helper. So > + you might want to do > + > + echo '|/usr/sbin/minicoredumper %P %u %g %s %t %h %e' > /proc/sys/kernel/core_pattern > + > + by hand to actually make use of it. > diff --git a/rules/minicoredumper.make b/rules/minicoredumper.make > new file mode 100644 > index 000000000000..948068b21c89 > --- /dev/null > +++ b/rules/minicoredumper.make > @@ -0,0 +1,69 @@ > +# -*-makefile-*- > +# > +# Copyright (C) 2018 by Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de> > +# > +# See CREDITS for details about who has contributed to this project. > +# > +# For further information about the PTXdist project and license conditions > +# see the README file. > +# > + > +# > +# We provide this package > +# > +PACKAGES-$(PTXCONF_MINICOREDUMPER) += minicoredumper > + > +# > +# Paths and names > +# > +MINICOREDUMPER_VERSION := 2.0.1 > +MINICOREDUMPER_MD5 := 813b864e0c6a833d14bab244723de6a4 > +MINICOREDUMPER := minicoredumper-$(MINICOREDUMPER_VERSION) > +MINICOREDUMPER_SUFFIX := tar.xz > +MINICOREDUMPER_URL := https://linutronix.de/minicoredumper/files/$(MINICOREDUMPER).$(MINICOREDUMPER_SUFFIX) > +MINICOREDUMPER_SOURCE := $(SRCDIR)/$(MINICOREDUMPER).$(MINICOREDUMPER_SUFFIX) > +MINICOREDUMPER_DIR := $(BUILDDIR)/$(MINICOREDUMPER) > +MINICOREDUMPER_LICENSE := BSD AND LGPL-2.1 > +MINICOREDUMPER_LICENSE_FILES := file://COPYING;md5=71827c617ec7b45a0dd23658347cc1e9 > + > +# ---------------------------------------------------------------------------- > +# Prepare > +# ---------------------------------------------------------------------------- > + > +MINICOREDUMPER_CONF_TOOL := autoconf > +MINICOREDUMPER_CONF_OPT := \ > + $(CROSS_AUTOCONF_USR) \ > + --disable-silent-rules \ > + --without-coreinject \ > + --with-minicoredumper \ > + --without-minicoredumper_regd \ > + --without-minicoredumper_trigger \ > + --without-libminicoredumper \ > + --without-minicoredumper_demo \ > + --without-werror \ > + > +# ---------------------------------------------------------------------------- > +# Target-Install > +# ---------------------------------------------------------------------------- > + > +$(STATEDIR)/minicoredumper.targetinstall: > + @$(call targetinfo) > + > + @$(call install_init, minicoredumper) > + @$(call install_fixup, minicoredumper, PRIORITY, optional) > + @$(call install_fixup, minicoredumper, SECTION, base) > + @$(call install_fixup, minicoredumper, AUTHOR, "Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>") > + @$(call install_fixup, minicoredumper, DESCRIPTION, missing) > + > + @$(call install_copy, minicoredumper, 0, 0, 0755, -, /usr/sbin/minicoredumper) > + > + @$(call install_alternative_tree, minicoredumper, 0, 0, /etc/minicoredumper) > + > + @$(call install_copy, minicoredumper, 0, 0, 0755, /var/crash) No need for this. install_copy creates all directory levels. Michael > + @$(call install_copy, minicoredumper, 0, 0, 0755, /var/crash/minicoredumper) > + > + @$(call install_finish, minicoredumper) > + > + @$(call touch) > + > +# vim: syntax=make > -- > 2.18.0 > > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-08-31 7:41 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-08-13 14:57 [ptxdist] [PATCH] minicoredumper: New package Uwe Kleine-König 2018-08-14 9:57 ` Roland Hieber 2018-08-14 10:14 ` Roland Hieber 2018-08-14 11:02 ` Uwe Kleine-König 2018-08-14 12:38 ` Denis OSTERLAND 2018-08-15 10:03 ` Roland Hieber 2018-08-14 16:15 ` [ptxdist] [PATCH v2] " Uwe Kleine-König 2018-08-15 9:59 ` Roland Hieber 2018-08-29 7:31 ` Alexander Dahl 2018-08-31 7:41 ` Michael Olbrich
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox