Re: [ptxdist] [PATCH] minicoredumper: New package

[Roland Hieber <r.hieber@pengutronix.de>]

On Mon, Aug 13, 2018 at 04:57:48PM +0200, Uwe Kleine-König wrote:
> For now this only installs the binary but doesn't register it as
> coredump-helper yet. So you have to do
> 
>     echo '|/usr/sbin/minicoredumper %P %u %g %s %t %h %e' > /proc/sys/kernel/core_pattern
> 
> by hand to actually make use of it.

This should be added to the kconfig help text where the users can see it.

> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  rules/minicoredumper.in   | 13 +++++++
>  rules/minicoredumper.make | 82 +++++++++++++++++++++++++++++++++++++++
>  2 files changed, 95 insertions(+)
>  create mode 100644 rules/minicoredumper.in
>  create mode 100644 rules/minicoredumper.make
> 
> diff --git a/rules/minicoredumper.in b/rules/minicoredumper.in
> new file mode 100644
> index 000000000000..fc9984785719
> --- /dev/null
> +++ b/rules/minicoredumper.in
> @@ -0,0 +1,13 @@
> +## SECTION=shell_and_console
> +
> +config MINICOREDUMPER
> +	bool
> +	prompt "minicoredumper"
> +	select LIBELF
> +	select JSON_C
> +	help
> +	  The minicoredumper project provides a program that handles the
> +	  creation of core dump files on Linux. It can produce much smaller
> +	  core dump files by making use of sparse files, compression, and
> +	  allowing the user to configure what parts of the process memory image
> +	  should be dumped.
> diff --git a/rules/minicoredumper.make b/rules/minicoredumper.make
> new file mode 100644
> index 000000000000..b63be8c2ba19
> --- /dev/null
> +++ b/rules/minicoredumper.make
> @@ -0,0 +1,82 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2018 by Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_MINICOREDUMPER) += minicoredumper
> +
> +#
> +# Paths and names
> +#
> +MINICOREDUMPER_VERSION	:= 2.0.1
> +MINICOREDUMPER_MD5	:= 813b864e0c6a833d14bab244723de6a4
> +MINICOREDUMPER		:= minicoredumper-$(MINICOREDUMPER_VERSION)
> +MINICOREDUMPER_SUFFIX	:= tar.xz
> +MINICOREDUMPER_URL	:= https://linutronix.de/minicoredumper/files/$(MINICOREDUMPER).$(MINICOREDUMPER_SUFFIX)
> +MINICOREDUMPER_SOURCE	:= $(SRCDIR)/$(MINICOREDUMPER).$(MINICOREDUMPER_SUFFIX)
> +MINICOREDUMPER_DIR	:= $(BUILDDIR)/$(MINICOREDUMPER)
> +MINICOREDUMPER_LICENSE	:= BSD LGPG-2.1

Typo in LGPG-2.1, and also add an operator (AND, OR) between them, see
https://spdx.org/spdx-specification-21-web-version#h.jxpfx0ykyb60

> +MINICOREDUMPER_LICENSE_FILES := file://COPYING;md5=71827c617ec7b45a0dd23658347cc1e9
> +
> +# ----------------------------------------------------------------------------
> +# Extract
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/minicoredumper.extract: $(STATEDIR)/autogen-tools

Interesting, I didn't know this one yet. Apparently it generates a
configure script when only a configure.ac is present?

> +
> +$(STATEDIR)/minicoredumper.extract:
> +	@$(call targetinfo)
> +	@$(call clean, $(MINICOREDUMPER_DIR))
> +	@$(call extract, MINICOREDUMPER)
> +	@$(call patchin, MINICOREDUMPER)
> +	@$(call touch)
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +MINICOREDUMPER_CONF_TOOL := autoconf
> +MINICOREDUMPER_CONF_OPT := \
> +	$(CROSS_AUTOCONF_USR) \
> +	--disable-silent-rules \
> +	--without-coreinject \
> +	--with-minicoredumper \
> +	--without-minicoredumper_regd \
> +	--without-minicoredumper_trigger \
> +	--without-libminicoredumper \
> +	--without-minicoredumper_demo \
> +	--without-werror \
> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/minicoredumper.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, minicoredumper)
> +	@$(call install_fixup, minicoredumper, PRIORITY, optional)
> +	@$(call install_fixup, minicoredumper, SECTION, base)
> +	@$(call install_fixup, minicoredumper, AUTHOR, "Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>")
> +	@$(call install_fixup, minicoredumper, DESCRIPTION, missing)
> +
> +	@$(call install_copy, minicoredumper, 0, 0, 0755, -, /usr/sbin/minicoredumper)
> +
> +	@$(call install_alternative_tree, minicoredumper, 0, 0, /etc/minicoredumper)
> +
> +	@$(call install_copy, minicoredumper, 0, 0, 0755, /var/crash)
> +	@$(call install_copy, minicoredumper, 0, 0, 0755, /var/crash/minicoredumper)
> +
> +	@$(call install_finish, minicoredumper)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make

Otherwise LGTM.

 - Roland

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de