Re: [ptxdist] [PATCH 23/23] xorg-fonts: make all xorg-font-ttf packages tristate

[Juergen Borleis <jbe@pengutronix.de>]

Hi Florian,

On Wednesday 01 August 2018 20:32:00 Florian Bäuerle wrote:
> [...]
>
> diff --git a/rules/graphics_and_multimedia.in
> b/rules/graphics_and_multimedia.in index 54e53ad7a..f96a381e3 100644
> --- a/rules/graphics_and_multimedia.in
> +++ b/rules/graphics_and_multimedia.in
> @@ -1,7 +1,7 @@
>  ## SECTION=graphics_and_multimedia
>
>  menuconfig MENU_XORG_FONTS
> -	bool
> +	tristate
>  	prompt "fonts                         "
>  	select XORG_LIB_XFONT_PCF_FONTS if XORG_SERVER
>  	default y if XORG_SERVER
> @@ -13,7 +13,7 @@ if MENU_XORG_FONTS
>
>  config XORG_FONTS
>  	depends on MENU_XORG_FONTS
> -	bool
> +	tristate
>  	select XORG_FONT_UTIL
>  	select XORG_FONT_ALIAS
>  	select HOST_XORG_APP_MKFONTDIR
> @@ -25,7 +25,7 @@ config XORG_FONTS
>  config XORG_FONTS_FC_CACHE
>  	default FONTCONFIG
>  	select FONTCONFIG_UTILS
> -	bool
> +	tristate

These changes conform to the subject.

>  config XORG_FONTS_QT4_LINKS
>  	depends on QT4_PLATFORM_EMBEDDED
> diff --git a/rules/xorg-font-adobe-100dpi.in
> b/rules/xorg-font-adobe-100dpi.in index e890885d6..66c0ec5c0 100644
> --- a/rules/xorg-font-adobe-100dpi.in
> +++ b/rules/xorg-font-adobe-100dpi.in
> @@ -1,7 +1,7 @@
>  ## SECTION=multimedia_xorg_font_100dpi
>
>  config XORG_FONT_ADOBE_100DPI
> -	tristate
> +	bool

This change doesn't conform to the subject.

BTW: Can you drop a few more words in the commit logs why you do this 
change? What is the intention?

Cheers,
Jürgen

-- 
Pengutronix e.K.                             | Juergen Borleis             |
Industrial Linux Solutions                   | http://www.pengutronix.de/  |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de