Re: [ptxdist] [PATCH 3/3] host-systemd: Fix rpath space problem

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Tue, Jul 31, 2018 at 10:27:24AM -0400, Jon Ringle wrote:
> On Tue, Jul 31, 2018 at 9:53 AM Michael Olbrich
> <m.olbrich@pengutronix.de> wrote:
> > On Tue, Jul 31, 2018 at 09:30:22AM -0400, Jon Ringle wrote:
> > > On Tue, Jul 31, 2018 at 3:49 AM Michael Olbrich
> > > <m.olbrich@pengutronix.de> wrote:
> > > > On Mon, Jul 30, 2018 at 12:58:09PM -0400, jon@ringle.org wrote:
> > > > > From: Jon Ringle <jringle@gridpoint.com>
> > > > >
> > > > > Make room for chrpath manipulation in host-systemd.install.pack
> > > > > The `-Drootprefix=/lib/..` adds sufficient space to avoids errors like:
> > > > >
> > > > > new rpath '${ORIGIN}/../../../lib' too large; maximum length 16
> > > > > ptxdist: error: Failed to adjust rpath for '/home/local/GRIDPOINT/jringle/git/rootfs/platform-ec1c/packages/host-systemd-239/usr/lib/systemd/systemd'
> > > > >
> > > > > Signed-off-by: Jon Ringle <jringle@gridpoint.com>
> > > > > ---
> > > > >  rules/host-systemd.make | 16 +---------------
> > > > >  1 file changed, 1 insertion(+), 15 deletions(-)
> > > > >
> > > > > diff --git a/rules/host-systemd.make b/rules/host-systemd.make
> > > > > index 7f97a75..341daeb 100644
> > > > > --- a/rules/host-systemd.make
> > > > > +++ b/rules/host-systemd.make
> > > > > @@ -23,6 +23,7 @@ HOST_PACKAGES-$(PTXCONF_HOST_SYSTEMD) += host-systemd
> > > > >  HOST_SYSTEMD_CONF_TOOL       := meson
> > > > >  HOST_SYSTEMD_CONF_OPT        := \
> > > > >       $(HOST_MESON_OPT) \
> > > > > +     -Drootprefix=/lib/.. \
> > > > >       -Dacl=false \
> > > > >       -Dadm-group=true \
> > > > >       -Dapparmor=false \
> > > > > @@ -120,19 +121,4 @@ HOST_SYSTEMD_CONF_OPT    := \
> > > > >       -Dxz=false \
> > > > >       -Dzlib=false
> > > > >
> > > > > -HOST_SYSTEMD_MAKE_OPT := systemd-hwdb
> > > > > -
> > > > > -# ----------------------------------------------------------------------------
> > > > > -# Install
> > > > > -# ----------------------------------------------------------------------------
> > > > > -
> > > > > -$(STATEDIR)/host-systemd.install:
> > > > > -     @$(call targetinfo)
> > > > > -     @rm -rf $(HOST_SYSTEMD_PKGDIR)
> > > > > -     @install -vD -m755 $(HOST_SYSTEMD_DIR)-build/systemd-hwdb \
> > > > > -             $(HOST_SYSTEMD_PKGDIR)/bin/systemd-hwdb
> > > > > -     @install -vD -m755 $(HOST_SYSTEMD_DIR)-build/src/shared/libsystemd-shared-$(HOST_SYSTEMD_VERSION).so \
> > > > > -             $(HOST_SYSTEMD_PKGDIR)/lib/libsystemd-shared-$(HOST_SYSTEMD_VERSION).so
> > > > > -     @$(call touch)
> > > > > -
> > > >
> > > >
> > > > Why do you remove this? Currently only systemd-hwdb is needed, so why build
> > > > anything else?
> > >
> > > I am creating a host package version of my own project so I can run
> > > the unit tests I have for it. This package requires the systemd
> > > headers and libs.
> >
> > I see. Please create a suboption for this. Building host-systemd has been
> > problematic in the past on older distributions, so I'd like to build as
> > little as possible.
> 
> I will create a new patch with an option, however, I'd bet that the
> `-Drootprefix=/lib/..` would fix the build problems with host-systemd
> you've had before.

No, the issues are undefined enum values, and stuff like that when building
with an old glibc and kernel headers. Usually in somwhere in the networking
code.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de