From: Ladislav Michl <ladis@linux-mips.org>
To: ptxdist@pengutronix.de
Cc: Jon Ringle <jringle@gridpoint.com>
Subject: Re: [ptxdist] [PATCH v2 2/2] host-systemd: Add option to install hwdb only (enabled by default)
Date: Wed, 1 Aug 2018 08:07:02 +0200 [thread overview]
Message-ID: <20180801060701.GA8956@lenoch> (raw)
In-Reply-To: <1533082954-12369-2-git-send-email-jon@ringle.org>
On Tue, Jul 31, 2018 at 08:22:34PM -0400, jon@ringle.org wrote:
> From: Jon Ringle <jringle@gridpoint.com>
It would be nice to put here some explanation which problem is
this change trying to solve.
> Signed-off-by: Jon Ringle <jringle@gridpoint.com>
> ---
> rules/host-systemd.in | 12 ++++++++++--
> rules/host-systemd.make | 6 ++++++
> 2 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/rules/host-systemd.in b/rules/host-systemd.in
> index 4d82ffc..58fb8d1 100644
> --- a/rules/host-systemd.in
> +++ b/rules/host-systemd.in
> @@ -1,7 +1,8 @@
> -## SECTION=hosttools_noprompt
> +## SECTION=hosttools
>
> -config HOST_SYSTEMD
> +menuconfig HOST_SYSTEMD
> bool
> + prompt "host systemd "
> default ALLYES
> select HOST_MESON
> select HOST_GPERF
> @@ -9,3 +10,10 @@ config HOST_SYSTEMD
> select HOST_COREUTILS
> select HOST_UTIL_LINUX_NG
> select HOST_LIBCAP
> +
> +config HOST_SYSTEMD_HWDB_ONLY
> + bool
> + prompt "systemd-hwdb only"
> + depends on HOST_SYSTEMD && SYSTEMD_UDEV_HWDB
> + default y
> +
...and a bit of help text wouldn't hurt here too.
Thank you,
ladis
> diff --git a/rules/host-systemd.make b/rules/host-systemd.make
> index f134f13..212114a 100644
> --- a/rules/host-systemd.make
> +++ b/rules/host-systemd.make
> @@ -121,7 +121,9 @@ HOST_SYSTEMD_CONF_OPT := \
> -Dxz=false \
> -Dzlib=false
>
> +ifdef PTXCONF_HOST_SYSTEMD_HWDB_ONLY
> HOST_SYSTEMD_MAKE_OPT := systemd-hwdb
> +endif
>
> # ----------------------------------------------------------------------------
> # Install
> @@ -129,11 +131,15 @@ HOST_SYSTEMD_MAKE_OPT := systemd-hwdb
>
> $(STATEDIR)/host-systemd.install:
> @$(call targetinfo)
> +ifdef PTXCONF_HOST_SYSTEMD_HWDB_ONLY
> @rm -rf $(HOST_SYSTEMD_PKGDIR)
> @install -vD -m755 $(HOST_SYSTEMD_DIR)-build/systemd-hwdb \
> $(HOST_SYSTEMD_PKGDIR)/bin/systemd-hwdb
> @install -vD -m755 $(HOST_SYSTEMD_DIR)-build/src/shared/libsystemd-shared-$(HOST_SYSTEMD_VERSION).so \
> $(HOST_SYSTEMD_PKGDIR)/lib/libsystemd-shared-$(HOST_SYSTEMD_VERSION).so
> +else
> + @$(call world/install, HOST_SYSTEMD)
> +endif
> @$(call touch)
>
> # vim: syntax=make
> --
> 1.9.1
>
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2018-08-01 6:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 0:22 [ptxdist] [PATCH v2 1/2] host-systemd: Fix rpath space problem jon
2018-08-01 0:22 ` [ptxdist] [PATCH v2 2/2] host-systemd: Add option to install hwdb only (enabled by default) jon
2018-08-01 6:07 ` Ladislav Michl [this message]
2018-08-01 7:20 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801060701.GA8956@lenoch \
--to=ladis@linux-mips.org \
--cc=jringle@gridpoint.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox