* [ptxdist] [PATCH] image-root-tgz: Remove quotes added around label put in tar ball
@ 2018-07-28 15:44 jon
2018-07-30 8:04 ` Michael Olbrich
0 siblings, 1 reply; 2+ messages in thread
From: jon @ 2018-07-28 15:44 UTC (permalink / raw)
To: ptxdist; +Cc: Jon Ringle
From: Jon Ringle <jringle@gridpoint.com>
Signed-off-by: Jon Ringle <jringle@gridpoint.com>
---
scripts/lib/ptxd_make_image_common.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/lib/ptxd_make_image_common.sh b/scripts/lib/ptxd_make_image_common.sh
index a925446..4c6d32e 100644
--- a/scripts/lib/ptxd_make_image_common.sh
+++ b/scripts/lib/ptxd_make_image_common.sh
@@ -67,7 +67,7 @@ ptxd_make_image_init() {
fi
if [ -n "${image_label}" ]; then
- image_label_args="--label \"${image_label}\""
+ image_label_args="--label ${image_label}"
else
image_label_args=""
fi
--
1.9.1
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [ptxdist] [PATCH] image-root-tgz: Remove quotes added around label put in tar ball
2018-07-28 15:44 [ptxdist] [PATCH] image-root-tgz: Remove quotes added around label put in tar ball jon
@ 2018-07-30 8:04 ` Michael Olbrich
0 siblings, 0 replies; 2+ messages in thread
From: Michael Olbrich @ 2018-07-30 8:04 UTC (permalink / raw)
To: ptxdist
On Sat, Jul 28, 2018 at 11:44:37AM -0400, jon@ringle.org wrote:
> From: Jon Ringle <jringle@gridpoint.com>
>
> Signed-off-by: Jon Ringle <jringle@gridpoint.com>
> ---
> scripts/lib/ptxd_make_image_common.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/lib/ptxd_make_image_common.sh b/scripts/lib/ptxd_make_image_common.sh
> index a925446..4c6d32e 100644
> --- a/scripts/lib/ptxd_make_image_common.sh
> +++ b/scripts/lib/ptxd_make_image_common.sh
> @@ -67,7 +67,7 @@ ptxd_make_image_init() {
> fi
>
> if [ -n "${image_label}" ]; then
> - image_label_args="--label \"${image_label}\""
> + image_label_args="--label ${image_label}"
this breaks labels with spaces. I've pushed a different fix.
Michael
> else
> image_label_args=""
> fi
> --
> 1.9.1
>
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-30 8:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-28 15:44 [ptxdist] [PATCH] image-root-tgz: Remove quotes added around label put in tar ball jon
2018-07-30 8:04 ` Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox