From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 1/3] monit: Fix largefile configure options
Date: Fri, 27 Jul 2018 12:02:03 +0200 [thread overview]
Message-ID: <20180727100203.6bgkb66tudrznwyj@pengutronix.de> (raw)
In-Reply-To: <3038307.RGCZeNYjQ4@ada>
On Fri, Jul 27, 2018 at 11:55:29AM +0200, Alexander Dahl wrote:
> Am Freitag, 27. Juli 2018, 11:42:42 CEST schrieb Roland Hieber:
> > On Fri, Jul 27, 2018 at 10:59:13AM +0200, Alexander Dahl wrote:
> > > + $(GLOBAL_LARGE_FILE_OPTION) \
> > >
> > > --enable-optimized \
> > > --disable-profiling \
> > >
> > > - $(GLOBAL_LARGE_FILE_OPTION) \
> > > + --$(call ptx/wwo, PTXCONF_GLOBAL_LARGE_FILE)-largefiles \
> >
> > Hmm. Why are you adding both GLOBAL_LARGE_FILE_OPTION and
> > PTXCONF_GLOBAL_LARGE_FILE? Are those two independent kconfig options
> > (and if yo, why)? Does the configure script respect both of them? I
> > guess this should be mentioned in the commit message :-)
>
> I don't know why monit has two options for the same thing. The doc output from
> ./configure --help contains this:
>
> --disable-largefile omit support for large files
>
> and
>
> --without-largefiles disable large files support (default: enabled)
>
> The script configure_helper.py complains about it, I am not familiar with
> autotools, so I can not judge what monit tries to do here. Because this is not
> the first time, I would guess monit upstream has broken autotools files? Maybe
> someone with more experience on that can say which option of those is used?
I checked to configure.ac. Setting both like this is correct.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2018-07-27 10:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 8:59 [ptxdist] [PATCH 0/3] monit: Upgrade from two years old version Alexander Dahl
2018-07-27 8:59 ` [ptxdist] [PATCH 1/3] monit: Fix largefile configure options Alexander Dahl
2018-07-27 9:42 ` Roland Hieber
2018-07-27 9:55 ` Alexander Dahl
2018-07-27 10:02 ` Michael Olbrich [this message]
2018-07-27 8:59 ` [ptxdist] [PATCH 2/3] monit: Add license file hash Alexander Dahl
2018-07-27 8:59 ` [ptxdist] [PATCH 3/3] monit: version bump 5.17.1 -> 5.25.2 Alexander Dahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727100203.6bgkb66tudrznwyj@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox