mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Roland Hieber <r.hieber@pengutronix.de>
To: Alexander Dahl <ada@thorsis.com>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 1/3] monit: Fix largefile configure options
Date: Fri, 27 Jul 2018 11:42:42 +0200	[thread overview]
Message-ID: <20180727094242.lumivbxncecap4p2@pengutronix.de> (raw)
In-Reply-To: <20180727085915.3689-2-ada@thorsis.com>

Hei hei,

On Fri, Jul 27, 2018 at 10:59:13AM +0200, Alexander Dahl wrote:
> Signed-off-by: Alexander Dahl <ada@thorsis.com>

> ---
>  rules/monit.make | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/rules/monit.make b/rules/monit.make
> index 2870e8056..a72c8e77d 100644
> --- a/rules/monit.make
> +++ b/rules/monit.make
> @@ -35,9 +35,10 @@ MONIT_CONF_ENV	:= $(CROSS_ENV) \
>  
>  MONIT_CONF_TOOL	:= autoconf
>  MONIT_CONF_OPT	:= $(CROSS_AUTOCONF_USR) \
> +	$(GLOBAL_LARGE_FILE_OPTION) \
>  	--enable-optimized \
>  	--disable-profiling \
> -	$(GLOBAL_LARGE_FILE_OPTION) \
> +	--$(call ptx/wwo, PTXCONF_GLOBAL_LARGE_FILE)-largefiles \

Hmm. Why are you adding both GLOBAL_LARGE_FILE_OPTION and
PTXCONF_GLOBAL_LARGE_FILE? Are those two independent kconfig options
(and if yo, why)? Does the configure script respect both of them? I
guess this should be mentioned in the commit message :-)

 - Roland

>  	--without-pam \
>  	--$(call ptx/wwo, PTXCONF_MONIT_SSL)-ssl \
>  	--with-ssl-dir=$(SYSROOT)/usr
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2018-07-27  9:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27  8:59 [ptxdist] [PATCH 0/3] monit: Upgrade from two years old version Alexander Dahl
2018-07-27  8:59 ` [ptxdist] [PATCH 1/3] monit: Fix largefile configure options Alexander Dahl
2018-07-27  9:42   ` Roland Hieber [this message]
2018-07-27  9:55     ` Alexander Dahl
2018-07-27 10:02       ` Michael Olbrich
2018-07-27  8:59 ` [ptxdist] [PATCH 2/3] monit: Add license file hash Alexander Dahl
2018-07-27  8:59 ` [ptxdist] [PATCH 3/3] monit: version bump 5.17.1 -> 5.25.2 Alexander Dahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180727094242.lumivbxncecap4p2@pengutronix.de \
    --to=r.hieber@pengutronix.de \
    --cc=ada@thorsis.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox