mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Roland Hieber <r.hieber@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 6/6] Revert "host-tz-database: use snprintf provided by the host compiler"
Date: Tue, 26 Jun 2018 16:03:38 +0200	[thread overview]
Message-ID: <20180626140338.wdfrhfz57ffx6uir@pengutronix.de> (raw)
In-Reply-To: <20180626065652.18064-7-ada@thorsis.com>

On Tue, Jun 26, 2018 at 08:56:52AM +0200, Alexander Dahl wrote:
> This reverts commit ee06ca66eb191271c937e9b0325a85a3c19dafc8.
> 
> Quote from the 2018a NEWS:
> 
> > Builders no longer need to specify -DHAVE_SNPRINTF on platforms that
> > have snprintf and use pre-C99 compilers.  (Problem reported by Jon
> > Skeet.)
> 
> Cc: Roland Hieber <r.hieber@pengutronix.de>
> Signed-off-by: Alexander Dahl <ada@thorsis.com>

Tested-by: Roland Hieber <r.hieber@pengutronix.de>

> ---
>  rules/host-tz-database.make | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/rules/host-tz-database.make b/rules/host-tz-database.make
> index 03b4bd906..c15d0feb7 100644
> --- a/rules/host-tz-database.make
> +++ b/rules/host-tz-database.make
> @@ -66,8 +66,8 @@ $(STATEDIR)/host-tz-database.extract:
>  HOST_TZ_DATABASE_PATH		:= PATH=$(HOST_PATH)
>  HOST_TZ_DATABASE_CONF_TOOL	:= NO
>  HOST_TZ_DATABASE_MAKE_OPT	:= \
> -	zic TZDIR=/usr/share/zoneinfo CFLAGS="-DSTD_INSPIRED -DHAVE_SNPRINTF"
> +	zic TZDIR=/usr/share/zoneinfo CFLAGS=-DSTD_INSPIRED
>  HOST_TZ_DATABASE_INSTALL_OPT	:= \
> -	posix_only TZDIR=/usr/share/zoneinfo CFLAGS="-DHAVE_SNPRINTF"
> +	posix_only TZDIR=/usr/share/zoneinfo
>  
>  # vim: syntax=make
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

      reply	other threads:[~2018-06-26 14:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-26  6:56 [ptxdist] [PATCH 0/6] timezone cleanup and tz update Alexander Dahl
2018-06-26  6:56 ` [ptxdist] [PATCH 1/6] timezone: Remove menu entry 'Mideast' Alexander Dahl
2018-06-26  6:56 ` [ptxdist] [PATCH 2/6] timezone: Cleanup timezone file removal Alexander Dahl
2018-06-26 13:50   ` Roland Hieber
2018-06-26 14:01     ` Alexander Dahl
2018-06-26 14:04       ` Alexander Dahl
2018-06-26 14:05       ` Roland Hieber
2018-06-26  6:56 ` [ptxdist] [PATCH 3/6] timezone: Order entries Alexander Dahl
2018-06-26  6:56 ` [ptxdist] [PATCH 4/6] timezone: Add missing zoneinfo entries Alexander Dahl
2018-06-26  6:56 ` [ptxdist] [PATCH 5/6] tz: version bump 2017c -> 2018e Alexander Dahl
2018-06-26 14:02   ` Roland Hieber
2018-06-26  6:56 ` [ptxdist] [PATCH 6/6] Revert "host-tz-database: use snprintf provided by the host compiler" Alexander Dahl
2018-06-26 14:03   ` Roland Hieber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180626140338.wdfrhfz57ffx6uir@pengutronix.de \
    --to=r.hieber@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox