From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] avahi: optional install avahi-browse
Date: Fri, 22 Jun 2018 12:04:24 +0200 [thread overview]
Message-ID: <20180622100424.dif2ufloo6d6vlud@pengutronix.de> (raw)
In-Reply-To: <1529653803.4757.14.camel@diehl.com>
On Fri, Jun 22, 2018 at 07:50:04AM +0000, Denis OSTERLAND wrote:
> Am Freitag, den 22.06.2018, 09:13 +0200 schrieb Michael Olbrich:
> > >
> > > +ifdef PTXCONF_AVAHI_BROWSE
> > > + @$(call install_copy, avahi, 0, 0, 0755, -, /usr/bin/avahi-browse)
> > I just pushed a change that installs several tools including avahi-browse.
> > Unless you see a good reason to split those up, I'd like to keep it that
> > way.
> Seems I forgot to pull yesterday before I sent the emails, sorry.
> AVAHI_UTILS is good.
I probably pushed this to the public git after you sent the patch.
> > >
> > > + @$(call install_link, avahi, avahi-browse, /usr/bin/avahi-browse-domains)
> > What's the reason for this link?
> >
> > Michael
> Thats a convenience function, "avahi-browse-domains" is equal to "avahi-browse -D".
> So it is not really needed, but nice to have.
> Are you willing to add the link, if I send you the patch?
Sure, just add this explanation to the commit message.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2018-06-22 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 11:25 Denis OSTERLAND
2018-06-22 7:13 ` Michael Olbrich
2018-06-22 7:50 ` Denis OSTERLAND
2018-06-22 10:04 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180622100424.dif2ufloo6d6vlud@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox