Re: [ptxdist] [PATCH] dc3dd: add new package

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Thu, Jun 21, 2018 at 01:12:46PM +0000, Denis OSTERLAND wrote:
> From: Thorsten Liepert <thorsten.liepert@diehl.com>
> 
> dd like tool with inline checksum validation.
> Allow to install as dd.
> 
> Signed-off-by: Thorsten Liepert <thorsten.liepert@diehl.com>
> Signed-off-by: Denis Osterland <Denis.Osterland@diehl.com>
> ---
>  rules/dc3dd.in   | 23 ++++++++++++++++
>  rules/dc3dd.make | 68 ++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 91 insertions(+)
>  create mode 100644 rules/dc3dd.in
>  create mode 100644 rules/dc3dd.make
> 
> diff --git a/rules/dc3dd.in b/rules/dc3dd.in
> new file mode 100644
> index 000000000..a97d6498e
> --- /dev/null
> +++ b/rules/dc3dd.in
> @@ -0,0 +1,23 @@
> +## SECTION=disk_and_file
> +
> +menuconfig DC3DD
> +	tristate
> +	default ALLYES

Remove the default.

> +	select LIBC_PTHREAD
> +	select LIBC
> +	prompt "dc3dd                         "
> +	help
> +	  dc3dd is a patched version of GNU dd with added features for computer forensics.
> +	  It was developed at the DoD Cyber Crime Center by Jesse Kornblum.
> +

What's the usecase to install two versions of dd? Is dc3dd compatible with
coreutils dd? If it is, then I think the whole package should have the
'depends on !...' and no suboption.

Michael

> +if DC3DD
> +
> +config DC3DD_DD
> +	bool
> +	depends on !COREUTILS_DD
> +	depends on !BUSYBOX_DD
> +	prompt "use DC3DD as default DD                 "
> +	help
> +	  installs a link called dd to dc3dd
> +
> +endif
> diff --git a/rules/dc3dd.make b/rules/dc3dd.make
> new file mode 100644
> index 000000000..e7f25d57c
> --- /dev/null
> +++ b/rules/dc3dd.make
> @@ -0,0 +1,68 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2016 by Thorsten Liepert
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_DC3DD) += dc3dd
> +
> +#
> +# Paths and names
> +#
> +DC3DD_VERSION		:= 7.2.641
> +DC3DD_MD5		:= 63987a467310d7b8a5102cb33e1945f4
> +DC3DD			:= dc3dd-$(DC3DD_VERSION)
> +DC3DD_SUFFIX		:= tar.xz
> +DC3DD_URL		:= $(call ptx/mirror, SF, dc3dd/7.2/dc3dd-$(DC3DD_VERSION).$(DC3DD_SUFFIX))
> +DC3DD_SOURCE		:= $(SRCDIR)/$(DC3DD).$(DC3DD_SUFFIX)
> +DC3DD_DIR		:= $(BUILDDIR)/$(DC3DD)
> +DC3DD_LICENSE		:= GPL-3.0-or-later
> +DC3DD_LICENSE_FILES	:= file://COPYING;md5=d32239bcb673463ab874e80d47fae504
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +#
> +# autoconf
> +#
> +DC3DD_AUTOCONF := \
> +	$(CROSS_AUTOCONF_USR) \
> +	$(GLOBAL_LARGE_FILE_OPTION) \
> +	--enable-dependency-tracking \
> +	--disable-assert \
> +	--disable-rpath \
> +	--disable-hdparm \
> +	--disable-nls \
> +	--without-included-regex \
> +	--with-gnu-ld
> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/dc3dd.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, dc3dd)
> +	@$(call install_fixup, dc3dd,PRIORITY,optional)
> +	@$(call install_fixup, dc3dd,SECTION,base)
> +	@$(call install_fixup, dc3dd,AUTHOR,"Thorsten Liepert <thorsten.liepert@diehl.com>")
> +	@$(call install_fixup, dc3dd,DESCRIPTION,missing)
> +
> +	@$(call install_copy, dc3dd, 0, 0, 0755, -, /usr/bin/dc3dd)
> +ifdef $(PTXCONF_DC3DD_DD)
> +	@$(call install_link, dc3dd, dc3dd, /usr/bin/dd)
> +endif
> +	@$(call install_finish, dc3dd)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make
> -- 
> 2.17.1
> 
> 
> Diehl AKO Stiftung & Co. KG, Pfannerstraße 75-83, 88239 Wangen im Allgäu
> Bereichsvorstand: Dipl.-Ing. Michael Siedentop (Sprecher), Josef Fellner (Mitglied)
> Sitz der Gesellschaft: Wangen i.A. – Registergericht: Amtsgericht Ulm HRA 620609 – Persönlich haftende Gesellschafterin: Diehl Verwaltungs-Stiftung – Sitz: Nürnberg – Registergericht: Amtsgericht Nürnberg HRA 11756 –
> Vorstand: Dr.-Ing. Karl Tragl (Vorsitzender), Herr Dipl.-Wirtsch.-Ing. Wolfgang Weggen (stellvertretender Vorsitzender), Dipl.-Kfm. Claus Günther, Dipl.-Kfm. Frank Gutzeit, Dr.-Ing. Heinrich Schunk, Dr.-Ing. Michael Siedentop , Dipl.-Kfm. Dr.-Ing. Martin Sommer, Dipl.-Ing. (FH) Rainer von Borstel, Vorsitzender des Aufsichtsrates: Dr. Klaus Maier
> ___________________________________________________________________________________________________
> Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
> Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht. Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
> The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de