From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] htop: version bump 2.1.0 -> 2.2.0
Date: Wed, 11 Apr 2018 09:36:26 +0200 [thread overview]
Message-ID: <20180411073626.542ge6jtog6kyl3t@pengutronix.de> (raw)
In-Reply-To: <1681396.WmAqkBQZN7@ada>
Hi,
On Wed, Apr 11, 2018 at 08:56:02AM +0200, Alexander Dahl wrote:
> Am Dienstag, 10. April 2018, 17:34:09 CEST schrieb Bastian Stender:
> > There are patches on top of htop 2.1.0. You should port them or drop
> > them as needed.
>
> FWIW …
>
> 0001-linux-LinuxProcessList-fix-reading-of-number-of-read.patch was applied
> upstream.
>
> 0002-configure-check-for-ncurses-with-ncurses6-config.patch applies cleanly to
> htop 2.2.0, but I'm not sure it's needed, they changed ncurses CFLAGS use in
> upstream commit bc5d46982f3504000567e00f59e4f7a5905597a9, maybe more info on
> that in #695 [1] and #745 [2]. Also they fixed things with pkg-config, so I'm
> not sure if it is really needed anymore. Maybe see the discussions about
> ncurses6 earlier this year on this list or the commit introducing that patch
> (74ffd1f57d0d68a89183ea2bf47c0cd67a989520).
The problem is, that configure looks for libncurses6 with ncurses6-config.
We don't have that combination. The fallback is ncurses5-config. That may
be picked up from the system, which is bad.
HTOP_NCURSES_CONFIG_SCRIPT=ncurses6-config in the _CONF_ENV should work
instead of the patch.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2018-04-11 7:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 15:14 Roland Hieber
2018-04-10 15:34 ` Bastian Stender
2018-04-11 6:56 ` Alexander Dahl
2018-04-11 7:36 ` Michael Olbrich [this message]
2018-04-11 8:49 ` Roland Hieber
2018-04-15 19:17 ` [ptxdist] [PATCH v2] " Roland Hieber
2018-04-16 15:39 ` Michael Olbrich
2018-04-17 8:10 ` Ladislav Michl
2018-04-18 8:28 ` [ptxdist] [PATCH v3] " Roland Hieber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180411073626.542ge6jtog6kyl3t@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox