* [ptxdist] [PATCH 2/2] libgpg-error: version bump 1.27 -> 1.28
2018-04-05 13:42 [ptxdist] [PATCH 1/2] gnupg: version bump 2.2.4 -> 2.2.5 Clemens Gruber
@ 2018-04-05 13:42 ` Clemens Gruber
0 siblings, 0 replies; 2+ messages in thread
From: Clemens Gruber @ 2018-04-05 13:42 UTC (permalink / raw)
To: ptxdist; +Cc: Clemens Gruber
Also add new configure flags and an upstream patch to fix a regression.
Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
---
...ion-on-arm64-due-to-invalid-use-of-v.patch | 59 +++++++++++++++++++
patches/libgpg-error-1.28/series | 1 +
rules/libgpg-error.make | 6 +-
3 files changed, 64 insertions(+), 2 deletions(-)
create mode 100644 patches/libgpg-error-1.28/0001-core-Fix-regression-on-arm64-due-to-invalid-use-of-v.patch
create mode 100644 patches/libgpg-error-1.28/series
diff --git a/patches/libgpg-error-1.28/0001-core-Fix-regression-on-arm64-due-to-invalid-use-of-v.patch b/patches/libgpg-error-1.28/0001-core-Fix-regression-on-arm64-due-to-invalid-use-of-v.patch
new file mode 100644
index 000000000..a37337a09
--- /dev/null
+++ b/patches/libgpg-error-1.28/0001-core-Fix-regression-on-arm64-due-to-invalid-use-of-v.patch
@@ -0,0 +1,59 @@
+From 791177de023574223eddf7288eb7c5a0721ac623 Mon Sep 17 00:00:00 2001
+From: Werner Koch <wk@gnupg.org>
+Date: Sun, 18 Mar 2018 17:39:43 +0100
+Subject: [PATCH] core: Fix regression on arm64 due to invalid use of va_list.
+
+* src/logging.c (_gpgrt_log_printhex): Provide a dummy arg instead of
+NULL.
+--
+
+Fix
+Suggested-by: Jakub Wilk <jwilk@jwilk.net>
+
+Signed-off-by: Werner Koch <wk@gnupg.org>
+Signed-off-by: Baruch Siach <baruch@tkos.co.il>
+---
+Upstream status: commit 791177de023
+
+ src/logging.c | 18 ++++++++++++++----
+ 1 file changed, 14 insertions(+), 4 deletions(-)
+
+diff --git a/src/logging.c b/src/logging.c
+index 1a4f6203d16d..d01f974e4545 100644
+--- a/src/logging.c
++++ b/src/logging.c
+@@ -1090,9 +1090,10 @@ _gpgrt_log_flush (void)
+
+
+ /* Print a hexdump of (BUFFER,LENGTH). With FMT passed as NULL print
+- * just the raw dump, with FMT being an empty string, print a trailing
+- * linefeed, otherwise print an entire debug line with the expanded
+- * FMT followed by a possible wrapped hexdump and a final LF. */
++ * just the raw dump (in this case ARG_PTR is not used), with FMT
++ * being an empty string, print a trailing linefeed, otherwise print
++ * an entire debug line with the expanded FMT followed by a possible
++ * wrapped hexdump and a final LF. */
+ void
+ _gpgrt_logv_printhex (const void *buffer, size_t length,
+ const char *fmt, va_list arg_ptr)
+@@ -1150,7 +1151,16 @@ _gpgrt_log_printhex (const void *buffer, size_t length,
+ va_end (arg_ptr);
+ }
+ else
+- _gpgrt_logv_printhex (buffer, length, NULL, NULL);
++ {
++ /* va_list is not necessary a pointer and thus we can't use NULL
++ * because that would conflict with platforms using a straight
++ * struct for it (e.g. arm64). We use a dummy variable instead;
++ * the static is a simple way zero it out so to not get
++ * complains about uninitialized use. */
++ static va_list dummy_argptr;
++
++ _gpgrt_logv_printhex (buffer, length, NULL, dummy_argptr);
++ }
+ }
+
+
+--
+2.16.2
+
diff --git a/patches/libgpg-error-1.28/series b/patches/libgpg-error-1.28/series
new file mode 100644
index 000000000..eece365bd
--- /dev/null
+++ b/patches/libgpg-error-1.28/series
@@ -0,0 +1 @@
+0001-core-Fix-regression-on-arm64-due-to-invalid-use-of-v.patch
diff --git a/rules/libgpg-error.make b/rules/libgpg-error.make
index 96de745e6..525ab0c7a 100644
--- a/rules/libgpg-error.make
+++ b/rules/libgpg-error.make
@@ -17,8 +17,8 @@ PACKAGES-$(PTXCONF_LIBGPG_ERROR) += libgpg-error
#
# Paths and names
#
-LIBGPG_ERROR_VERSION := 1.27
-LIBGPG_ERROR_MD5 := 5217ef3e76a7275a2a3b569a12ddc989
+LIBGPG_ERROR_VERSION := 1.28
+LIBGPG_ERROR_MD5 := 2b072f6194eb22d48cd4c7c77e59b5af
LIBGPG_ERROR := libgpg-error-$(LIBGPG_ERROR_VERSION)
LIBGPG_ERROR_SUFFIX := tar.bz2
LIBGPG_ERROR_URL := \
@@ -49,6 +49,8 @@ LIBGPG_ERROR_CONF_OPT := \
$(GLOBAL_LARGE_FILE_OPTION) \
--disable-nls \
--disable-rpath \
+ --disable-log-clock \
+ --disable-werror \
--enable-build-timestamp="$(PTXDIST_VERSION_YEAR)-$(PTXDIST_VERSION_MONTH)-01T00:00+0000" \
--disable-languages \
--disable-doc \
--
2.17.0
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 2+ messages in thread