Re: [ptxdist] [PATCH] license-csv: Add rules to generate CSV license report.

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Thu, Mar 29, 2018 at 12:46:16PM +0000, Denis OSTERLAND wrote:
> Am Donnerstag, den 29.03.2018, 14:08 +0200 schrieb Andreas Pretzsch:
> > On Do, 2018-03-29 at 07:29 +0000, Denis OSTERLAND wrote:
> > Extending the field list by section is a good point, thanks. Will do.
> > 
> > But I would refrain from including the URL (for now), simply as it will
> > include all sorts of characters, which then will require proper
> > escaping. And in 20+ years, I've seen way too many broken parsers (and
> > escapers)...
> > Beside, the key point of the CSV list (to me / customers) is to have a
> > diff'able list of included packages (which ones, version, license),
> > beside the full fledged report. To see if one needs to look into
> > something. So URL is nice, but not mandatory.
> > 
> > Last, about the CSV separator, I chose | out of experience, avoiding
> > most collisions. Both , and ; show up often in text and even version
> > tags. Yes, they are marked as string with "", but back to "broken
> > parsers"...
> > 
> > So I still tend to a CSV output like:
> > 
> > "name"|"version"|"section"|"licenses"|"flags"
> > "somepackage"|"1.2.3"|"osi-conform"|"Apache-2.0"|"attribution"
> > [...]
> > 
> > 
> > Denis, what do you think ?
> You are right, URL tend to be brittle.
> We use it as input for an overview page on embedded web server.
> This will need some refactoring.

You could overwrite the function that generates the per package file in
your BSP.

> By the way, is it possible depend on your csv report from make?
> I guess I will need to add some wrapper target to call sh function.

There is a make target for the license report. If necessary we can
restructure this as needed.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de