Re: [ptxdist] [PATCH 2/2] scripts/lib: also create CSV lists on "ptxdist make license-report"

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Thu, Mar 29, 2018 at 02:08:51PM +0200, Andreas Pretzsch wrote:
> On Do, 2018-03-29 at 11:46 +0200, Michael Olbrich wrote:
> > > +ptxd_make_world_license_write_csv() {
> > > +	local -r STRING_QUOTE='"'
> > > +	local -r CSV_SEPARATOR='|'
> > > +	local -a flags=( "${!pkg_license_flags[@]}" )
> > > +	local l
> > > +
> > > +	# not required, seems to be filtered before:
> > > +	#case "${pkg_license}" in
> > > +	#*ignore*)
> > > +	#	# ignore this package, e.g. do not list it in the report
> > > +	#	return 0
> > > +	#	;;
> > > +	#esac
> 
> Any comment on this commented section ?
> Back then, I copied the logic from somewhere, but filtering was not
> required in a real run. Still, kept it as reference.

Just drop this. The license is in the csv, so the processing tool can
filter if necessary.

> I'll rework the patch as above over Easter time, plus
>   - include section tag (see Denis' patch)
>   - squash it into one with "add suffix _tex"

Sounds good, thanks.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de