mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: [ptxdist] [PATCH] git-ptx-patches: consume complete output of man
Date: Wed, 21 Mar 2018 11:20:40 +0100	[thread overview]
Message-ID: <20180321102040.17352-1-u.kleine-koenig@pengutronix.de> (raw)

On Debian unstable/testing man doesn't like it's stdout being closed
prematurely:

	$ man git-format-patch | grep -q -e --notes
	Bad system call (core dumped)
	man: command exited with status 159: /usr/lib/man-db/zsoelim | /usr/lib/man-db/manconv -f UTF-8:ISO-8859-1 -t UTF-8//IGNORE | preconv -e UTF-8 | tbl | nroff -mandoc -Tutf8

This clutters the output of git ptx-patches which is annoying.

While this is a bug of man(1), it is easy enough to work around by not
using grep -q.

Bug-Debian: https://bugs.debian.org/892309
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,

not sure it is really necessary to work around this problem given that
the bug is fixed soon in Debian and is also fixed upstream. But as I
already implemented the patch and only found the bug while thinking what
to write in the commit log, I send it anyhow and let you decide if you
want the patch or not.

Best regards
Uwe

 scripts/git-ptx-patches | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/git-ptx-patches b/scripts/git-ptx-patches
index cdecd799a657..66cefb62c07c 100755
--- a/scripts/git-ptx-patches
+++ b/scripts/git-ptx-patches
@@ -122,7 +122,7 @@ fi
 
 # git-format-patch --notes is supported since git 1.7.6, but actually you want
 # git 1.8.1-rc0 to get the notes below the --- marker
-if man git-format-patch | grep -q -e --notes; then
+if man git-format-patch | grep -e --notes > /dev/null; then
 	GIT_EXTRA_ARGS="$GIT_EXTRA_ARGS --notes"
 fi
 
-- 
2.16.1


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

                 reply	other threads:[~2018-03-21 10:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180321102040.17352-1-u.kleine-koenig@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox