From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] elfutils: Add patch for removing -Werror
Date: Fri, 9 Mar 2018 18:17:40 +0100 [thread overview]
Message-ID: <20180309171740.q7dcjtocvylmleta@pengutronix.de> (raw)
In-Reply-To: <20180223082417.948-1-ada@thorsis.com>
On Fri, Feb 23, 2018 at 09:24:17AM +0100, Alexander Dahl wrote:
> When globally enabling -Wcast-align, which is useful on older arm
> targets, libelf compile fails due to -Werror set.
I don't like adding patches for stuff that is not in ptxdist mainline.
Especially patches that will never be upstreamed.
With 'globally' you mean TARGET_EXTRA_CFLAGS etc., right? You should be
able to add '-Wno-error=cast-align' there too. A later '-Werror' in the
command-line will not overwrite this more specific option.
Michael
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> ---
> patches/elfutils-0.170/0001-Remove-Werror.patch | 23 +++++++++++++++++++++++
> patches/elfutils-0.170/autogen.sh | 1 +
> patches/elfutils-0.170/series | 4 ++++
> 3 files changed, 28 insertions(+)
> create mode 100644 patches/elfutils-0.170/0001-Remove-Werror.patch
> create mode 120000 patches/elfutils-0.170/autogen.sh
> create mode 100644 patches/elfutils-0.170/series
>
> diff --git a/patches/elfutils-0.170/0001-Remove-Werror.patch b/patches/elfutils-0.170/0001-Remove-Werror.patch
> new file mode 100644
> index 0000000000..10a42b3cb8
> --- /dev/null
> +++ b/patches/elfutils-0.170/0001-Remove-Werror.patch
> @@ -0,0 +1,23 @@
> +From: Alexander Dahl <ada@thorsis.com>
> +Date: Fri, 23 Feb 2018 08:50:04 +0100
> +Subject: [PATCH] Remove -Werror
> +
> +Otherwise build fails on arm-v5te if global -Wcast-align is set.
> +
> +Signed-off-by: Alexander Dahl <ada@thorsis.com>
> +---
> + config/eu.am | 1 -
> + 1 file changed, 1 deletion(-)
> +
> +diff --git a/config/eu.am b/config/eu.am
> +index 8fe1e259f9e2..c5a6209a4e04 100644
> +--- a/config/eu.am
> ++++ b/config/eu.am
> +@@ -71,7 +71,6 @@ AM_CFLAGS = -std=gnu99 -Wall -Wshadow -Wformat=2 \
> + -Wold-style-definition -Wstrict-prototypes \
> + $(LOGICAL_OP_WARNING) $(DUPLICATED_COND_WARNING) \
> + $(NULL_DEREFERENCE_WARNING) $(IMPLICIT_FALLTHROUGH_WARNING) \
> +- $(if $($(*F)_no_Werror),,-Werror) \
> + $(if $($(*F)_no_Wunused),,-Wunused -Wextra) \
> + $(if $($(*F)_no_Wstack_usage),,$(STACK_USAGE_WARNING)) \
> + $($(*F)_CFLAGS)
> diff --git a/patches/elfutils-0.170/autogen.sh b/patches/elfutils-0.170/autogen.sh
> new file mode 120000
> index 0000000000..9f8a4cb7dd
> --- /dev/null
> +++ b/patches/elfutils-0.170/autogen.sh
> @@ -0,0 +1 @@
> +../autogen.sh
> \ No newline at end of file
> diff --git a/patches/elfutils-0.170/series b/patches/elfutils-0.170/series
> new file mode 100644
> index 0000000000..980b105128
> --- /dev/null
> +++ b/patches/elfutils-0.170/series
> @@ -0,0 +1,4 @@
> +# generated by git-ptx-patches
> +#tag:base --start-number 1
> +0001-Remove-Werror.patch
> +# 2663f0f9573dba0dfadde4c336a4c88c - git-ptx-patches magic
> --
> 2.11.0
>
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2018-03-09 17:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 8:24 Alexander Dahl
2018-03-08 8:52 ` Alexander Dahl
2018-03-09 17:17 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180309171740.q7dcjtocvylmleta@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox