mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] microcom: version bump 2009.06 -> 2017.03.0
Date: Fri, 9 Mar 2018 18:14:26 +0100	[thread overview]
Message-ID: <20180309171426.2ar366nb3kh3bqm2@pengutronix.de> (raw)
In-Reply-To: <20180307092958.2076-1-u.kleine-koenig@pengutronix.de>

On Wed, Mar 07, 2018 at 10:29:58AM +0100, Uwe Kleine-König wrote:
> The program is using autoconf since it was last packaged for ptxdist, so
> the rule can be simplified accordingly.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> This obviously obsoletes the patch
> 
> 	[PATCH] microcom: version bump 2009.06 -> 2016.01.0
> 
> sent last week.
> 
> Changes since then:
>  - new upstream version 2017.03.0

A _new_ version from 2017? I would have expected 2018.03.0

Also:
[...]
parser.c:10:31: fatal error: readline/readline.h: No such file or directory
[...]

A missing dependency, I think.

Michael

>  - pass --enable-can and handle LFS stuff
> 
> Best regards
> Uwe
> 
>  rules/microcom.make | 24 +++++++++---------------
>  1 file changed, 9 insertions(+), 15 deletions(-)
> 
> diff --git a/rules/microcom.make b/rules/microcom.make
> index 2227ea9ff0f9..3b28859fbda8 100644
> --- a/rules/microcom.make
> +++ b/rules/microcom.make
> @@ -16,10 +16,10 @@ PACKAGES-$(PTXCONF_MICROCOM) += microcom
>  #
>  # Paths and names
>  #
> -MICROCOM_VERSION	:= 2009.06
> -MICROCOM_MD5		:= 68a63c2d56196a28be89d1b4e5d13af1
> +MICROCOM_VERSION	:= 2017.03.0
> +MICROCOM_MD5		:= 801d99dcb4b2ef7e8b77b51bba193066
>  MICROCOM		:= microcom-$(MICROCOM_VERSION)
> -MICROCOM_SUFFIX		:= tar.gz
> +MICROCOM_SUFFIX		:= tar.xz
>  MICROCOM_URL		:= http://www.pengutronix.de/software/microcom/download/$(MICROCOM).$(MICROCOM_SUFFIX)
>  MICROCOM_SOURCE		:= $(SRCDIR)/$(MICROCOM).$(MICROCOM_SUFFIX)
>  MICROCOM_DIR		:= $(BUILDDIR)/$(MICROCOM)
> @@ -29,16 +29,11 @@ MICROCOM_LICENSE	:= GPL-2.0
>  # Prepare
>  # ----------------------------------------------------------------------------
>  
> -MICROCOM_PATH := PATH=$(CROSS_PATH)
> -MICROCOM_COMPILE_ENV := $(CROSS_ENV)
> -
> -# ----------------------------------------------------------------------------
> -# Install
> -# ----------------------------------------------------------------------------
> -
> -$(STATEDIR)/microcom.install:
> -	@$(call targetinfo)
> -	@$(call touch)
> +MICROCOM_CONF_TOOL := autoconf
> +MICROCOM_CONF_OPT := \
> +	$(CROSS_AUTOCONF_USR) \
> +	$(GLOBAL_LARGE_FILE_OPTION) \
> +	--enable-can \
>  
>  # ----------------------------------------------------------------------------
>  # Target-Install
> @@ -53,10 +48,9 @@ $(STATEDIR)/microcom.targetinstall:
>  	@$(call install_fixup, microcom,AUTHOR,"Marc Kleine-Budde <mkl@pengutronix.de>")
>  	@$(call install_fixup, microcom,DESCRIPTION,missing)
>  
> -	@$(call install_copy, microcom, 0, 0, 0755, $(MICROCOM_DIR)/microcom, /usr/bin/microcom)
> +	@$(call install_copy, microcom, 0, 0, 0755, -, /usr/bin/microcom)
>  
>  	@$(call install_finish, microcom)
> -
>  	@$(call touch)
>  
>  # vim: syntax=make
> -- 
> 2.16.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2018-03-09 17:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-07  9:29 Uwe Kleine-König
2018-03-09 17:14 ` Michael Olbrich [this message]
2018-03-11 19:29   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180309171426.2ar366nb3kh3bqm2@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox