* [ptxdist] [PATCH] elfutils: Add patch for removing -Werror
@ 2018-02-23 8:24 Alexander Dahl
2018-03-08 8:52 ` Alexander Dahl
2018-03-09 17:17 ` Michael Olbrich
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Dahl @ 2018-02-23 8:24 UTC (permalink / raw)
To: ptxdist
When globally enabling -Wcast-align, which is useful on older arm
targets, libelf compile fails due to -Werror set.
Signed-off-by: Alexander Dahl <ada@thorsis.com>
---
patches/elfutils-0.170/0001-Remove-Werror.patch | 23 +++++++++++++++++++++++
patches/elfutils-0.170/autogen.sh | 1 +
patches/elfutils-0.170/series | 4 ++++
3 files changed, 28 insertions(+)
create mode 100644 patches/elfutils-0.170/0001-Remove-Werror.patch
create mode 120000 patches/elfutils-0.170/autogen.sh
create mode 100644 patches/elfutils-0.170/series
diff --git a/patches/elfutils-0.170/0001-Remove-Werror.patch b/patches/elfutils-0.170/0001-Remove-Werror.patch
new file mode 100644
index 0000000000..10a42b3cb8
--- /dev/null
+++ b/patches/elfutils-0.170/0001-Remove-Werror.patch
@@ -0,0 +1,23 @@
+From: Alexander Dahl <ada@thorsis.com>
+Date: Fri, 23 Feb 2018 08:50:04 +0100
+Subject: [PATCH] Remove -Werror
+
+Otherwise build fails on arm-v5te if global -Wcast-align is set.
+
+Signed-off-by: Alexander Dahl <ada@thorsis.com>
+---
+ config/eu.am | 1 -
+ 1 file changed, 1 deletion(-)
+
+diff --git a/config/eu.am b/config/eu.am
+index 8fe1e259f9e2..c5a6209a4e04 100644
+--- a/config/eu.am
++++ b/config/eu.am
+@@ -71,7 +71,6 @@ AM_CFLAGS = -std=gnu99 -Wall -Wshadow -Wformat=2 \
+ -Wold-style-definition -Wstrict-prototypes \
+ $(LOGICAL_OP_WARNING) $(DUPLICATED_COND_WARNING) \
+ $(NULL_DEREFERENCE_WARNING) $(IMPLICIT_FALLTHROUGH_WARNING) \
+- $(if $($(*F)_no_Werror),,-Werror) \
+ $(if $($(*F)_no_Wunused),,-Wunused -Wextra) \
+ $(if $($(*F)_no_Wstack_usage),,$(STACK_USAGE_WARNING)) \
+ $($(*F)_CFLAGS)
diff --git a/patches/elfutils-0.170/autogen.sh b/patches/elfutils-0.170/autogen.sh
new file mode 120000
index 0000000000..9f8a4cb7dd
--- /dev/null
+++ b/patches/elfutils-0.170/autogen.sh
@@ -0,0 +1 @@
+../autogen.sh
\ No newline at end of file
diff --git a/patches/elfutils-0.170/series b/patches/elfutils-0.170/series
new file mode 100644
index 0000000000..980b105128
--- /dev/null
+++ b/patches/elfutils-0.170/series
@@ -0,0 +1,4 @@
+# generated by git-ptx-patches
+#tag:base --start-number 1
+0001-Remove-Werror.patch
+# 2663f0f9573dba0dfadde4c336a4c88c - git-ptx-patches magic
--
2.11.0
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ptxdist] [PATCH] elfutils: Add patch for removing -Werror
2018-02-23 8:24 [ptxdist] [PATCH] elfutils: Add patch for removing -Werror Alexander Dahl
@ 2018-03-08 8:52 ` Alexander Dahl
2018-03-09 17:17 ` Michael Olbrich
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Dahl @ 2018-03-08 8:52 UTC (permalink / raw)
To: ptxdist; +Cc: Michael Olbrich
Hei hei,
what about this patch? Did it get lost?
Greets
Alex
Am Freitag, 23. Februar 2018, 09:24:17 CET schrieb Alexander Dahl:
> When globally enabling -Wcast-align, which is useful on older arm
> targets, libelf compile fails due to -Werror set.
>
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> ---
> patches/elfutils-0.170/0001-Remove-Werror.patch | 23
> +++++++++++++++++++++++ patches/elfutils-0.170/autogen.sh |
> 1 +
> patches/elfutils-0.170/series | 4 ++++
> 3 files changed, 28 insertions(+)
> create mode 100644 patches/elfutils-0.170/0001-Remove-Werror.patch
> create mode 120000 patches/elfutils-0.170/autogen.sh
> create mode 100644 patches/elfutils-0.170/series
>
> diff --git a/patches/elfutils-0.170/0001-Remove-Werror.patch
> b/patches/elfutils-0.170/0001-Remove-Werror.patch new file mode 100644
> index 0000000000..10a42b3cb8
> --- /dev/null
> +++ b/patches/elfutils-0.170/0001-Remove-Werror.patch
> @@ -0,0 +1,23 @@
> +From: Alexander Dahl <ada@thorsis.com>
> +Date: Fri, 23 Feb 2018 08:50:04 +0100
> +Subject: [PATCH] Remove -Werror
> +
> +Otherwise build fails on arm-v5te if global -Wcast-align is set.
> +
> +Signed-off-by: Alexander Dahl <ada@thorsis.com>
> +---
> + config/eu.am | 1 -
> + 1 file changed, 1 deletion(-)
> +
> +diff --git a/config/eu.am b/config/eu.am
> +index 8fe1e259f9e2..c5a6209a4e04 100644
> +--- a/config/eu.am
> ++++ b/config/eu.am
> +@@ -71,7 +71,6 @@ AM_CFLAGS = -std=gnu99 -Wall -Wshadow -Wformat=2 \
> + -Wold-style-definition -Wstrict-prototypes \
> + $(LOGICAL_OP_WARNING) $(DUPLICATED_COND_WARNING) \
> + $(NULL_DEREFERENCE_WARNING) $(IMPLICIT_FALLTHROUGH_WARNING) \
> +- $(if $($(*F)_no_Werror),,-Werror) \
> + $(if $($(*F)_no_Wunused),,-Wunused -Wextra) \
> + $(if $($(*F)_no_Wstack_usage),,$(STACK_USAGE_WARNING)) \
> + $($(*F)_CFLAGS)
> diff --git a/patches/elfutils-0.170/autogen.sh
> b/patches/elfutils-0.170/autogen.sh new file mode 120000
> index 0000000000..9f8a4cb7dd
> --- /dev/null
> +++ b/patches/elfutils-0.170/autogen.sh
> @@ -0,0 +1 @@
> +../autogen.sh
> \ No newline at end of file
> diff --git a/patches/elfutils-0.170/series b/patches/elfutils-0.170/series
> new file mode 100644
> index 0000000000..980b105128
> --- /dev/null
> +++ b/patches/elfutils-0.170/series
> @@ -0,0 +1,4 @@
> +# generated by git-ptx-patches
> +#tag:base --start-number 1
> +0001-Remove-Werror.patch
> +# 2663f0f9573dba0dfadde4c336a4c88c - git-ptx-patches magic
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ptxdist] [PATCH] elfutils: Add patch for removing -Werror
2018-02-23 8:24 [ptxdist] [PATCH] elfutils: Add patch for removing -Werror Alexander Dahl
2018-03-08 8:52 ` Alexander Dahl
@ 2018-03-09 17:17 ` Michael Olbrich
1 sibling, 0 replies; 3+ messages in thread
From: Michael Olbrich @ 2018-03-09 17:17 UTC (permalink / raw)
To: ptxdist
On Fri, Feb 23, 2018 at 09:24:17AM +0100, Alexander Dahl wrote:
> When globally enabling -Wcast-align, which is useful on older arm
> targets, libelf compile fails due to -Werror set.
I don't like adding patches for stuff that is not in ptxdist mainline.
Especially patches that will never be upstreamed.
With 'globally' you mean TARGET_EXTRA_CFLAGS etc., right? You should be
able to add '-Wno-error=cast-align' there too. A later '-Werror' in the
command-line will not overwrite this more specific option.
Michael
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> ---
> patches/elfutils-0.170/0001-Remove-Werror.patch | 23 +++++++++++++++++++++++
> patches/elfutils-0.170/autogen.sh | 1 +
> patches/elfutils-0.170/series | 4 ++++
> 3 files changed, 28 insertions(+)
> create mode 100644 patches/elfutils-0.170/0001-Remove-Werror.patch
> create mode 120000 patches/elfutils-0.170/autogen.sh
> create mode 100644 patches/elfutils-0.170/series
>
> diff --git a/patches/elfutils-0.170/0001-Remove-Werror.patch b/patches/elfutils-0.170/0001-Remove-Werror.patch
> new file mode 100644
> index 0000000000..10a42b3cb8
> --- /dev/null
> +++ b/patches/elfutils-0.170/0001-Remove-Werror.patch
> @@ -0,0 +1,23 @@
> +From: Alexander Dahl <ada@thorsis.com>
> +Date: Fri, 23 Feb 2018 08:50:04 +0100
> +Subject: [PATCH] Remove -Werror
> +
> +Otherwise build fails on arm-v5te if global -Wcast-align is set.
> +
> +Signed-off-by: Alexander Dahl <ada@thorsis.com>
> +---
> + config/eu.am | 1 -
> + 1 file changed, 1 deletion(-)
> +
> +diff --git a/config/eu.am b/config/eu.am
> +index 8fe1e259f9e2..c5a6209a4e04 100644
> +--- a/config/eu.am
> ++++ b/config/eu.am
> +@@ -71,7 +71,6 @@ AM_CFLAGS = -std=gnu99 -Wall -Wshadow -Wformat=2 \
> + -Wold-style-definition -Wstrict-prototypes \
> + $(LOGICAL_OP_WARNING) $(DUPLICATED_COND_WARNING) \
> + $(NULL_DEREFERENCE_WARNING) $(IMPLICIT_FALLTHROUGH_WARNING) \
> +- $(if $($(*F)_no_Werror),,-Werror) \
> + $(if $($(*F)_no_Wunused),,-Wunused -Wextra) \
> + $(if $($(*F)_no_Wstack_usage),,$(STACK_USAGE_WARNING)) \
> + $($(*F)_CFLAGS)
> diff --git a/patches/elfutils-0.170/autogen.sh b/patches/elfutils-0.170/autogen.sh
> new file mode 120000
> index 0000000000..9f8a4cb7dd
> --- /dev/null
> +++ b/patches/elfutils-0.170/autogen.sh
> @@ -0,0 +1 @@
> +../autogen.sh
> \ No newline at end of file
> diff --git a/patches/elfutils-0.170/series b/patches/elfutils-0.170/series
> new file mode 100644
> index 0000000000..980b105128
> --- /dev/null
> +++ b/patches/elfutils-0.170/series
> @@ -0,0 +1,4 @@
> +# generated by git-ptx-patches
> +#tag:base --start-number 1
> +0001-Remove-Werror.patch
> +# 2663f0f9573dba0dfadde4c336a4c88c - git-ptx-patches magic
> --
> 2.11.0
>
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-09 17:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-23 8:24 [ptxdist] [PATCH] elfutils: Add patch for removing -Werror Alexander Dahl
2018-03-08 8:52 ` Alexander Dahl
2018-03-09 17:17 ` Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox