Re: [ptxdist] [PATCH 1/4] ncurses: version bump 5.9 -> 6.1

[Michael Olbrich <m.olbrich@pengutronix.de>]

Hi,

On Thu, Feb 22, 2018 at 10:53:35AM +0100, Ladislav Michl wrote:
> thanks for your work, I'm currently locked in kernel space, so I cannot
> test right now...

That's ok.

> On Thu, Feb 22, 2018 at 09:12:20AM +0100, Michael Olbrich wrote:
> > Hi,
> > 
> > I took a closer look at this and checked what Debian is doing. I've
> > attached a fixup patch that changes a few things:
> > 
> > - use abi version 5. Some packages lock for that version explicitly.
> 
> Which are those? As we are certainly carrying fewer packages that Debian
> does, isn't it more reasonable to just fix packages?

alsa-utils fails, but I think, that is because the pkg-config files are
installed to 'platform-XXX/packages/ncurses-6.1yes'. I think you need to
set that path correctly.
Lets try this again without the abi version but correct pc files. So just
include my other changes but leave the abi-version stuff out for v2.

> > - use linker scripts too deal with the tinfo problem
> > - fix some usr-merge fallout.
> > 
> > On Fri, Feb 09, 2018 at 03:14:19PM +0100, Ladislav Michl wrote:
> > > Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> > > ---
> > >  .../0001-teach-ncurses-config-about-sysroot.patch  | 39 +++++-----
> > >  patches/{ncurses-5.9 => ncurses-6.1}/series        |  0
> > >  rules/ncurses.make                                 | 87 +++++++++++-----------
> > >  3 files changed, 61 insertions(+), 65 deletions(-)
> > >
> > [...]
> > > diff --git a/rules/ncurses.make b/rules/ncurses.make
> > > index c2fcde478..40be792fb 100644
> > > --- a/rules/ncurses.make
> > > +++ b/rules/ncurses.make
> > > @@ -15,9 +15,9 @@ PACKAGES-$(PTXCONF_NCURSES) += ncurses
> > >  #
> > >  # Paths and names
> > >  #
> > > -NCURSES_VERSION	:= 5.9
> > > +NCURSES_VERSION	:= 6.1
> > >  NCURSES_MAJOR	:= $(word 1,$(subst ., ,$(NCURSES_VERSION)))
> > > -NCURSES_MD5	:= 8cb9c412e5f2d96bc6f459aa8c6282a1
> > > +NCURSES_MD5	:= 98c889aaf8d23910d2b92d65be2e737a
> > >  NCURSES		:= ncurses-$(NCURSES_VERSION)
> > >  NCURSES_SUFFIX	:= tar.gz
> > >  NCURSES_URL	:= $(call ptx/mirror, GNU, ncurses/$(NCURSES).$(NCURSES_SUFFIX))
> > > @@ -31,58 +31,57 @@ NCURSES_LICENSE_FILES	:= \
> > >  # Prepare
> > >  # ----------------------------------------------------------------------------
> > >  
> > > -NCURSES_ENV := \
> > > +NCURSES_CONF_TOOL := autoconf
> > > +NCURSES_CONF_ENV := \
> > >  	$(CROSS_ENV) \
> > >  	TIC_PATH="$(PTXCONF_SYSROOT_HOST)/bin/tic"
> > > -
> > > -NCURSES_AUTOCONF_SHARED := \
> > 
> > NCURSES_AUTOCONF_SHARED is used by host-ncurses, so this is still needed in
> > some way.
> 
> Ah, I overlooked that. Shall I sent v2 patch or you fixed it already?

I haven't fixed this. Please fix this in v2.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de