mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] libjpeg-turbo and libjpeg
Date: Tue, 13 Feb 2018 16:37:42 +0100	[thread overview]
Message-ID: <20180213153742.iljambtbf7g2v6fd@pengutronix.de> (raw)
In-Reply-To: <CABDcavYxytwEnGTp04DWoD30ZKMg4fT6NsoQBp42GcwG6gPV=Q@mail.gmail.com>

Hi,

On Tue, Feb 13, 2018 at 10:23:09AM +0100, Guillermo Rodriguez Garcia wrote:
> I need to use libjpeg-turbo for some apps that rely on specific
> libjpeg-turbo extensions that are not available in the standard (IJG's)
> libjpeg library. So I started to create a set of ptxdist rules for
> libjpeg-turbo.
> 
> libjpeg-turbo is supposed to provide a drop-in replacement for the standard
> IJG's libjpeg, and in fact many Linux distributions have already switched
> to it. So most packages that currently depend on LIBJPEG should be able to
> use libjpeg-turbo as well without any changes.
> 
> Example: gst-plugins-good1.in currently does the following:
> 
> select LIBJPEG if GST_PLUGINS_GOOD1_JPEG
> 
> However, gst-plugins-good1 should work just fine with libjpeg-turbo as
> well. In fact the upstream gst-plugins already switched to libjpeg-turbo
> some time ago (see the Cerbero scripts)
> 
> So, what is the recommended way to approach this in ptxdist? I can imagine
> some options:
> 
> 1. Provide a separate set of .in/.make files for libjpeg-turbo and a
> separate LIBJPEG_TURBO package. So new packages that want to use
> libjpeg-turbo would need to explicitly select LIBJPEG_TURBO (instead of
> LIBJPEG). But this means that packages that currently use libjpeg would not
> be able to benefit from the performance improvements in libjpeg-turbo. Also
> I am not sure whether these two libraries (libjpeg and libjpeg-turbo) can
> actually coexist in the same system.

No.

> 2. Modify the LIBJPEG rules to provide an option to select between the
> standard (IJG) libjpeg, or libjpeg-turbo. This would be similar to what is
> done in alsa.in/alsa.make to select between the "full" and "light" versions
> of the library.

Either this ...

> 3. Other?

... or change the libjpeg rule to always build libjpeg-turbo instead.

I would prefer to avoid an option. But I'm not sure
1. if there are use-cases where libjpeg is preferable
2. if there are packages that fail to build with libjpeg-turbo

I have some libjpeg-turbo stuff lying around here somewhere. It was just
never finished. I've just dumped it in my test BSP so see if anythings
fails to build. I'll report the result later.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2018-02-13 15:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-13  9:23 Guillermo Rodriguez Garcia
2018-02-13 15:37 ` Michael Olbrich [this message]
2018-02-13 16:12   ` Guillermo Rodriguez Garcia
2018-02-14  7:49     ` Michael Olbrich
2018-02-14  9:22       ` Guillermo Rodriguez Garcia
2018-02-14  9:57         ` Guillermo Rodriguez Garcia
2018-02-14 11:44           ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180213153742.iljambtbf7g2v6fd@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox