mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] bash: add creation of /usr/bin/sh link
Date: Thu, 8 Feb 2018 10:25:53 +0100	[thread overview]
Message-ID: <20180208092553.vwltp4wjtcywz2kg@pengutronix.de> (raw)
In-Reply-To: <20180207221300.27905-1-mail@schmidt-andreas.de>

On Wed, Feb 07, 2018 at 11:13:00PM +0100, Andreas Schmidt wrote:
> If bash is selected, but busybox not, no /usr/bin/sh will create.
> This patch add possibility to do this.
> 
> Signed-off-by: Andreas Schmidt <mail@schmidt-andreas.de>
> ---
>  rules/bash.in   | 10 ++++++++++
>  rules/bash.make |  3 +++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/rules/bash.in b/rules/bash.in
> index b902dfbc7..42f0bb420 100644
> --- a/rules/bash.in
> +++ b/rules/bash.in
> @@ -261,4 +261,14 @@ config BASH_CURSES
>  	bool
>  	prompt "Use libcurses instead of libtermcap"
>  
> +if !BUSYBOX && BUSYBOX != m
> +
> +config BASH_SH
> +	bool
> +	prompt "sh"
> +	help
> +	  Choose bash to be the shell executed by 'sh' name.
> +
> +endif

I think we should always provide the 'sh' link

config BASH_SH
	bool
	default BUSYBOX = n || BUSYBOX_SH_IS_NONE

> +
>  endif
> diff --git a/rules/bash.make b/rules/bash.make
> index 39a6b05fd..8228688f9 100644
> --- a/rules/bash.make
> +++ b/rules/bash.make
> @@ -98,6 +98,9 @@ $(STATEDIR)/bash.targetinstall:
>  ifdef PTXCONF_BUSYBOX_SH_IS_NONE
>  	@$(call install_link, bash, bash, /usr/bin/sh)
>  endif

... and then remove this ...

> +ifdef PTXCONF_BASH_SH
> +	@$(call install_link, bash, bash, /usr/bin/sh)
> +endif

... and add this

Michael

>  
>  	@$(call install_finish, bash)
>  
> -- 
> 2.16.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

      reply	other threads:[~2018-02-08  9:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-07 22:13 Andreas Schmidt
2018-02-08  9:25 ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180208092553.vwltp4wjtcywz2kg@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox