From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 1/1] host-lz4: Do not build a target binary
Date: Thu, 1 Feb 2018 12:21:32 +0100 [thread overview]
Message-ID: <20180201112132.knq7f22lx5vwmad6@pengutronix.de> (raw)
In-Reply-To: <20180201072801.14610-1-alexander.stein@systec-electronic.com>
On Thu, Feb 01, 2018 at 08:28:01AM +0100, Alexander Stein wrote:
> Using $(CROSS_ENV) results in a target binary, which is obviously wrong
> for a host tool.
> $ file platform-sdcard/sysroot-host/bin/lz4
> platform-sdcard/sysroot-host/bin/lz4: ELF 32-bit LSB executable, ARM,
> EABI5 version 1 (SYSV), dynamically linked,
> interpreter /lib/ld-linux-armhf.so.3, for GNU/Linux 3.0.0, with debug_info,
> not stripped
>
> Using the plain environment for building the host tool fixes this.
Indeed. I have no idea why we didn't notice this before.
Michael
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
> rules/host-lz4.make | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rules/host-lz4.make b/rules/host-lz4.make
> index 8c8ed4cd3..6fa9040f9 100644
> --- a/rules/host-lz4.make
> +++ b/rules/host-lz4.make
> @@ -18,7 +18,7 @@ HOST_PACKAGES-$(PTXCONF_HOST_LZ4) += host-lz4
> # ----------------------------------------------------------------------------
>
> HOST_LZ4_CONF_TOOL := NO
> -HOST_LZ4_MAKE_ENV := $(CROSS_ENV) PREFIX=
> +HOST_LZ4_MAKE_ENV := PREFIX=
> HOST_LZ4_MAKE_OPT := BUILD_STATIC=no lz4
> HOST_LZ4_INSTALL_OPT := BUILD_STATIC=no install
>
> --
> 2.13.6
>
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2018-02-01 11:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 7:28 Alexander Stein
2018-02-01 11:21 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180201112132.knq7f22lx5vwmad6@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox