* [ptxdist] [PATCH 1/1] host-lz4: Do not build a target binary
@ 2018-02-01 7:28 Alexander Stein
2018-02-01 11:21 ` Michael Olbrich
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Stein @ 2018-02-01 7:28 UTC (permalink / raw)
To: ptxdist; +Cc: Alexander Stein
Using $(CROSS_ENV) results in a target binary, which is obviously wrong
for a host tool.
$ file platform-sdcard/sysroot-host/bin/lz4
platform-sdcard/sysroot-host/bin/lz4: ELF 32-bit LSB executable, ARM,
EABI5 version 1 (SYSV), dynamically linked,
interpreter /lib/ld-linux-armhf.so.3, for GNU/Linux 3.0.0, with debug_info,
not stripped
Using the plain environment for building the host tool fixes this.
Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
---
rules/host-lz4.make | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rules/host-lz4.make b/rules/host-lz4.make
index 8c8ed4cd3..6fa9040f9 100644
--- a/rules/host-lz4.make
+++ b/rules/host-lz4.make
@@ -18,7 +18,7 @@ HOST_PACKAGES-$(PTXCONF_HOST_LZ4) += host-lz4
# ----------------------------------------------------------------------------
HOST_LZ4_CONF_TOOL := NO
-HOST_LZ4_MAKE_ENV := $(CROSS_ENV) PREFIX=
+HOST_LZ4_MAKE_ENV := PREFIX=
HOST_LZ4_MAKE_OPT := BUILD_STATIC=no lz4
HOST_LZ4_INSTALL_OPT := BUILD_STATIC=no install
--
2.13.6
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [ptxdist] [PATCH 1/1] host-lz4: Do not build a target binary
2018-02-01 7:28 [ptxdist] [PATCH 1/1] host-lz4: Do not build a target binary Alexander Stein
@ 2018-02-01 11:21 ` Michael Olbrich
0 siblings, 0 replies; 2+ messages in thread
From: Michael Olbrich @ 2018-02-01 11:21 UTC (permalink / raw)
To: ptxdist
On Thu, Feb 01, 2018 at 08:28:01AM +0100, Alexander Stein wrote:
> Using $(CROSS_ENV) results in a target binary, which is obviously wrong
> for a host tool.
> $ file platform-sdcard/sysroot-host/bin/lz4
> platform-sdcard/sysroot-host/bin/lz4: ELF 32-bit LSB executable, ARM,
> EABI5 version 1 (SYSV), dynamically linked,
> interpreter /lib/ld-linux-armhf.so.3, for GNU/Linux 3.0.0, with debug_info,
> not stripped
>
> Using the plain environment for building the host tool fixes this.
Indeed. I have no idea why we didn't notice this before.
Michael
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
> rules/host-lz4.make | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rules/host-lz4.make b/rules/host-lz4.make
> index 8c8ed4cd3..6fa9040f9 100644
> --- a/rules/host-lz4.make
> +++ b/rules/host-lz4.make
> @@ -18,7 +18,7 @@ HOST_PACKAGES-$(PTXCONF_HOST_LZ4) += host-lz4
> # ----------------------------------------------------------------------------
>
> HOST_LZ4_CONF_TOOL := NO
> -HOST_LZ4_MAKE_ENV := $(CROSS_ENV) PREFIX=
> +HOST_LZ4_MAKE_ENV := PREFIX=
> HOST_LZ4_MAKE_OPT := BUILD_STATIC=no lz4
> HOST_LZ4_INSTALL_OPT := BUILD_STATIC=no install
>
> --
> 2.13.6
>
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-01 11:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-01 7:28 [ptxdist] [PATCH 1/1] host-lz4: Do not build a target binary Alexander Stein
2018-02-01 11:21 ` Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox