[ptxdist] [PATCH] iptables: remove dependency on KERNEL_HEADERS

[ptxdist] [PATCH] iptables: remove dependency on KERNEL_HEADERS

[Oleksij Rempel]

with latest toolchain iptables will build with KERNEL_HEADERS

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 rules/iptables.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/rules/iptables.in b/rules/iptables.in
index 0c4ded12a..3cad506d0 100644
--- a/rules/iptables.in
+++ b/rules/iptables.in
@@ -3,7 +3,6 @@
 menuconfig IPTABLES
 	tristate
 	prompt "iptables                      "
-	select KERNEL_HEADER
 	select LIBC_M
 	select LIBC_DL
 	select GCCLIBS_GCC_S
-- 
2.11.0


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] iptables: remove dependency on KERNEL_HEADERS

[Roland Hieber]

On 28.11.2017 11:58, Oleksij Rempel wrote:
> with latest toolchain iptables will build with KERNEL_HEADERS

Sorry, that commit message is not clear to me. If it builds with 
KERNEL_HEADERS, why do you remove it?

Also you should probably capitalize the first character of a line :)

  - Roland

> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>   rules/iptables.in | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/rules/iptables.in b/rules/iptables.in
> index 0c4ded12a..3cad506d0 100644
> --- a/rules/iptables.in
> +++ b/rules/iptables.in
> @@ -3,7 +3,6 @@
>   menuconfig IPTABLES
>   	tristate
>   	prompt "iptables                      "
> -	select KERNEL_HEADER
>   	select LIBC_M
>   	select LIBC_DL
>   	select GCCLIBS_GCC_S
> 

-- 
Pengutronix e.K.                  | Roland Hieber               |
Industrial Linux Solutions        | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] iptables: remove dependency on KERNEL_HEADERS

[Michael Olbrich]

On Tue, Nov 28, 2017 at 12:18:01PM +0100, Roland Hieber wrote:
> On 28.11.2017 11:58, Oleksij Rempel wrote:
> > with latest toolchain iptables will build with KERNEL_HEADERS
> 
> Sorry, that commit message is not clear to me. If it builds with
> KERNEL_HEADERS, why do you remove it?
> 
> Also you should probably capitalize the first character of a line :)

It builds with the kernel headers from the toolchain, so KERNEL_HEADERS is
no longer needed. I've improved the commit message when I added it to my
local patch queue.

Michael

>  - Roland
> 
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> >   rules/iptables.in | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/rules/iptables.in b/rules/iptables.in
> > index 0c4ded12a..3cad506d0 100644
> > --- a/rules/iptables.in
> > +++ b/rules/iptables.in
> > @@ -3,7 +3,6 @@
> >   menuconfig IPTABLES
> >   	tristate
> >   	prompt "iptables                      "
> > -	select KERNEL_HEADER
> >   	select LIBC_M
> >   	select LIBC_DL
> >   	select GCCLIBS_GCC_S
> > 
> 
> -- 
> Pengutronix e.K.                  | Roland Hieber               |
> Industrial Linux Solutions        | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
> Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de