From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] iptables: remove dependency on KERNEL_HEADERS
Date: Tue, 28 Nov 2017 14:32:44 +0100 [thread overview]
Message-ID: <20171128133244.iwdnn6tlj2h77tly@pengutronix.de> (raw)
In-Reply-To: <da8c7186-7ca8-1d93-fa33-71e49cf378c0@pengutronix.de>
On Tue, Nov 28, 2017 at 12:18:01PM +0100, Roland Hieber wrote:
> On 28.11.2017 11:58, Oleksij Rempel wrote:
> > with latest toolchain iptables will build with KERNEL_HEADERS
>
> Sorry, that commit message is not clear to me. If it builds with
> KERNEL_HEADERS, why do you remove it?
>
> Also you should probably capitalize the first character of a line :)
It builds with the kernel headers from the toolchain, so KERNEL_HEADERS is
no longer needed. I've improved the commit message when I added it to my
local patch queue.
Michael
> - Roland
>
> >
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> > rules/iptables.in | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/rules/iptables.in b/rules/iptables.in
> > index 0c4ded12a..3cad506d0 100644
> > --- a/rules/iptables.in
> > +++ b/rules/iptables.in
> > @@ -3,7 +3,6 @@
> > menuconfig IPTABLES
> > tristate
> > prompt "iptables "
> > - select KERNEL_HEADER
> > select LIBC_M
> > select LIBC_DL
> > select GCCLIBS_GCC_S
> >
>
> --
> Pengutronix e.K. | Roland Hieber |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2017-11-28 13:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 10:58 Oleksij Rempel
2017-11-28 11:18 ` Roland Hieber
2017-11-28 13:32 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128133244.iwdnn6tlj2h77tly@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox