From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1eHTQx-0004Tw-0L for ptxdist@pengutronix.de; Wed, 22 Nov 2017 12:43:15 +0100 Received: from mgr by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1eHTQw-0000ph-OK for ptxdist@pengutronix.de; Wed, 22 Nov 2017 12:43:14 +0100 Date: Wed, 22 Nov 2017 12:43:14 +0100 From: Michael Grzeschik Message-ID: <20171122114314.5tquoe5odj74wfeg@pengutronix.de> References: <20170911124711.20926-1-m.grzeschik@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <20170911124711.20926-1-m.grzeschik@pengutronix.de> Subject: Re: [ptxdist] [PATCH v2] linuxptp: Update package and configs List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: multipart/mixed; boundary="===============1391463282==" Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de --===============1391463282== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5v2k7pjzx5x7opru" Content-Disposition: inline --5v2k7pjzx5x7opru Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 11, 2017 at 02:47:11PM +0200, Michael Grzeschik wrote: > Usualy we can not ensure only to use transparent clock switches. > Therefor we setup the fix option -P to the commandline to enable > the P2P mechanism in ptp4l. >=20 > The following options are highly depending on the usecase > so we remove them for the defaults. >=20 > path_trace_enabled > follow_up_info > tx_timestamp_timeout >=20 > With all other options were simple defaults the whole > config can be removed. >=20 > We also add some service files to start the ptp4l service on > dev eth0. In case the ptp4l daemon is configured > we add the option to install the phc2sys daemon to adjust the > system time by ptp. >=20 > Signed-off-by: Michael Grzeschik > --- > v1 -> v2: - removed install stage for gPTP.conf from rules file > - limited to run ptp4l only on eth0 for the default setup case >=20 > projectroot/etc/gPTP.conf | 28 ----------------= ------ > projectroot/usr/lib/systemd/system/phc2sys.service | 10 ++++++++ > projectroot/usr/lib/systemd/system/ptp4l@.service | 12 ++++++++++ > rules/linuxptp.in | 12 ++++++++++ > rules/linuxptp.make | 20 +++++++++++++--- > 5 files changed, 51 insertions(+), 31 deletions(-) > delete mode 100644 projectroot/etc/gPTP.conf > create mode 100644 projectroot/usr/lib/systemd/system/phc2sys.service > create mode 100644 projectroot/usr/lib/systemd/system/ptp4l@.service >=20 > diff --git a/projectroot/etc/gPTP.conf b/projectroot/etc/gPTP.conf > deleted file mode 100644 > index 5bbbaf288..000000000 > --- a/projectroot/etc/gPTP.conf > +++ /dev/null > @@ -1,28 +0,0 @@ > -[global] > -# > -# Run time options > -# > -assume_two_step 1 > -logging_level 6 > -path_trace_enabled 1 > -follow_up_info 1 > -tx_timestamp_timeout 40 > -use_syslog 1 > -verbose 0 > -summary_interval 0 > -# > -# Transport options > -# > -transportSpecific 0x1 > -ptp_dst_mac 01:80:C2:00:00:0E > -p2p_dst_mac 01:80:C2:00:00:0E > -uds_address /var/run/ptp4l > -# > -# Default interface options > -# > -network_transport L2 > -delay_mechanism P2P > -time_stamping hardware > - > -[eth0] > - > diff --git a/projectroot/usr/lib/systemd/system/phc2sys.service b/project= root/usr/lib/systemd/system/phc2sys.service > new file mode 100644 > index 000000000..eb8e57037 > --- /dev/null > +++ b/projectroot/usr/lib/systemd/system/phc2sys.service > @@ -0,0 +1,10 @@ > +[Unit] > +Description=3DPrecision Time Protocol system clock synchronization > +Wants=3Dptp4l@.service > + > +[Service] > +ExecStart=3D/usr/sbin/phc2sys -a -r -r The second -r is wrong here. It only makes sense if we want to synchronise the phc clock to the systemclock. And that only is valid if we can ensure to have a valid systemclock i.e. by ntp. The usual case should be to synchronise the systemclock by one grandmaster clock in the network, which we are not serving. > +Restart=3Dalways > + > +[Install] > +WantedBy=3Dmulti-user.target > diff --git a/projectroot/usr/lib/systemd/system/ptp4l@.service b/projectr= oot/usr/lib/systemd/system/ptp4l@.service > new file mode 100644 > index 000000000..7cd00dc45 > --- /dev/null > +++ b/projectroot/usr/lib/systemd/system/ptp4l@.service > @@ -0,0 +1,12 @@ > +[Unit] > +Description=3DPrecision Time Protocol (PTP) service > +BindsTo =3D sys-subsystem-net-devices-%i.device > +After =3D sys-subsystem-net-devices-%i.device > + > +[Service] > +Type=3Dsimple > +ExecStart=3D/usr/sbin/ptp4l -P -i %i > +Restart=3Dalways > + The usual case should be only to run this on eth0 for the default rule. I will change it in v3 to -i eth0. > +[Install] > +WantedBy=3Dmulti-user.target > diff --git a/rules/linuxptp.in b/rules/linuxptp.in > index 641d844c7..5418d2ad0 100644 > --- a/rules/linuxptp.in > +++ b/rules/linuxptp.in > @@ -7,3 +7,15 @@ config LINUXPTP > The Linux PTP project implements the Precision Time protocol (PTP), > standardized as IEEE1588. > =20 > +if LINUXPTP > + > +config LINUXPTP_SYSTEMD_SERVICE > + bool "install ptp4l and phc2sys systemd service files" > + default y > + > +config LINUXPTP_PHC2SYS_SYSTEMD_SERVICE > + bool "Enable phc2sys systemd service file" > + default y > + depends on LINUXPTP_SYSTEMD_SERVICE > + > +endif > diff --git a/rules/linuxptp.make b/rules/linuxptp.make > index 59cbb5123..6cfc0823d 100644 > --- a/rules/linuxptp.make > +++ b/rules/linuxptp.make > @@ -17,8 +17,8 @@ PACKAGES-$(PTXCONF_LINUXPTP) +=3D linuxptp > # > # Paths and names > # > -LINUXPTP_VERSION :=3D 1.6 > -LINUXPTP_MD5 :=3D 6aa15d83f5a35f1fd076ba9adc4e7285 > +LINUXPTP_VERSION :=3D 1.8 > +LINUXPTP_MD5 :=3D 5688cdfe57932273e1dbf35b3b97b9a0 > LINUXPTP :=3D linuxptp-$(LINUXPTP_VERSION) > LINUXPTP_SUFFIX :=3D tgz > LINUXPTP_URL :=3D $(call ptx/mirror, SF, linuxptp/$(LINUXPTP).$(LINUXPT= P_SUFFIX)) > @@ -64,7 +64,21 @@ $(STATEDIR)/linuxptp.targetinstall: > @$(call install_copy, linuxptp, 0, 0, 0755, -, /usr/sbin/phc2sys) > @$(call install_copy, linuxptp, 0, 0, 0755, -, /usr/sbin/pmc) > @$(call install_copy, linuxptp, 0, 0, 0755, -, /usr/sbin/hwstamp_ctl) > - @$(call install_alternative, linuxptp, 0, 0, 0644, /etc/gPTP.conf) > + @$(call install_copy, linuxptp, 0, 0, 0755, -, /usr/sbin/phc_ctl) > + @$(call install_copy, linuxptp, 0, 0, 0755, -, /usr/sbin/timemaster) > + > +ifdef PTXCONF_LINUXPTP_SYSTEMD_SERVICE > + @$(call install_alternative, linuxptp, 0, 0, 0644, /usr/lib/systemd/sys= tem/ptp4l@.service) This will be changed to: @$(call install_alternative, linuxptp, 0, 0, 0644, /usr/lib/systemd/system= /ptp4l.service) > + @$(call install_alternative, linuxptp, 0, 0, 0644, /usr/lib/systemd/sys= tem/phc2sys.service) > + > + $(call install_link, linuxptp, ../ptp4l@.service, \ > + /usr/lib/systemd/system/multi-user.target.wants/ptp4l@$eth0.service) This will be changed to: $(call install_link, linuxptp, ../ptp4l.service, \ /usr/lib/systemd/system/multi-user.target.wants/ptp4l.service) > + > +ifdef PTXCONF_LINUXPTP_PHC2SYS_SYSTEMD_SERVICE > + @$(call install_link, linuxptp, ../phc2sys.service, \ > + /usr/lib/systemd/system/multi-user.target.wants/phc2sys.service) > +endif > +endif > =20 > @$(call install_finish, linuxptp) > =20 > --=20 > 2.11.0 Thanks, Michael --=20 Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --5v2k7pjzx5x7opru Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEElXvEUs6VPX6mDPT8C+njFXoeLGQFAloVYssACgkQC+njFXoe LGTNFhAAq8UslQuZ15Y2HSV1zQ9AOPsux3jYIvwz/jI/29ViqriZKO4xtvmqdO6i C7zG3Cvmn/3/9DCTquh1wRknDOQLfPB747MVTFVuFBlNBv7gwmG+rRYCKicFIzS1 XMeOHNhDjZNd+ICGxRgC3EvS4Rb8dPf9fC7SOCNJNUrQUZexcvIWmi8AY+cnu11H gcDqPFPv0a4eW0Cl1mgkqCTWKABMRVVnk6ngjZI8qSZZTBiyRbB3A36eb0kh/FHG 2UEscyvIttEDfcYL6c77QCOc2bdBhswVfXtQM+J2B/q1XfZdrY2wDe+ow54Bk4Qs 3cIEcYAnTx1A3vsta148Ws+Z3yNa3lJFThVIkt+HjsG1Ft0pqaSYcAKsew/hmgwV fq2cLNHQdq2DTgzTT/eVac6AYeLJ4VHrXvrbsHIW8dde4GQy/RS76YMACHWxfv7K ydQH2d+UiWJw24Ed/Q5pTzLETG807OvYdoWZzYUPXSo55PhFMfan+jihzUUpjsiv lwrxJilHuNf0xZ6BFegNjmdkS2YPqRBTM3EYZl6V6bRZxrSKzFcLJZDTmNNaKd3G rGrOwhOTJn8YB8zJkUBHJvEfiYjox9YnVYfSnCV/h6LJoCqwnR57e1cVGASP79Mc k/3k2t9S48BUb/+grlClHowS0KTIJLkNh9K1+pw1TJ5lZxOP1QU= =ZH+t -----END PGP SIGNATURE----- --5v2k7pjzx5x7opru-- --===============1391463282== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KcHR4ZGlzdCBt YWlsaW5nIGxpc3QKcHR4ZGlzdEBwZW5ndXRyb25peC5kZQ== --===============1391463282==--