Re: [ptxdist] [PATCH v3 5/7] cups: new package: Common Unix Printing System

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Tue, Oct 31, 2017 at 11:31:45PM +0100, Roland Hieber wrote:
> On 27.10.2017 19:54, Michael Olbrich wrote:
> > On Wed, Oct 25, 2017 at 10:57:49PM +0200, Roland Hieber wrote:
> >> diff --git a/rules/cups.in b/rules/cups.in
> >> new file mode 100644
> >> index 000000000..13b7142d6
> >> --- /dev/null
> >> +++ b/rules/cups.in
> >> @@ -0,0 +1,113 @@
> >> +## SECTION=applications
> >> +
> >> +menuconfig CUPS
> >> +	tristate
> >> +	prompt "cups                          "
> >> +
> >> +	select ROOTFS_VAR_LOG
> >> +	select ROOTFS_VAR_RUN
> >> +	select LIBC_M
> >> +	select LIBC_CRYPT
> >> +	select ZLIB
> >> +
> >> +	select LIBC_PTHREAD		if CUPS_THREADING
> >> +	select SYSTEMD			if CUPS_SYSTEMD_UNIT
> >> +	select LIBPAPER			if CUPS_LIBPAPER
> >> +	select LIBUSB			if CUPS_LIBUSB
> >> +	select DBUS			if CUPS_DBUS
> >> +	select GNUTLS			if CUPS_SSL
> >> +	select AVAHI			if CUPS_AVAHI
> >> +	select AVAHI_LIBAVAHI_CLIENT	if CUPS_AVAHI
> >> +	select ORACLE_JAVA7_JRE		if CUPS_JAVA
> > 
> > This is not good. ORACLE_JAVA7_JRE is the x86-only binary packages.
> > Just add a comment to the help text, that some java is needed.
> > 
> >> +	select PERL			if CUPS_PERL
> >> +	select PHP5			if CUPS_PHP
> >> +	select PYTHON			if CUPS_PYTHON
> > 
> > Is python2 the only option or could python3 be used as well?
> 
> Python 3 is possible. But I have to pass the path to the executable to
> CUPS' configure, so I would need to reconfigure CUPS if anything of
> PYTHON || PYTHON3 || PYTHON3_SYMLINK changes. Is there a way to ensure
> this? Same for PHP5_CGI || PHP5_CLI.

If really works with both, then I'd say, make it a choice (2/3/no) and
/usr/bin/python{2,3} explicitly.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de