Re: [ptxdist] kernel prepare stage creates extra series file

[Michael Olbrich <m.olbrich@pengutronix.de>]

Hi,

On Mon, Oct 16, 2017 at 03:26:35PM +0200, Alexander Dahl wrote:
> (What I didn't mention before: the BSP is on ptxdist 2017.09.0.)
> 
> Am Montag, 16. Oktober 2017, 14:40:51 CEST schrieb Michael Olbrich:
> > The only place ptxdist creates a series file, is, when it cannot find one
> > (This is in scripts/lib/ptxd_make_world_patchin.sh line 282). In that case,
> > you should see a warning, when it is created. Maybe PTXCONF_KERNEL_SERIES
> > is not set correctly?
> 
> This is set to: series${PTXDIST_PLATFORMSUFFIX}
> 
> So:
> 
> 	$ p print PTXDIST_PLATFORMSUFFIX 
> 	.at91foo
> 	$ p print PTXCONF_KERNEL_SERIES 
> 	"series.at91foo"
> 	$ ls -l patches/linux-4.9.47/series.at91foo 
> 	-rw-r--r-- 1 adahl adahl 18229 Sep 29 11:33 patches/linux-4.9.47/
> series.at91foo
> 
> If I just drop the kernel prepare stage and execute it again, this 'series' 
> file is not created.
> 
> But, what I found, after you mentioned this warning, which should come:
> 
> 	-----------------------------
> 	target: kernel-header.extract
> 	-----------------------------
> 
> 	extract: pkg_src=/home/adahl/[…]/linux-4.9.47.tar.xz
> 	extract: pkg_extract_dir=XXX/platform-at91foo/build-target/kernel-
> header-4.9.47
> 	ptxdist: error: series file for 'XXX/patches/linux-4.9.47' is missing
> 
> There's no option to the set the series file for the kernel header package, 
> like for the kernel package.
> 
> As a workaround: I looked which selects the kernel-header package here and it 
> seems it is only oprofile, which I only need for debugging. So for now I 
> deactivate the kernel header package, which circumvents my initial problem, 
> this also saves quite some build time. :-)
> 
> Would still be interesting to look, why the kernel-header package ignores the 
> right series file somehow, and creates a new one which applies the same 
> patches.

For the most part, the kernel-header is intended to provide new versions of
the kernel headers if those from the toolchain are too old. So it should be
mostly platform independent. That's why you can set the version separately
from the kernel.
The kernel ABI is pretty stable, so a older version than the kernel is
usually not a problem.

In your case I can see two solutions:
1. Move the patches to configs/platform-XXX/patches/linux-4.9.47/ and just
   use 'series'.
2. Use a slightly different version for the kernel-header package(e.g.
   4.9.46) so it wont share the patches. Unless your patches change
   something needed for oprofile?

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de