mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Juergen Borleis <jbe@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Michael Olbrich <m.olbrich@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] iptables: fix large file support
Date: Wed, 4 Oct 2017 11:01:35 +0200	[thread overview]
Message-ID: <201710041101.35265.jbe@pengutronix.de> (raw)
In-Reply-To: <20170930103430.uike6eidusohtmur@pengutronix.de>

Hi Michael,

On Saturday 30 September 2017 12:34:30 Michael Olbrich wrote:
> On Thu, Sep 28, 2017 at 11:00:43AM +0200, Juergen Borleis wrote:
> > The configure script handles the "--*-largefile" parameter badly. It
> > defaults to large file support if not given and always disables
> > largefile support if given (and it doesn't matter if 'enable' or
> > 'disable' was used)
>
> IPTABLES_CFLAGS:= -D_FILE_OFFSET_BITS=64
>
> Should be removed, right?
>
> The version bump should be noted in the commit messsage.
>
> > Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
> > ---
> >  ...d-xtables-config-parser.h-to-BUILT_SOURCE.patch | 34
> > ----------------------
>
> Is this no longer needed? If so, add a comment.

Ups, sorry. V2 will follow.

Cheers,
Jürgen

-- 
Pengutronix e.K.                             | Juergen Borleis             |
Industrial Linux Solutions                   | http://www.pengutronix.de/  |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

      reply	other threads:[~2017-10-04  9:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-28  9:00 Juergen Borleis
2017-09-30 10:34 ` Michael Olbrich
2017-10-04  9:01   ` Juergen Borleis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201710041101.35265.jbe@pengutronix.de \
    --to=jbe@pengutronix.de \
    --cc=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox