Re: [ptxdist] [PATCH 6/7] host-cups: new package: CUPS PPD compiler

[Juergen Borleis <jbe@pengutronix.de>]

Hi Roland,

On Thursday 24 August 2017 00:39:10 Roland Hieber wrote:
> [...]
> +#
> +# autoconf
> +#
> +# The --with-* options are only used to specify strings, --without-* does
> +# nothing. So we're omitting them here. The only exception is 
> +# --with-components=core, which we are setting to only builds libcups* (which is
> +# needed by ppdc). 
> +#
> +# We have to set --exec-prefix and --libdir, otherwise the libs end up
> in +# ${prefix}/lib64, which is not what we want.
> +#
> +HOST_CUPS_CONF_TOOL	:= autoconf
> +HOST_CUPS_CONF_OPT	:= \
> +	$(HOST_AUTOCONF) \
> +	--exec-prefix=/usr/ \
> +	--libdir=/usr/lib/ \

It seems "$(HOST_AUTOCONF)" and "--libdir=/lib" is enough. And installing to
"$(PTXDIST_SYSROOT_HOST)/bin" and "$(PTXDIST_SYSROOT_HOST)/lib" is handled
by PTXdist automatically (library search path handling and so on).

> [...]
> +
> +CROSS_PPDC = $(PTXDIST_SYSROOT_CROSS)/bin/ppdc
> +$(STATEDIR)/host-cups.install.post:
> +	@$(call targetinfo)
> +	@$(call world/install.post, HOST_CUPS)
> +
> +	( \
> +		echo '#!/bin/sh'; \
> +		echo 'LD_LIBRARY_PATH=$(PTXDIST_SYSROOT_HOST)/usr/lib $(PTXDIST_SYSROOT_HOST)/usr/bin/ppdc -I $(SYSROOT)/usr/share/cups/ppdc "$$@"'; \
> +	) > $(CROSS_PPDC)

You should not mix "$(PTXDIST_SYSROOT_HOST)" and "$(SYSROOT)" here, because
then the "HOST-CUPS" package has a dependency to "CUPS"!

When you install to "$(PTXDIST_SYSROOT_HOST)/bin" and
"$(PTXDIST_SYSROOT_HOST)/lib" the cross-ppdc variant can be reduced to:

	( \
		echo '#!/bin/sh'; \
		echo $(PTXDIST_SYSROOT_HOST)/bin/ppdc -I $(PTXDIST_SYSROOT_HOST)/share/cups/ppdc "$$@"'; \
	) > $(CROSS_PPDC)

Cheers
Juergen

-- 
Pengutronix e.K.                             | Juergen Borleis             |
Industrial Linux Solutions                   | http://www.pengutronix.de/  |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de