mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: David Jander <david@protonic.nl>
To: jon@ringle.org
Cc: Jon Ringle <jringle@gridpoint.com>, ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] protobuf: version bump 3.3.1 -> 3.3.2
Date: Wed, 20 Sep 2017 16:19:50 +0200	[thread overview]
Message-ID: <20170920161950.3cf147d8@erd980> (raw)
In-Reply-To: <1501187475-1064-1-git-send-email-jon@ringle.org>


Dear Jon,

On Thu, 27 Jul 2017 16:31:15 -0400
jon@ringle.org wrote:

> From: Jon Ringle <jringle@gridpoint.com>
> 
> This fixes unused parameter 'deterministic' issue:
> src/backend-common/backend_ipc.pb.cc:32994:10: error: unused parameter 'deterministic' [-Werror=unused-parameter]
>      bool deterministic, ::google::protobuf::uint8* target) const {
>           ^
> 
> Signed-off-by: Jon Ringle <jringle@gridpoint.com>
> ---
>  patches/{protobuf-3.3.1 => protobuf-3.3.2}/autogen.sh | 0
>  rules/protobuf.make                                   | 4 ++--
>  2 files changed, 2 insertions(+), 2 deletions(-)
>  rename patches/{protobuf-3.3.1 => protobuf-3.3.2}/autogen.sh (100%)
> 
> diff --git a/patches/protobuf-3.3.1/autogen.sh b/patches/protobuf-3.3.2/autogen.sh
> similarity index 100%
> rename from patches/protobuf-3.3.1/autogen.sh
> rename to patches/protobuf-3.3.2/autogen.sh
> diff --git a/rules/protobuf.make b/rules/protobuf.make
> index 35d065b..97761d7 100644
> --- a/rules/protobuf.make
> +++ b/rules/protobuf.make
> @@ -16,8 +16,8 @@ PACKAGES-$(PTXCONF_PROTOBUF) += protobuf
>  #
>  # Paths and names
>  #
> -PROTOBUF_VERSION	:= 3.3.1
> -PROTOBUF_MD5		:= 20c685147753b515ce380421442044b5
> +PROTOBUF_VERSION	:= 3.3.2
> +PROTOBUF_MD5		:= 19ed45d0cbbb88de2c4922978235d314
>  PROTOBUF		:= protobuf-$(PROTOBUF_VERSION)
>  PROTOBUF_SUFFIX		:= tar.gz
>  PROTOBUF_URL		:= https://github.com/google/protobuf/archive/v$(PROTOBUF_VERSION).$(PROTOBUF_SUFFIX)

If I download protobuf-3.3.2 today from this URL, I get a different MD5sum:

$ md5sum src/protobuf-3.3.2.tar.gz 
ef2a6a6bb3b92d8fa8d71e3cef741f2f  src/protobuf-3.3.2.tar.gz

The contents of the file look very legit though (no accidental HTML error or
such). It definitely contains something very similar to your protobuf-3.3.2
AFAICS. Are github download archives MD5-stable? Am I opening some ugly can of
worms here, or is there some serious security issue going on?

Best regards,

-- 
David Jander
Protonic Holland.

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2017-09-20 14:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-27 20:31 jon
2017-09-20 14:19 ` David Jander [this message]
2017-09-22 13:50   ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170920161950.3cf147d8@erd980 \
    --to=david@protonic.nl \
    --cc=jon@ringle.org \
    --cc=jringle@gridpoint.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox