Re: [ptxdist] [PATCH] doc: pre-built packages: fix typos, enhance some formulations & occasionally add information

["Ulrich Ölmann" <u.oelmann@pengutronix.de>]

Hi Roland & list,

it took some time to come back to this finally...

On Wed, Jul 19, 2017 at 10:30:35AM +0200, Roland Hieber wrote:
> Some more changes you could include:
> 
> On 18.07.2017 15:27, Ulrich Ölmann wrote:
> > [...]
> > -PTXdist is a tool which creates all the required parts of a target’s
> > +PTXdist is a tool which creates all the required parts of a target's
> 
> Is there a reason why you changed Unicode quotation marks for ASCII
> apostrophes?

The english genitive uses just a simple apostrophe that is found easily on my
keyboard. Hence I try to consistently use it instead of special unicode
characters.

> > [...]
> >  the last run instead. This feature can drastically reduce the time to
> >  re-build the whole project. But also, this PTXdist feature must handle
> 
>                           while we're at it:  must be handled ----------^

Correct.

> > [...]
> > -A regular and save usecase of pre-build archives is:
> > +Sufficient conditions for save application of pre-built archives are:
> 
>                              ^--- should be "safe" (adj), not "save" (verb)

Yes.

> > [...]
> > +The hash as a part of the pre-built archive's filename does only reflect
> 
> My feeling for English would change this to "only reflects", less emphasis.

Changed.

> > [...]
> > +can decide on a package by package base if its pre-built archive should
> 
>                                       ^--- basis?

Replaced.

> > [...]
> > +Now its time to copy the pre-built archives to this new directory. We
> 
>        ^-- it's

Good catch.

> > +are under development, we must omit its corresponding pre-built archives
> 
>                                                                archive? --^

Changed to "we must omit THEIR corresponding pre-built archives".

> > [...]
> >      $ cp platform-<platformname>/packages/*-dev.tar.gz| /home/jbe/OSELAS.BSP/Pengutronix/OSELAS.BSP-Pengutronix-Generic
> 
>                                                          ^-- huh, why is there a pipe?

Removed.

>  - Roland

I will send a v2 of this patch split up into a handful of single more specific
patches.

Best regards
Ulrich
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de