From: Juergen Borleis <jbe@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Roland Hieber <r.hieber@pengutronix.de>
Subject: Re: [ptxdist] [PATCH 5/7] cups: new package: Common Unix Printing System
Date: Wed, 30 Aug 2017 10:42:10 +0200 [thread overview]
Message-ID: <201708301042.10695.jbe@pengutronix.de> (raw)
In-Reply-To: <20170823223911.13784-6-r.hieber@pengutronix.de>
Hi Roland,
On Thursday 24 August 2017 00:39:09 Roland Hieber wrote:
> [...]
> +$(STATEDIR)/cups.targetinstall:
> + @$(call targetinfo)
> +
> + @$(call install_init, cups)
> + @$(call install_fixup, cups,PRIORITY,optional)
> + @$(call install_fixup, cups,SECTION,base)
> + @$(call install_fixup, cups,AUTHOR,"Roland Hieber <r.hieber@pengutronix.de>")
> + @$(call install_fixup, cups,DESCRIPTION,missing)
> +
> +# ----- config files, install as daemon:lp
You should create "/etc/cups" explicitly, because it needs "daemon:lp" owners
as well.
> + @$(call install_alternative, cups, 1, 110, 0640, /etc/cups/cups-files.conf)
> + @$(call install_alternative, cups, 1, 110, 0640, /etc/cups/cupsd.conf)
> + @$(call install_alternative, cups, 1, 110, 0600, /etc/cups/classes.conf)
> + @$(call install_alternative, cups, 1, 110, 0600, /etc/cups/client.conf)
> + @$(call install_alternative, cups, 1, 110, 0640, /etc/cups/mailto.conf)
> + @$(call install_alternative_tree, cups, 1, 110, /etc/cups/ppd/)
The directory "/etc/cups/ppd" should also be owned by "daemon:lp", shouldn't it?
> + @$(call install_alternative, cups, 1, 110, 0600, /etc/cups/printers.conf)
> + @$(call install_alternative, cups, 1, 110, 0640, /etc/cups/snmp.conf)
> + @$(call install_alternative, cups, 1, 110, 0640, /etc/printcap)
> + @$(call install_alternative, cups, 1, 110, 0640, /usr/share/cups/mime/mime.convs)
Why not "root.root" for files in "/usr/share/cups"?
> + @$(call install_alternative, cups, 1, 110, 0640, /usr/share/cups/mime/mime.types)
Same here.
> +
> +ifdef PTXCONF_CUPS_SSL
> + @$(call install_alternative_tree, cups, 1, 110, /etc/cups/ssl/)
The directory "/etc/cups/ssl" should also be owned by "daemon:lp", shouldn't it?
> +endif
> [...]
Cheers, Juergen
--
Pengutronix e.K. | Juergen Borleis |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2017-08-30 8:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 22:39 [ptxdist] [PATCH 0/7] package (some of) the CUPS ecosystem Roland Hieber
2017-08-23 22:39 ` [ptxdist] [PATCH 1/7] libpaper: new package: system-wide papersize configuration Roland Hieber
2017-08-24 7:32 ` Juergen Borleis
2017-08-28 8:20 ` Roland Hieber
2017-08-28 9:47 ` Michael Olbrich
2017-08-23 22:39 ` [ptxdist] [PATCH 2/7] qpdf: new package: PDF inspection library and tools Roland Hieber
2017-08-28 9:52 ` Michael Olbrich
2017-09-11 10:11 ` Juergen Borleis
2017-09-22 10:00 ` Roland Hieber
2017-08-23 22:39 ` [ptxdist] [PATCH 3/7] poppler-data: new package: optional encoding data for poppler Roland Hieber
2017-08-28 9:54 ` Michael Olbrich
2017-08-23 22:39 ` [ptxdist] [PATCH 4/7] poppler: version bump 0.18.0 -> 0.57.0 Roland Hieber
2017-08-28 10:18 ` Michael Olbrich
2017-08-28 14:11 ` Roland Hieber
2017-08-29 8:43 ` Michael Olbrich
2017-08-23 22:39 ` [ptxdist] [PATCH 5/7] cups: new package: Common Unix Printing System Roland Hieber
2017-08-28 12:44 ` Juergen Borleis
2017-08-28 12:51 ` Michael Olbrich
2017-08-28 14:03 ` Roland Hieber
2017-08-29 8:40 ` Michael Olbrich
2017-09-27 8:16 ` Roland Hieber
2017-08-30 8:42 ` Juergen Borleis [this message]
2017-08-23 22:39 ` [ptxdist] [PATCH 6/7] host-cups: new package: CUPS PPD compiler Roland Hieber
2017-08-28 12:57 ` Michael Olbrich
2017-09-22 12:06 ` Juergen Borleis
2017-09-22 14:04 ` Michael Olbrich
2017-09-22 14:37 ` Roland Hieber
2017-08-23 22:39 ` [ptxdist] [PATCH 7/7] cups-filters: new package: additional filters and backends for CUPS Roland Hieber
2017-08-28 13:03 ` Michael Olbrich
2017-08-28 13:56 ` Roland Hieber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201708301042.10695.jbe@pengutronix.de \
--to=jbe@pengutronix.de \
--cc=ptxdist@pengutronix.de \
--cc=r.hieber@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox