Re: [ptxdist] [PATCH 4/7] poppler: version bump 0.18.0 -> 0.57.0

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Mon, Aug 28, 2017 at 04:11:18PM +0200, Roland Hieber wrote:
> On 28.08.2017 12:18, Michael Olbrich wrote:
> > On Thu, Aug 24, 2017 at 12:39:08AM +0200, Roland Hieber wrote:
> >> [...]
> > > +ifdef PTXCONF_POPPLER_SPLASH_FP
> > > +ifdef PTXCONF_POPPLER_SPLASH_FP_DOUBLE
> > > +POPPLER_CONF_OPT += \
> > > +	--disable-single-precision \
> > > +	--disable-fixedpoint
> > > +else # PTXCONF_POPPLER_SPLASH_FP && !PTXCONF_POPPLER_SPLASH_FP_DOUBLE
> > > +POPPLER_CONF_OPT += \
> > > +	--enable-single-precision \
> > > +	--disable-fixedpoint
> > > +endif
> > > +else # !PTXCONF_POPPLER_SPLASH_FP
> > > +POPPLER_CONF_OPT += \
> > > +	--disable-single-precision \
> > > +	--enable-fixedpoint
> > > +endif
> > 
> > Can't you use ptx/disen here? The single-precision option should be ignored
> > for fixedpoint, right?
> 
> No, ./configure --enable-fixedpoint --enable-single-precision is not
> accepted and fails. Is there a way to check for two separate variables
> inside ptx/disen?

No, but you could reverse the logic for the kconfig symbol. If you call it
POPPLER_SPLASH_FP_SINGLE combinded with ptx/endis, it should work as
expected. Just set 'default y' if single precision should be prefered.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de