mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 4/7] poppler: version bump 0.18.0 -> 0.57.0
Date: Tue, 29 Aug 2017 10:43:38 +0200	[thread overview]
Message-ID: <20170829084338.abtp5wl52rokkkjv@pengutronix.de> (raw)
In-Reply-To: <36b4833b-e05a-f5a6-7e52-920412bbdc6c@pengutronix.de>

On Mon, Aug 28, 2017 at 04:11:18PM +0200, Roland Hieber wrote:
> On 28.08.2017 12:18, Michael Olbrich wrote:
> > On Thu, Aug 24, 2017 at 12:39:08AM +0200, Roland Hieber wrote:
> >> [...]
> > > +ifdef PTXCONF_POPPLER_SPLASH_FP
> > > +ifdef PTXCONF_POPPLER_SPLASH_FP_DOUBLE
> > > +POPPLER_CONF_OPT += \
> > > +	--disable-single-precision \
> > > +	--disable-fixedpoint
> > > +else # PTXCONF_POPPLER_SPLASH_FP && !PTXCONF_POPPLER_SPLASH_FP_DOUBLE
> > > +POPPLER_CONF_OPT += \
> > > +	--enable-single-precision \
> > > +	--disable-fixedpoint
> > > +endif
> > > +else # !PTXCONF_POPPLER_SPLASH_FP
> > > +POPPLER_CONF_OPT += \
> > > +	--disable-single-precision \
> > > +	--enable-fixedpoint
> > > +endif
> > 
> > Can't you use ptx/disen here? The single-precision option should be ignored
> > for fixedpoint, right?
> 
> No, ./configure --enable-fixedpoint --enable-single-precision is not
> accepted and fails. Is there a way to check for two separate variables
> inside ptx/disen?

No, but you could reverse the logic for the kconfig symbol. If you call it
POPPLER_SPLASH_FP_SINGLE combinded with ptx/endis, it should work as
expected. Just set 'default y' if single precision should be prefered.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2017-08-29  8:43 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23 22:39 [ptxdist] [PATCH 0/7] package (some of) the CUPS ecosystem Roland Hieber
2017-08-23 22:39 ` [ptxdist] [PATCH 1/7] libpaper: new package: system-wide papersize configuration Roland Hieber
2017-08-24  7:32   ` Juergen Borleis
2017-08-28  8:20     ` Roland Hieber
2017-08-28  9:47   ` Michael Olbrich
2017-08-23 22:39 ` [ptxdist] [PATCH 2/7] qpdf: new package: PDF inspection library and tools Roland Hieber
2017-08-28  9:52   ` Michael Olbrich
2017-09-11 10:11   ` Juergen Borleis
2017-09-22 10:00     ` Roland Hieber
2017-08-23 22:39 ` [ptxdist] [PATCH 3/7] poppler-data: new package: optional encoding data for poppler Roland Hieber
2017-08-28  9:54   ` Michael Olbrich
2017-08-23 22:39 ` [ptxdist] [PATCH 4/7] poppler: version bump 0.18.0 -> 0.57.0 Roland Hieber
2017-08-28 10:18   ` Michael Olbrich
2017-08-28 14:11     ` Roland Hieber
2017-08-29  8:43       ` Michael Olbrich [this message]
2017-08-23 22:39 ` [ptxdist] [PATCH 5/7] cups: new package: Common Unix Printing System Roland Hieber
2017-08-28 12:44   ` Juergen Borleis
2017-08-28 12:51   ` Michael Olbrich
2017-08-28 14:03     ` Roland Hieber
2017-08-29  8:40       ` Michael Olbrich
2017-09-27  8:16     ` Roland Hieber
2017-08-30  8:42   ` Juergen Borleis
2017-08-23 22:39 ` [ptxdist] [PATCH 6/7] host-cups: new package: CUPS PPD compiler Roland Hieber
2017-08-28 12:57   ` Michael Olbrich
2017-09-22 12:06   ` Juergen Borleis
2017-09-22 14:04     ` Michael Olbrich
2017-09-22 14:37       ` Roland Hieber
2017-08-23 22:39 ` [ptxdist] [PATCH 7/7] cups-filters: new package: additional filters and backends for CUPS Roland Hieber
2017-08-28 13:03   ` Michael Olbrich
2017-08-28 13:56     ` Roland Hieber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170829084338.abtp5wl52rokkkjv@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox