Re: [ptxdist] [PATCH] qrencode: new package: library and tools for encoding QR codes

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Aug 11, 2017 at 02:38:37PM +0200, Roland Hieber wrote:
> 
> 
> On 11.08.2017 12:44, Roland Hieber wrote:
> > Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
> > ---
> >   rules/qrencode.in   | 31 +++++++++++++++++++++++++
> >   rules/qrencode.make | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> >   2 files changed, 98 insertions(+)
> >   create mode 100644 rules/qrencode.in
> >   create mode 100644 rules/qrencode.make
> > 
> > diff --git a/rules/qrencode.in b/rules/qrencode.in
> > new file mode 100644
> > index 00000000..70308ba7
> > --- /dev/null
> > +++ b/rules/qrencode.in
> > @@ -0,0 +1,31 @@
> > +## SECTION=system_libraries
> 
> Hmmm, thinking about this, it could also fit into SECTION=multimedia_libs or
> multimedia_tools. Thoughts?

use multimedia_tools.

> > +
> > +menuconfig QRENCODE
> > +	tristate
> > +	prompt "qrencode                      "
> > +	select LIBPNG		if QRENCODE_TOOLS
> > +	select LIBC_PTHREAD	if QRENCODE_PTHREAD
> > +	help
> > +	  Libqrencode is a C library for encoding data in a QR Code symbol, a
> > +	  kind of 2D symbology that can be scanned by handy terminals such as a
> > +	  mobile phone with CCD.
> > +
> > +if QRENCODE
> > +
> > +config QRENCODE_TOOLS
> > +	bool
> > +	default y
> > +	prompt "build tools"
> > +	help
> > +	  Enable this option to build the qrencode tool to build QR codes from
> > +	  the command line.
> > +
> > +config QRENCODE_PTHREAD
> > +	bool
> > +	default y
> > +	prompt "make library thread-safe"

Is there a reason to make this optional? I'd just enable it
unconditionally.

Michael

> > +
> > +endif
> > +
> > +
> > +# vim: ft=kconfig ts=8 noet tw=80
> > diff --git a/rules/qrencode.make b/rules/qrencode.make
> > new file mode 100644
> > index 00000000..bd4b5cd4
> > --- /dev/null
> > +++ b/rules/qrencode.make
> > @@ -0,0 +1,67 @@
> > +# -*-makefile-*-
> > +#
> > +# Copyright (C) 2017 by Roland Hieber <r.hieber@pengutronix.de>
> > +#
> > +# See CREDITS for details about who has contributed to this project.
> > +#
> > +# For further information about the PTXdist project and license conditions
> > +# see the README file.
> > +#
> > +
> > +#
> > +# We provide this package
> > +#
> > +PACKAGES-$(PTXCONF_QRENCODE) += qrencode
> > +
> > +#
> > +# Paths and names
> > +#
> > +QRENCODE_VERSION	:= 3.4.4
> > +QRENCODE_MD5		:= be545f3ce36ea8fbb58612d72c4222de
> > +QRENCODE		:= qrencode-$(QRENCODE_VERSION)
> > +QRENCODE_SUFFIX		:= tar.gz
> > +QRENCODE_URL		:= https://fukuchi.org/works/qrencode/$(QRENCODE).$(QRENCODE_SUFFIX)
> > +QRENCODE_SOURCE		:= $(SRCDIR)/$(QRENCODE).$(QRENCODE_SUFFIX)
> > +QRENCODE_DIR		:= $(BUILDDIR)/$(QRENCODE)
> > +QRENCODE_LICENSE	:= LGPL-2.1+
> > +
> > +# ----------------------------------------------------------------------------
> > +# Prepare
> > +# ----------------------------------------------------------------------------
> > +
> > +QRENCODE_CONF_TOOL	:= autoconf
> > +QRENCODE_CONF_OPT	:= \
> > +	$(CROSS_AUTOCONF_USR) \
> > +	--$(call ptx/endis,PTXCONF_QRENCODE_PTHREAD)-thread-safety \
> > +	--disable-sdltest \
> > +	--disable-rpath \
> > +	--disable-gprof \
> > +	--disable-gcov \
> > +	--disable-mudflap \
> > +	--$(call ptx/wwo,PTXCONF_QRENCODE_TOOLS)-tools \
> > +	--without-tests
> > +
> > +# ----------------------------------------------------------------------------
> > +# Target-Install
> > +# ----------------------------------------------------------------------------
> > +
> > +$(STATEDIR)/qrencode.targetinstall:
> > +	@$(call targetinfo)
> > +
> > +	@$(call install_init, qrencode)
> > +	@$(call install_fixup, qrencode,PRIORITY,optional)
> > +	@$(call install_fixup, qrencode,SECTION,base)
> > +	@$(call install_fixup, qrencode,AUTHOR,"Roland Hieber <r.hieber@pengutronix.de>")
> > +	@$(call install_fixup, qrencode,DESCRIPTION,missing)
> > +
> > +	@$(call install_lib, qrencode, 0, 0, 0644, libqrencode)
> > +
> > +ifdef PTXCONF_QRENCODE_TOOLS
> > +	@$(call install_copy, qrencode, 0, 0, 0755, -, /usr/bin/qrencode)
> > +endif
> > +
> > +	@$(call install_finish, qrencode)
> > +
> > +	@$(call touch)
> > +
> > +# vim: ft=make ts=8 noet tw=80
> > 
> 
> -- 
> Pengutronix e.K.                  | Roland Hieber               |
> Industrial Linux Solutions        | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
> Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de