Re: [ptxdist] [PATCH 4/4] lighttpd: Install mime.conf and remove hardcoded values

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Aug 11, 2017 at 12:00:26PM +0200, Alexander Dahl wrote:
> Hi,
> 
> Am Freitag, 11. August 2017, 10:04:02 schrieb Alexander Dahl:
> > +	@$(call targetinfo)
> > +	@cd $(LIGHTTPD_DIR) && \
> > +		$(LIGHTTPD_PATH) $(LIGHTTPD_MAKE_ENV) \
> > +		$(MAKE) $(LIGHTTPD_INSTALL_OPT)
> > +	install -D -m 644 "$(LIGHTTPD_DIR)/doc/config/conf.d/mime.conf" \
> > +		"$(LIGHTTPD_PKGDIR)/etc/lighttpd/conf.d/mime.conf"
> > +	@$(call touch)
> 
> This does not work as expected. I took this from the 
> documentation/ref_manual.

This needs updating. :-/

> Removing the @ before cd I get this:
> 
> cd /home/adahl/Work/bsp/foo/platform-bar/build-target/lighttpd-1.4.45 && 
> \
>           \
>         make 

This only works if the variables are actually set to something useful...

> Seems like those note in the documentation is misleading? When playing 
> with ptxdist print I get something for LIGHTTPD_DIR, which is defined in 
> rules/lighttpd.make and for LIGHTTPD_PKGDIR, which is probably defined 
> somewhere outside. LIGHTTPD_PATH, LIGHTTPD_MAKE_ENV, and 
> LIGHTTPD_INSTALL_OPT however are empty, so no `make install` is called 
> here.
> 
> I tried to find out how other rules do this, and could just find usb-
> modeswitch.make and qt4.make doing something like this:
> 
> 	@$(call install, QT4)

This should be world/install too...

> or 
> 
> 	@$(call world/install, USB_MODESWITCH)

This is correct.

> I assume this can be used to replace the failing three lines, but what's 
> the difference? This is not in the manual, is it? Some other packages 
> use $(call install, …) and yet other packages $(call world/install, …) 
> but none of those autoconf and @package@_INSTALL_OPT?

'install' should not be used. That's old compatibility stuff.
'world/install' uses @package@_INSTALL_OPT if set. If not, "install" is used
as make argument.

> If somebody points me to a solution, I'll send a v2.

Make sure 'world/install' is the first command. It will remove the pkgdir.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de