From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Bastian Stender <bst@pengutronix.de>
Subject: Re: [ptxdist] [PATCH 1/2] avahi: set FILE_OFFSET_BITS to work with 64 bit inodes
Date: Wed, 19 Jul 2017 12:19:40 +0200 [thread overview]
Message-ID: <20170719101940.yrhp7tobhlxsl242@pengutronix.de> (raw)
In-Reply-To: <20170719095920.19192-1-bst@pengutronix.de>
On Wed, Jul 19, 2017 at 11:59:19AM +0200, Bastian Stender wrote:
> In case of 64 bit inodes calls to 32 bit variants of stat() will cause
> EOVERFLOW and avahi will terminate with
>
> Value too large for defined data type
>
> FILE_OFFSET_BITS=64 makes the code receive 64 bit values.
>
> Signed-off-by: Bastian Stender <bst@pengutronix.de>
> ---
> rules/avahi.make | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/rules/avahi.make b/rules/avahi.make
> index 8a10d15ea..2e796bce4 100644
> --- a/rules/avahi.make
> +++ b/rules/avahi.make
> @@ -83,6 +83,8 @@ AVAHI_CONF_OPT := \
> --with-autoipd-group=$(PTXCONF_AVAHI_AUTOIP_GROUP) \
> --with-systemdsystemunitdir=/usr/lib/systemd/system
>
> +AVAHI_CFLAGS:= -D_FILE_OFFSET_BITS=64
> +
I say this should better be done in the configure script of avahi. You
want to add the macro AC_SYS_LARGEFILE there.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2017-07-19 10:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 9:59 Bastian Stender
2017-07-19 9:59 ` [ptxdist] [PATCH 2/2] iptables: " Bastian Stender
2017-07-19 10:19 ` Uwe Kleine-König [this message]
2017-07-24 12:16 ` [ptxdist] [PATCH 1/2] avahi: " Bastian Stender
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170719101940.yrhp7tobhlxsl242@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=bst@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox