[ptxdist] [PATCH 1/2] avahi: set FILE_OFFSET_BITS to work with 64 bit inodes

[ptxdist] [PATCH 1/2] avahi: set FILE_OFFSET_BITS to work with 64 bit inodes

[Bastian Stender]

In case of 64 bit inodes calls to 32 bit variants of stat() will cause
EOVERFLOW and avahi will terminate with

  Value too large for defined data type

FILE_OFFSET_BITS=64 makes the code receive 64 bit values.

Signed-off-by: Bastian Stender <bst@pengutronix.de>
---
 rules/avahi.make | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/rules/avahi.make b/rules/avahi.make
index 8a10d15ea..2e796bce4 100644
--- a/rules/avahi.make
+++ b/rules/avahi.make
@@ -83,6 +83,8 @@ AVAHI_CONF_OPT	:= \
 	--with-autoipd-group=$(PTXCONF_AVAHI_AUTOIP_GROUP) \
 	--with-systemdsystemunitdir=/usr/lib/systemd/system
 
+AVAHI_CFLAGS:= -D_FILE_OFFSET_BITS=64
+
 # ----------------------------------------------------------------------------
 # Target-Install
 # ----------------------------------------------------------------------------
-- 
2.11.0


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

[ptxdist] [PATCH 2/2] iptables: set FILE_OFFSET_BITS to work with 64 bit inodes

[Bastian Stender]

In case of 64 bit inodes calls to 32 bit variants of stat() will cause
EOVERFLOW and iptables will terminate with

  Value too large for defined data type

FILE_OFFSET_BITS=64 makes the code receive 64 bit values.

Signed-off-by: Bastian Stender <bst@pengutronix.de>
---
 rules/iptables.make | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/rules/iptables.make b/rules/iptables.make
index c6effca35..721030aac 100644
--- a/rules/iptables.make
+++ b/rules/iptables.make
@@ -51,6 +51,8 @@ IPTABLES_CONF_OPT	:= \
 	--with-kernel=$(KERNEL_HEADERS_DIR) \
 	--with-xtlibdir=/usr/lib
 
+IPTABLES_CFLAGS:= -D_FILE_OFFSET_BITS=64
+
 # ----------------------------------------------------------------------------
 # Install
 # ----------------------------------------------------------------------------
-- 
2.11.0


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH 1/2] avahi: set FILE_OFFSET_BITS to work with 64 bit inodes

[Uwe Kleine-König]

On Wed, Jul 19, 2017 at 11:59:19AM +0200, Bastian Stender wrote:
> In case of 64 bit inodes calls to 32 bit variants of stat() will cause
> EOVERFLOW and avahi will terminate with
> 
>   Value too large for defined data type
> 
> FILE_OFFSET_BITS=64 makes the code receive 64 bit values.
> 
> Signed-off-by: Bastian Stender <bst@pengutronix.de>
> ---
>  rules/avahi.make | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/rules/avahi.make b/rules/avahi.make
> index 8a10d15ea..2e796bce4 100644
> --- a/rules/avahi.make
> +++ b/rules/avahi.make
> @@ -83,6 +83,8 @@ AVAHI_CONF_OPT	:= \
>  	--with-autoipd-group=$(PTXCONF_AVAHI_AUTOIP_GROUP) \
>  	--with-systemdsystemunitdir=/usr/lib/systemd/system
>  
> +AVAHI_CFLAGS:= -D_FILE_OFFSET_BITS=64
> +

I say this should better be done in the configure script of avahi. You
want to add the macro AC_SYS_LARGEFILE there.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH 1/2] avahi: set FILE_OFFSET_BITS to work with 64 bit inodes

[Bastian Stender]

On 07/19/2017 12:19 PM, Uwe Kleine-König wrote:
> On Wed, Jul 19, 2017 at 11:59:19AM +0200, Bastian Stender wrote:
>> In case of 64 bit inodes calls to 32 bit variants of stat() will cause
>> EOVERFLOW and avahi will terminate with
>>
>>   Value too large for defined data type
>>
>> FILE_OFFSET_BITS=64 makes the code receive 64 bit values.
>>
>> Signed-off-by: Bastian Stender <bst@pengutronix.de>
>> ---
>>  rules/avahi.make | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/rules/avahi.make b/rules/avahi.make
>> index 8a10d15ea..2e796bce4 100644
>> --- a/rules/avahi.make
>> +++ b/rules/avahi.make
>> @@ -83,6 +83,8 @@ AVAHI_CONF_OPT	:= \
>>  	--with-autoipd-group=$(PTXCONF_AVAHI_AUTOIP_GROUP) \
>>  	--with-systemdsystemunitdir=/usr/lib/systemd/system
>>
>> +AVAHI_CFLAGS:= -D_FILE_OFFSET_BITS=64
>> +
>
> I say this should better be done in the configure script of avahi. You
> want to add the macro AC_SYS_LARGEFILE there.

Yes, it would be best to fix this upstream. Simply adding the macro does 
not work with avahi 0.7. I'd say we use this patch for now until someone 
finds time to fix this upsteam.

Bastian

-- 
Pengutronix e.K.
Industrial Linux Solutions
http://www.pengutronix.de/
Peiner Str. 6-8, 31137 Hildesheim, Germany
Amtsgericht Hildesheim, HRA 2686

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de