mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Roland Hieber <r.hieber@pengutronix.de>
Subject: Re: [ptxdist] [PATCH v2] stress: add new package: workload generator for POSIX systems
Date: Thu, 18 May 2017 12:07:37 +0200	[thread overview]
Message-ID: <20170518100737.vtnb4kosbgp4arjp@pengutronix.de> (raw)
In-Reply-To: <20170518095244.15128-1-r.hieber@pengutronix.de>

On Thu, May 18, 2017 at 11:52:44AM +0200, Roland Hieber wrote:
> ---
>  Changes since v1:
>  - regenerate patches with git ptx-patches
>  - stress: add new package: workload generator for POSIX systems
>  - use correct SPDX license code
>  - fix indentations
>  - use simplified install_copy call
> ---
>  .../stress-1.0.4/0001-disable-building-docs.patch  | 30 ++++++++++++
>  patches/stress-1.0.4/series                        |  4 ++
>  rules/stress.in                                    |  9 ++++
>  rules/stress.make                                  | 55 ++++++++++++++++++++++
>  4 files changed, 98 insertions(+)
>  create mode 100644 patches/stress-1.0.4/0001-disable-building-docs.patch
>  create mode 100644 patches/stress-1.0.4/series
>  create mode 100644 rules/stress.in
>  create mode 100644 rules/stress.make
> 
> diff --git a/patches/stress-1.0.4/0001-disable-building-docs.patch b/patches/stress-1.0.4/0001-disable-building-docs.patch
> new file mode 100644
> index 0000000..eb19b71
> --- /dev/null
> +++ b/patches/stress-1.0.4/0001-disable-building-docs.patch
> @@ -0,0 +1,30 @@
> +From: Roland Hieber <rhi@pengutronix.de>
> +Date: Thu, 18 May 2017 11:20:26 +0200
> +Subject: [PATCH] disable building docs
> +
> +Building docs currently fails with errors in doc/stress.texi:

s/fails/fail/

+ maybe

"So exclude the doc folder from building".

> +
> +	stress.texi:68: @itemx must follow @item
> +	stress.texi:87: @itemx must follow @item
> +	stress.texi:102: @itemx must follow @item
> +	stress.texi:105: @itemx must follow @item
> +	stress.texi:120: @itemx must follow @item
> +	stress.texi:123: @itemx must follow @item
> +	Makefile:191: recipe for target 'stress.info' failed
> +---
> + Makefile.in | 2 +-

Hmm, if you don't adapt Makefile.am (I assume there is one?) the next
person who touches something there likely will have to update your patch
to change Makefile.am, too.

So maybe patch Makefile.am instead and call autoreconf?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2017-05-18 10:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-15  8:47 [ptxdist] [PATCH] " Roland Hieber
2017-05-15 14:32 ` Michael Olbrich
2017-05-18  9:52   ` [ptxdist] [PATCH v2] " Roland Hieber
2017-05-18 10:07     ` Uwe Kleine-König [this message]
2017-05-18 10:47       ` [ptxdist] [PATCH v3] " Roland Hieber
2017-05-18 12:38         ` Michael Olbrich
2017-05-19 12:29           ` Roland Hieber
2017-05-19 12:31           ` [ptxdist] [PATCH] " Roland Hieber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170518100737.vtnb4kosbgp4arjp@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    --cc=r.hieber@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox