Re: [ptxdist] [PATCH 2/7] collectd: improve systemd service file

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Apr 21, 2017 at 10:42:01PM +0200, Clemens Gruber wrote:
> collectd supports systemd notify. Also add requirements and increase
> RestartSec. This is the Debian service file without docs and default
> env file.
> 
> Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
> ---
>  projectroot/lib/systemd/system/collectd.service | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/projectroot/lib/systemd/system/collectd.service b/projectroot/lib/systemd/system/collectd.service
> index 752245c05..5748a6438 100644
> --- a/projectroot/lib/systemd/system/collectd.service
> +++ b/projectroot/lib/systemd/system/collectd.service
> @@ -1,9 +1,16 @@
>  [Unit]
> -Description=statistics collection daemon
> +Description=Statistics collection and monitoring daemon

> +After=local-fs.target network.target
> +Requires=local-fs.target network.target

local-fs.target is already implicitly set for both and network.target is
not well defined, but I don't mind if it is set.

> +ConditionPathExists=/etc/collectd/collectd.conf

We always install this, so this is not needed.

>  
>  [Service]
> -ExecStart=/usr/sbin/collectd -f
> +Type=notify
> +NotifyAccess=main

This is the default for Type=notify and can be removed.

> +ExecStartPre=/usr/sbin/collectd -t

Not sure if we need this. The config is quite static on a embedded system.

Michael

> +ExecStart=/usr/sbin/collectd
>  Restart=always
> +RestartSec=10
>  
>  [Install]
>  WantedBy=multi-user.target
> -- 
> 2.12.2
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de