mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] usb-modeswitch: version bump 2.4.0 -> 2.5.0
Date: Fri, 14 Apr 2017 09:39:34 +0200	[thread overview]
Message-ID: <20170414073934.gw6a7mxatiflzo4q@pengutronix.de> (raw)
In-Reply-To: <20170412203424.ahwpdp7uzirujzci@lenoch>

On Wed, Apr 12, 2017 at 10:34:24PM +0200, Ladislav Michl wrote:
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> ---
>  rules/usb-modeswitch.make | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/rules/usb-modeswitch.make b/rules/usb-modeswitch.make
> index ae2891dfe..0db10dabc 100644
> --- a/rules/usb-modeswitch.make
> +++ b/rules/usb-modeswitch.make
> @@ -16,8 +16,8 @@ PACKAGES-$(PTXCONF_USB_MODESWITCH) += usb-modeswitch
>  #
>  # Paths and names
>  #
> -USB_MODESWITCH_VERSION	:= 2.4.0
> -USB_MODESWITCH_MD5	:= 6e1640db47768bb9012f91b7593116ef
> +USB_MODESWITCH_VERSION	:= 2.5.0
> +USB_MODESWITCH_MD5	:= 38ad5c9d70e06227a00361bdc2b1e568
>  USB_MODESWITCH		:= usb-modeswitch-$(USB_MODESWITCH_VERSION)
>  USB_MODESWITCH_SUFFIX	:= tar.bz2
>  USB_MODESWITCH_URL	:= http://www.draisberghof.de/usb_modeswitch/$(USB_MODESWITCH).$(USB_MODESWITCH_SUFFIX)
> @@ -36,6 +36,7 @@ USB_MODESWITCH_CONF_TOOL	:= NO
>  USB_MODESWITCH_MAKE_ENV		:= $(CROSS_ENV)
>  USB_MODESWITCH_MAKE_OPT		:= $(CROSS_ENV_PROGS)
>  USB_MODESWITCH_INSTALL_OPT	:= \
> +	DESTDIR=$(USB_MODESWITCH_PKGDIR) \

Are you sure this is needed? world/install should add this automatically.
If not, then the bug is elsewhere. Please check the output when building
with '-v'.

>  	UDEVDIR=$(USB_MODESWITCH_PKGDIR)/usr/lib/udev \
>  	install
>  
> @@ -68,6 +69,8 @@ $(STATEDIR)/usb-modeswitch.targetinstall:
>  ifneq ($(PTXCONF_USB_MODESWITCH_UDEV_HELPER)$(PTXCONF_USB_MODESWITCH_SYSTEMD_UNIT),)
>  	@$(call install_copy, usb-modeswitch, 0, 0, 0755, -, \
>  		/usr/sbin/usb_modeswitch_dispatcher)
> +	@$(call install_copy, usb-modeswitch, 0, 0, 0644, -, \
> +		/etc/usb_modeswitch.conf)

Use install_alternative, it will use the same file as fallback.

Michael

>  endif
>  ifdef PTXCONF_USB_MODESWITCH_UDEV_HELPER
>  	@$(call install_copy, usb-modeswitch, 0, 0, 0755, -, \
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2017-04-14  7:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-12 20:34 Ladislav Michl
2017-04-14  7:39 ` Michael Olbrich [this message]
2017-04-18 10:50   ` [ptxdist] [PATCH v2] " Ladislav Michl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170414073934.gw6a7mxatiflzo4q@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox