[ptxdist] [PATCH] libcap: disable gperf

[ptxdist] [PATCH] libcap: disable gperf

[Clemens Gruber]

Build fails with the most recent gperf 3.1, disable it because it is not
essential for libcap.

Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
---
 rules/libcap.in   | 1 -
 rules/libcap.make | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/rules/libcap.in b/rules/libcap.in
index 6262467d1..767b4f412 100644
--- a/rules/libcap.in
+++ b/rules/libcap.in
@@ -2,7 +2,6 @@
 
 menuconfig LIBCAP
 	tristate
-	select HOST_GPERF
 	prompt "libcap                        "
 	help
 	  A library for getting and setting POSIX.1e capabilities.
diff --git a/rules/libcap.make b/rules/libcap.make
index bbcea1064..b0e1e0db6 100644
--- a/rules/libcap.make
+++ b/rules/libcap.make
@@ -33,7 +33,7 @@ LIBCAP_LICENSE_FILES := file://License;md5=3f84fd6f29d453a56514cb7e4ead25f1
 # ----------------------------------------------------------------------------
 
 LIBCAP_MAKE_OPT	:= \
-	prefix= PAM_CAP=no DYNAMIC=yes \
+	prefix= BUILD_GPERF=no PAM_CAP=no DYNAMIC=yes \
 	LIBATTR=$(call ptx/ifdef, PTXCONF_LIBCAP_SETCAP,yes,no) \
 	lib=lib \
 	CC=$(CROSS_CC) \
-- 
2.12.1


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] libcap: disable gperf

[Michael Olbrich]

On Fri, Mar 31, 2017 at 01:47:28AM +0200, Clemens Gruber wrote:
> Build fails with the most recent gperf 3.1, disable it because it is not
> essential for libcap.

Hmmm, I'm not sure I like this. using gperf is a runtime performance
optimization and I'd like to keep that. What goes wrong anyways?

Michael

> Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
> ---
>  rules/libcap.in   | 1 -
>  rules/libcap.make | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/rules/libcap.in b/rules/libcap.in
> index 6262467d1..767b4f412 100644
> --- a/rules/libcap.in
> +++ b/rules/libcap.in
> @@ -2,7 +2,6 @@
>  
>  menuconfig LIBCAP
>  	tristate
> -	select HOST_GPERF
>  	prompt "libcap                        "
>  	help
>  	  A library for getting and setting POSIX.1e capabilities.
> diff --git a/rules/libcap.make b/rules/libcap.make
> index bbcea1064..b0e1e0db6 100644
> --- a/rules/libcap.make
> +++ b/rules/libcap.make
> @@ -33,7 +33,7 @@ LIBCAP_LICENSE_FILES := file://License;md5=3f84fd6f29d453a56514cb7e4ead25f1
>  # ----------------------------------------------------------------------------
>  
>  LIBCAP_MAKE_OPT	:= \
> -	prefix= PAM_CAP=no DYNAMIC=yes \
> +	prefix= BUILD_GPERF=no PAM_CAP=no DYNAMIC=yes \
>  	LIBATTR=$(call ptx/ifdef, PTXCONF_LIBCAP_SETCAP,yes,no) \
>  	lib=lib \
>  	CC=$(CROSS_CC) \
> -- 
> 2.12.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] libcap: disable gperf

[Clemens Gruber]

On Fri, Mar 31, 2017 at 03:36:35PM +0200, Michael Olbrich wrote:
> On Fri, Mar 31, 2017 at 01:47:28AM +0200, Clemens Gruber wrote:
> > Build fails with the most recent gperf 3.1, disable it because it is not
> > essential for libcap.
> 
> Hmmm, I'm not sure I like this. using gperf is a runtime performance
> optimization and I'd like to keep that. What goes wrong anyways?

Here is the build log:
arm-v7a-linux-gnueabihf-gcc -O2 -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Dlinux -Wall -Wwrite-strings -Wpointer-arith -Wcast-qual -Wcast-align -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Winline -Wshadow -g  -fPIC -I/home/user/project/platform-foo/build-target/libcap-2.25/libcap/../libcap/include/uapi -I/home/user/project/platform-foo/build-target/libcap-2.25/libcap/../libcap/include -c cap_file.c -o cap_file.o
In file included from <command-line>:0:0:
./_caps_output.gperf:85:15: error: unknown type name 'size_t'
      register size_t n)
               ^~~~~~
./_caps_output.gperf:108:52: error: unknown type name 'size_t'
 __cap_hash_name(register const char *str, register size_t len)
                                                    ^~~~~~
./_caps_output.gperf:207:21: error: unknown type name 'size_t'
            register size_t len)
                     ^~~~~~
./_caps_output.gperf:206:29: error: conflicting types for '__cap_lookup_name'
 const struct __cap_token_s *__cap_lookup_name(register const char *str,
                             ^~~~~~~~~~~~~~~~~
./_caps_output.gperf:33:29: note: previous declaration of '__cap_lookup_name' was here
 const struct __cap_token_s *__cap_lookup_name(const char *, unsigned int);
                             ^~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:63: cap_text.o] Error 1

--

I think I found the problem in the Makefile of libcap. Will send a patch
shortly replacing this patch. Then we can leave gperf 3.1 enabled for
libcap.

Clemens

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] libcap: disable gperf

[Michael Olbrich]

On Fri, Mar 31, 2017 at 04:32:26PM +0200, Clemens Gruber wrote:
> On Fri, Mar 31, 2017 at 03:36:35PM +0200, Michael Olbrich wrote:
> > On Fri, Mar 31, 2017 at 01:47:28AM +0200, Clemens Gruber wrote:
> > > Build fails with the most recent gperf 3.1, disable it because it is not
> > > essential for libcap.
> > 
> > Hmmm, I'm not sure I like this. using gperf is a runtime performance
> > optimization and I'd like to keep that. What goes wrong anyways?
> 
> Here is the build log:
[...]
> make[2]: *** [Makefile:63: cap_text.o] Error 1
> 
> --
> 
> I think I found the problem in the Makefile of libcap. Will send a patch
> shortly replacing this patch. Then we can leave gperf 3.1 enabled for
> libcap.

I'll wait with applying these patches until after the release. I've looked
at the changelog and that looks like it might break other stuff too.

Please keep an eye on it and remind me if I forget to apply this after the
release.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de