mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] libcap: disable gperf
Date: Fri, 31 Mar 2017 15:36:35 +0200	[thread overview]
Message-ID: <20170331133635.3auam5ghmrveomrb@pengutronix.de> (raw)
In-Reply-To: <20170330234728.18540-1-clemens.gruber@pqgruber.com>

On Fri, Mar 31, 2017 at 01:47:28AM +0200, Clemens Gruber wrote:
> Build fails with the most recent gperf 3.1, disable it because it is not
> essential for libcap.

Hmmm, I'm not sure I like this. using gperf is a runtime performance
optimization and I'd like to keep that. What goes wrong anyways?

Michael

> Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
> ---
>  rules/libcap.in   | 1 -
>  rules/libcap.make | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/rules/libcap.in b/rules/libcap.in
> index 6262467d1..767b4f412 100644
> --- a/rules/libcap.in
> +++ b/rules/libcap.in
> @@ -2,7 +2,6 @@
>  
>  menuconfig LIBCAP
>  	tristate
> -	select HOST_GPERF
>  	prompt "libcap                        "
>  	help
>  	  A library for getting and setting POSIX.1e capabilities.
> diff --git a/rules/libcap.make b/rules/libcap.make
> index bbcea1064..b0e1e0db6 100644
> --- a/rules/libcap.make
> +++ b/rules/libcap.make
> @@ -33,7 +33,7 @@ LIBCAP_LICENSE_FILES := file://License;md5=3f84fd6f29d453a56514cb7e4ead25f1
>  # ----------------------------------------------------------------------------
>  
>  LIBCAP_MAKE_OPT	:= \
> -	prefix= PAM_CAP=no DYNAMIC=yes \
> +	prefix= BUILD_GPERF=no PAM_CAP=no DYNAMIC=yes \
>  	LIBATTR=$(call ptx/ifdef, PTXCONF_LIBCAP_SETCAP,yes,no) \
>  	lib=lib \
>  	CC=$(CROSS_CC) \
> -- 
> 2.12.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2017-03-31 13:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-30 23:47 Clemens Gruber
2017-03-31 13:36 ` Michael Olbrich [this message]
2017-03-31 14:32   ` Clemens Gruber
2017-03-31 15:15     ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170331133635.3auam5ghmrveomrb@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox