From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v4] kmscube: add new package
Date: Mon, 20 Mar 2017 12:25:39 +0100 [thread overview]
Message-ID: <20170320112539.v5t3dk5tql6kyfwx@pengutronix.de> (raw)
In-Reply-To: <201703201212.30993.jbe@pengutronix.de>
On Mon, Mar 20, 2017 at 12:12:30PM +0100, Juergen Borleis wrote:
> On Monday 20 March 2017 12:00:57 Markus Niebel wrote:
> > [...]
> > +config KMSCUBE
> > + bool
> > + prompt "kmscube"
> > + select MESALIB
> > + select LIBDRM
> > + help
> > + kmscube is an application to test kms/drm drivers.
> > [...]
> > ----------------------------------------------------------------------------
> > +# Prepare
> > +#
> > ----------------------------------------------------------------------------
> > +
> > +KMSCUBE_CPPFLAGS += \
> > + -I$(KERNEL_HEADERS_INCLUDE_DIR)
>
> If you need the kernel headers, then you also need a "select KERNEL_HEADER"
> in your 'kmscube.in' file.
No, please don't. It really depends on the toolchain version. And the
kernel header package is explicitly built early so it can be enabled for
old toolchains.
What we should do is move the kernel headers kconfig option to the
platformconfig.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2017-03-20 11:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 11:00 Markus Niebel
2017-03-20 11:12 ` Juergen Borleis
2017-03-20 11:25 ` Michael Olbrich [this message]
2017-03-20 11:50 ` Markus Niebel
2017-03-24 15:50 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320112539.v5t3dk5tql6kyfwx@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox