* [ptxdist] [PATCH 1/1] kernel: Fix iio generic_buffer tool name
@ 2016-12-21 7:05 Alexander Stein
2016-12-21 7:50 ` Alexander Dahl
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Stein @ 2016-12-21 7:05 UTC (permalink / raw)
To: ptxdist; +Cc: Alexander Stein
Starting with kernel 4.8 this has been renamed to iio_generic_buffer.
Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
---
rules/kernel.make | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rules/kernel.make b/rules/kernel.make
index d02a69c..fca5623 100644
--- a/rules/kernel.make
+++ b/rules/kernel.make
@@ -252,7 +252,7 @@ ifdef PTXCONF_KERNEL_TOOL_PERF
endif
ifdef PTXCONF_KERNEL_TOOL_IIO
- @$(call install_copy, kernel, 0, 0, 0755, $(KERNEL_DIR)/tools/iio/generic_buffer, \
+ @$(call install_copy, kernel, 0, 0, 0755, $(KERNEL_DIR)/tools/iio/iio_generic_buffer, \
/usr/bin/iio_generic_buffer)
@$(call install_copy, kernel, 0, 0, 0755, $(KERNEL_DIR)/tools/iio/lsiio, \
/usr/bin/lsiio)
--
2.10.2
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH 1/1] kernel: Fix iio generic_buffer tool name
2016-12-21 7:05 [ptxdist] [PATCH 1/1] kernel: Fix iio generic_buffer tool name Alexander Stein
@ 2016-12-21 7:50 ` Alexander Dahl
2017-01-04 16:41 ` Michael Olbrich
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Dahl @ 2016-12-21 7:50 UTC (permalink / raw)
To: ptxdist
[-- Attachment #1.1: Type: text/plain, Size: 812 bytes --]
Hei hei,
On Wed, Dec 21, 2016 at 08:05:20AM +0100, Alexander Stein wrote:
> ifdef PTXCONF_KERNEL_TOOL_IIO
> - @$(call install_copy, kernel, 0, 0, 0755, $(KERNEL_DIR)/tools/iio/generic_buffer, \
> + @$(call install_copy, kernel, 0, 0, 0755, $(KERNEL_DIR)/tools/iio/iio_generic_buffer, \
> /usr/bin/iio_generic_buffer)
> @$(call install_copy, kernel, 0, 0, 0755, $(KERNEL_DIR)/tools/iio/lsiio, \
> /usr/bin/lsiio)
Would it be possible to make this dependent on the actually used
kernel version?
Greets
Alex
--
»With the first link, the chain is forged. The first speech censured,
the first thought forbidden, the first freedom denied, chains us all
irrevocably.« (Jean-Luc Picard, quoting Judge Aaron Satie)
*** GnuPG-FP: C28E E6B9 0263 95CF 8FAF 08FA 34AD CD00 7221 5CC6 ***
[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 91 bytes --]
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH 1/1] kernel: Fix iio generic_buffer tool name
2016-12-21 7:50 ` Alexander Dahl
@ 2017-01-04 16:41 ` Michael Olbrich
2017-01-04 16:43 ` Michael Olbrich
0 siblings, 1 reply; 6+ messages in thread
From: Michael Olbrich @ 2017-01-04 16:41 UTC (permalink / raw)
To: ptxdist
On Wed, Dec 21, 2016 at 08:50:48AM +0100, Alexander Dahl wrote:
> Hei hei,
>
> On Wed, Dec 21, 2016 at 08:05:20AM +0100, Alexander Stein wrote:
> > ifdef PTXCONF_KERNEL_TOOL_IIO
> > - @$(call install_copy, kernel, 0, 0, 0755, $(KERNEL_DIR)/tools/iio/generic_buffer, \
> > + @$(call install_copy, kernel, 0, 0, 0755, $(KERNEL_DIR)/tools/iio/iio_generic_buffer, \
> > /usr/bin/iio_generic_buffer)
> > @$(call install_copy, kernel, 0, 0, 0755, $(KERNEL_DIR)/tools/iio/lsiio, \
> > /usr/bin/lsiio)
>
> Would it be possible to make this dependent on the actually used
> kernel version?
$(call install_glob, kernel, 0, 0, $(KERNEL_DIR)/tools/iio, /usr/bin, \
/generic_buffer /iio_generic_buffer)
I think (untested). That should find either file.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH 1/1] kernel: Fix iio generic_buffer tool name
2017-01-04 16:41 ` Michael Olbrich
@ 2017-01-04 16:43 ` Michael Olbrich
2017-01-05 7:11 ` Alexander Stein
0 siblings, 1 reply; 6+ messages in thread
From: Michael Olbrich @ 2017-01-04 16:43 UTC (permalink / raw)
To: ptxdist
On Wed, Jan 04, 2017 at 05:41:47PM +0100, Michael Olbrich wrote:
> On Wed, Dec 21, 2016 at 08:50:48AM +0100, Alexander Dahl wrote:
> > Hei hei,
> >
> > On Wed, Dec 21, 2016 at 08:05:20AM +0100, Alexander Stein wrote:
> > > ifdef PTXCONF_KERNEL_TOOL_IIO
> > > - @$(call install_copy, kernel, 0, 0, 0755, $(KERNEL_DIR)/tools/iio/generic_buffer, \
> > > + @$(call install_copy, kernel, 0, 0, 0755, $(KERNEL_DIR)/tools/iio/iio_generic_buffer, \
> > > /usr/bin/iio_generic_buffer)
> > > @$(call install_copy, kernel, 0, 0, 0755, $(KERNEL_DIR)/tools/iio/lsiio, \
> > > /usr/bin/lsiio)
> >
> > Would it be possible to make this dependent on the actually used
> > kernel version?
>
> $(call install_glob, kernel, 0, 0, $(KERNEL_DIR)/tools/iio, /usr/bin, \
> /generic_buffer /iio_generic_buffer)
>
> I think (untested). That should find either file.
Hmm, that doesn't work. The original code renamed the file.
I _think_ using some $(wildcard ...) stuff may work though, for the source
file.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH 1/1] kernel: Fix iio generic_buffer tool name
2017-01-04 16:43 ` Michael Olbrich
@ 2017-01-05 7:11 ` Alexander Stein
2017-01-05 9:13 ` Michael Olbrich
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Stein @ 2017-01-05 7:11 UTC (permalink / raw)
To: ptxdist
On Wednesday 04 January 2017 17:43:37, Michael Olbrich wrote:
> On Wed, Jan 04, 2017 at 05:41:47PM +0100, Michael Olbrich wrote:
> > On Wed, Dec 21, 2016 at 08:50:48AM +0100, Alexander Dahl wrote:
> > > Hei hei,
> > >
> > > On Wed, Dec 21, 2016 at 08:05:20AM +0100, Alexander Stein wrote:
> > > > ifdef PTXCONF_KERNEL_TOOL_IIO
> > > >
> > > > - @$(call install_copy, kernel, 0, 0, 0755,
> > > > $(KERNEL_DIR)/tools/iio/generic_buffer, \ + @$(call install_copy,
> > > > kernel, 0, 0, 0755, $(KERNEL_DIR)/tools/iio/iio_generic_buffer, \> > >
> > > > /usr/bin/iio_generic_buffer)
> > > >
> > > > @$(call install_copy, kernel, 0, 0, 0755,
> > > > $(KERNEL_DIR)/tools/iio/lsiio, \
> > > >
> > > > /usr/bin/lsiio)
> > >
> > > Would it be possible to make this dependent on the actually used
> > > kernel version?
> >
> > $(call install_glob, kernel, 0, 0, $(KERNEL_DIR)/tools/iio, /usr/bin, \
> >
> > /generic_buffer /iio_generic_buffer)
> >
> > I think (untested). That should find either file.
>
> Hmm, that doesn't work. The original code renamed the file.
> I _think_ using some $(wildcard ...) stuff may work though, for the source
> file.
But this would rename the file in some cases, no? I would keep the filename as
it is.
Best regards,
Alexander
--
Dipl.-Inf. Alexander Stein
SYS TEC electronic GmbH
alexander.stein@systec-electronic.com
Legal and Commercial Address:
Am Windrad 2
08468 Heinsdorfergrund
Germany
Office: +49 (0) 3765 38600-0
Fax: +49 (0) 3765 38600-4100
Managing Directors:
Director Technology/CEO: Dipl.-Phys. Siegmar Schmidt;
Director Commercial Affairs/COO: Dipl. Ing. (FH) Armin von Collrepp
Commercial Registry:
Amtsgericht Chemnitz, HRB 28082; USt.-Id Nr. DE150534010
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH 1/1] kernel: Fix iio generic_buffer tool name
2017-01-05 7:11 ` Alexander Stein
@ 2017-01-05 9:13 ` Michael Olbrich
0 siblings, 0 replies; 6+ messages in thread
From: Michael Olbrich @ 2017-01-05 9:13 UTC (permalink / raw)
To: ptxdist
On Thu, Jan 05, 2017 at 08:11:06AM +0100, Alexander Stein wrote:
> On Wednesday 04 January 2017 17:43:37, Michael Olbrich wrote:
> > On Wed, Jan 04, 2017 at 05:41:47PM +0100, Michael Olbrich wrote:
> > > On Wed, Dec 21, 2016 at 08:50:48AM +0100, Alexander Dahl wrote:
> > > > Hei hei,
> > > >
> > > > On Wed, Dec 21, 2016 at 08:05:20AM +0100, Alexander Stein wrote:
> > > > > ifdef PTXCONF_KERNEL_TOOL_IIO
> > > > >
> > > > > - @$(call install_copy, kernel, 0, 0, 0755,
> > > > > $(KERNEL_DIR)/tools/iio/generic_buffer, \ + @$(call install_copy,
> > > > > kernel, 0, 0, 0755, $(KERNEL_DIR)/tools/iio/iio_generic_buffer, \> > >
> > > > > /usr/bin/iio_generic_buffer)
> > > > >
> > > > > @$(call install_copy, kernel, 0, 0, 0755,
> > > > > $(KERNEL_DIR)/tools/iio/lsiio, \
> > > > >
> > > > > /usr/bin/lsiio)
> > > >
> > > > Would it be possible to make this dependent on the actually used
> > > > kernel version?
> > >
> > > $(call install_glob, kernel, 0, 0, $(KERNEL_DIR)/tools/iio, /usr/bin, \
> > >
> > > /generic_buffer /iio_generic_buffer)
> > >
> > > I think (untested). That should find either file.
> >
> > Hmm, that doesn't work. The original code renamed the file.
> > I _think_ using some $(wildcard ...) stuff may work though, for the source
> > file.
>
> But this would rename the file in some cases, no? I would keep the filename as
> it is.
That's what the old code already does. The file should always be named
iio_generic_buffer.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-01-05 9:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-21 7:05 [ptxdist] [PATCH 1/1] kernel: Fix iio generic_buffer tool name Alexander Stein
2016-12-21 7:50 ` Alexander Dahl
2017-01-04 16:41 ` Michael Olbrich
2017-01-04 16:43 ` Michael Olbrich
2017-01-05 7:11 ` Alexander Stein
2017-01-05 9:13 ` Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox