Re: [ptxdist] [PATCH] iperf: version bump

[Michael Olbrich <m.olbrich@pengutronix.de>]

Hi,

On Sat, Dec 17, 2016 at 08:51:10PM +0100, Clemens Gruber wrote:
> On Fri, Dec 16, 2016 at 04:12:51PM +0100, Michael Olbrich wrote:
> > Well, the configure options could use some cleanup in general, but that's
> > nothing new.
> 
> You mean adding the (current) default options explicitly, right?
> 
> To sum up the update checklist:
> 1) Check the diff of the configure --help outputs between the versions
> 2) Check if options were missing/suboptimal before
> 3) Check if they are in alphabetical order

Not alphabetical. Same order as 'configure --help'.
I Open the makefile and diff next to each other in my editor. That makes it
easy to see if
a) the old options are ok
b) what new options need to be added and where

> 4) Check if there are new binaries/libraries

For larger packages I usually compare 'find <platform>/packages/<pkg>'.
Usually with some tweeks to sort and filter out docs and headers etc.

> 5) Move/remove the patches

Very important. Especially patches for other architectures are often
forgotten.

> 6) Testing
> 
> Tooling would be nice. But probably not worth the effort. Maybe for the
> download, extract and ./configure --help diff.. what do you think?

What I usually do is:
- build & install the old version
- change the version number
- 'ptxdist extract <pkg>'
- update the options
- 'ptxdist install <pkg>'
- update the targetinstall stage
- 'ptxdist targetinstall <pkg>'
- test

> > And for all packages: I prefer it if the subject contains '<oldversion> ->
> > <newversion>'. It makes review easier. That way it's easier to see which
> > updates a small patch-level updates and require less review (and can be
> > applied shortly before a release) and which require a deeper look.
> 
> I'll keep the subjects for the v2 but will use the -> notation next
> time. (?)

Yes. No need to change the current patches.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de