Re: [ptxdist] [PATCH] nginx: new package

[Clemens Gruber <clemens.gruber@pqgruber.com>]

Hi Michael, Hi Jürgen,

thanks for the comments!

On Tue, Nov 29, 2016 at 10:10:01AM +0100, Michael Olbrich wrote:
> On Sun, Nov 06, 2016 at 08:12:18PM +0100, Clemens Gruber wrote:
> > Add nginx package. Heavily inspired by Buildroot's nginx.mk, using their
> > revised patches for 1.10.x and the endian patch from Marc Kleine-Budde,
> > as well as the nginx.make from the patchset Robert sent, as a starting
> > point.
> 
> Do you know if anyone has tried to upstream the cross-compile patches?

Yes, but they were not accepted:
http://mailman.nginx.org/pipermail/nginx-devel/2014-May/005318.html
http://mailman.nginx.org/pipermail/nginx-devel/2014-September/006013.html
They want them to be less intrusive, more portable (+MSVC), without
deactivating all tests. They seem to be pretty strict in what they
accept. Looks like the author of the patch series gave up and is afaik
now maintaining them out of tree in the Buildroot repo.

> 
> > But instead of building the modules by default, each module is
> > selectable in PTXdist, to allow reducing the binary size.
> > 
> > Most popular modules are supported, systemd unit file and basic
> > configuration files are included as well.
> > Supports SSL, HTTP/2, HTTP Proxying, GZIP, Auth Basic, Rewrite, FastCGI,
> > SCGI, uWSGI, etc.
> > 
> > Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
> > ---
> >  ...izeof-rework-autotest-to-be-cross-compila.patch |  87 +++++++++
> >  ...e-add-mechanism-allowing-to-force-feature.patch | 135 +++++++++++++
> >  ...x_feature_run_force_result-for-each-featu.patch | 213 +++++++++++++++++++++
> >  ...0004-auto-lib-libxslt-conf-use-pkg-config.patch |  31 +++
> >  ...nix-make-sys_nerr-guessing-cross-friendly.patch | 138 +++++++++++++
> >  ...0006-auto-lib-openssl-conf-use-pkg-config.patch |  31 +++
> >  .../0007-auto-lib-libgd-conf-use-pkg-config.patch  |  31 +++
> >  ...-ngx_linux_config.h-only-include-dlfcn.h-.patch |  33 ++++
> >  ...ness-add-mechanism-allowing-to-force-resu.patch |  26 +++
> >  patches/nginx-1.10.2/series                        |  11 ++
> >  projectroot/etc/nginx/mime.types                   |  89 +++++++++
> 
> Why did you add this file? nginx installs it into pkgdir and
> install_alternative will use that as a fallback.

Right, I'll remove it.

(snip)

> > +# Note: Settings and module options are *not* symmetric.
> > +#       If a module is on by default, a without option exists.
> > +#       If it is off by default, a with option exists.
> > +
> > +# Opt-in settings
> > +
> 
> NGINX_CONF_OPT += \
> 	$(call ptx/ifdef, PTXCONF_*,--with-*) \
> 	[...]
> 
> For each Opt-in/Opt-out etc. group. Or just one block with all modules. Or
> make list + foreach magic like I handled the gstreamer plugins. Either way
> is fine, I just want this to be more compact.

Will do.

(snip)

> > +
> > +ifdef PTXCONF_SYSTEMD
> 
> No, never use an option from a different package directly. Either install
> this unconditionally (I'd prefer that) or add an options without prompt
> that defaults to SYSTEMD.

OK.

I'd also remove the NGINX_OPENSSL setting from the "Base settings"
menu, because the http_ssl and http_v2 modules select it anyway and we
could select OPENSSL at the top if those modules are enabled.
Or would you prefer that I keep NGINX_OPENSSL but remove its prompt?

Thanks,
Clemens

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de