Re: [ptxdist] [PATCH 1/2] kernel: pass loadaddr for building uImage

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Tue, Nov 29, 2016 at 10:04:19AM +0100, Marc Kleine-Budde wrote:
> On 11/28/2016 05:46 PM, Michael Olbrich wrote:
> > On Mon, Nov 28, 2016 at 11:21:31AM +0100, Alexander Dahl wrote:
> >> On newer kernels (4.x ?) kernel build fails when building an uImage
> >> unless you provide LOADADDR as kernel make var, which is put in the
> >> resulting uImage header. You could append it to
> >> PTXCONF_KERNEL_EXTRA_MAKEVARS but this would be just a workaround. This
> >> patch extends the menu if uImage is selected so you can directly input
> >> the desired address.
> > 
> > I don't have a lot of experience with uImages. Marc, what do you think?
> 
> According to rmk uimages are considered obsolete. However there are
> probably some old bootloaders around that insist of that format.
> 
> >> Signed-off-by: Alexander Dahl <post@lespocky.de>
> >> ---
> >>  platforms/kernel.in | 7 +++++++
> >>  rules/kernel.make   | 5 +++++
> >>  2 files changed, 12 insertions(+)
> >>
> >> diff --git a/platforms/kernel.in b/platforms/kernel.in
> >> index fd1c492..2a00122 100644
> >> --- a/platforms/kernel.in
> >> +++ b/platforms/kernel.in
> >> @@ -213,6 +213,13 @@ config KERNEL_IMAGE
> >>  config KERNEL_DTC
> >>  	bool
> >>  
> >> +config KERNEL_LOADADDR
> >> +	hex
> >> +	prompt "uImage load address"
> >> +	depends on KERNEL_IMAGE_U
> >> +	help
> >> +	  Newer kernels want this passed if you build an uImage.
> >> +
> > 
> > This should be right after the image selection.
> > 
> > Michael
> > 
> >>  config KERNEL_XZ
> >>  	prompt "build xz-utils hosttool"
> >>  	bool
> >> diff --git a/rules/kernel.make b/rules/kernel.make
> >> index d02a69c..3270231 100644
> >> --- a/rules/kernel.make
> >> +++ b/rules/kernel.make
> >> @@ -71,6 +71,11 @@ KERNEL_MAKEVARS += \
> >>  	DEPMOD=$(PTXCONF_SYSROOT_HOST)/sbin/depmod
> >>  endif
> >>  
> >> +ifdef PTXCONF_KERNEL_IMAGE_U
> >> +KERNEL_MAKEVARS += \
> >> +	LOADADDR=$(PTXCONF_KERNEL_LOADADDR)
> >> +endif
> >> +
> 
> What happens if you build a older kernel and don't configure
> PTXCONF_KERNEL_LOADADDR via ptxdist? Does it break while it used to work
> with an older ptxdist?

We should add an 'empty' check. And the help text should include the kernel
version that introduced this requirement.

Michael


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de